[Bug 24127] New: Using the dropdown option of Shelving Location as a search choice retrieves no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Bug ID: 24127 Summary: Using the dropdown option of Shelving Location as a search choice retrieves no results Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: nick@bywatersolutions.com Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Shelving location is an option in the dropdown option in both a basic search and the advanced search on the Staff Client. This search does not work in either place. It is unclear what Koha would want in this search, would a user type the shelving location description or code? Since this option is secondary to the other ways (in the advanced search (using the checkmark boxes under shelving location) and item search) - I believe this option in the dropdown menu should be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 95842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95842&action=edit Bug 24127: Remove 'Shelving location' from search dropdown To test: 1 - In staff client enable IntranetCatalogSearchPulldown 2 - Click on the 'Search the catalog' tab 3 - Note 'Shelving location' option in dropdown 4 - Search for code or description of a locatio, no results 5 - Repeat on advanced search 6 - Apply patch 7 - Note option is now removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu --- Comment #2 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- I'm not able to test this bug fully because performing a search by shelving location does work when Elasticsearch is enabled and the code is used. For example, in the sample database a search for shelving location (dropdown) General Stacks does not return results. However, a search for shelving location (dropdown) GEN returns 352 results. Is it really necessary to remove the option? It can be helpful. The checkmark boxes in the advanced search and item search are designed to function as search limiters. This is not the same thing as searching shelving location as a field. At the very least, I think it should remain as an option in the dropdown for the advanced search for the purposes of building complex queries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Hi Myka, The reason we looked towards removal is because we didn't see this as the usual way to search for shelving locations and shouldn't be the standard. While the search does work under ES, it also works via ccl, so even without the patch one can search for "location:GEN" and achieve the same results. In general, however, the item search allows for a very specific search like this and would be the preference I think. Let me know if that sounds reasonable to you. -Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8266 CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is consistent with the change made to the OPAC on bug 8266. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using the dropdown option |Remove dropdown option of |of Shelving Location as a |shelving location from |search choice retrieves no |advanced search in staff |results | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95842|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96077&action=edit Bug 24127: Remove 'Shelving location' from search dropdown To test: 1 - In staff client enable IntranetCatalogSearchPulldown 2 - Click on the 'Search the catalog' tab 3 - Note 'Shelving location' option in dropdown 4 - Search for code or description of a locatio, no results 5 - Repeat on advanced search 6 - Apply patch 7 - Note option is now removed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22426 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I understand why we removed it from the OPAC, it does not mean anything for a regular users. But, staff-side, how could we know we are not doing to break someone's workflow? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6)
I understand why we removed it from the OPAC, it does not mean anything for a regular users. But, staff-side, how could we know we are not doing to break someone's workflow?
The only scenario it works under is ES, which is a limited user set at this point so the likelihood is small. The working result is reproducible under the advanced search as well, without requiring user to know the codes for itemtypes. The search will still work via direct-query, JS can be added to restore the option if a user needs it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #8 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- I share your concern, Jonathan. I recently needed to use the drop-down in the staff client to perform a search across two shelving locations because the limit by shelving location option is currently compiling the query statement with AND instead of OR (see bug #24109). Even though searches using ccl will continue to work without the drop-down, as Nick pointed out, having the drop-down as an option makes it easier to build these queries, which I think most library staff appreciate. What would it take to make this search index work in Zebra? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Myka Kennedy Stephens from comment #8)
I share your concern, Jonathan. I recently needed to use the drop-down in the staff client to perform a search across two shelving locations because the limit by shelving location option is currently compiling the query statement with AND instead of OR (see bug #24109).
Even though searches using ccl will continue to work without the drop-down, as Nick pointed out, having the drop-down as an option makes it easier to build these queries, which I think most library staff appreciate.
What would it take to make this search index work in Zebra?
But should the answer then not be to fix bug 24109? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #10 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- (In reply to Katrin Fischer, comment #9) Absolutely, bug 24109 should be fixed. It looks like that is well underway. (Thank you, Nick!) I didn't mean to start a heated debate. I was sharing a recent experience when I was particularly thankful for the easy access to search by item location in the staff-client advanced search. Since the search does work with ES, it is possible that other libraries (small in number, yes) are using this search function more regularly than we do at my library. Yes, I know shelving location is still searchable using ccl. And yes, I am aware that it could be added back in with JS if a library really needed it. In the use case I presented, which was different from an everyday workflow, I would have found it annoying to remember the right ccl syntax in that moment--but perhaps that says more about my personality than Koha! :-) If shelving location searching didn't work in both Zebra and ES, I would see a clear reason to remove it. But since it works in one and not the other, I think it is important to carefully consider the benefits and drawbacks to all users, both Zebra and ES. The more ES development takes place, it is likely that we will run into more of these scenarios where something will work with one search engine and not the other. Do we really want to remove a feature from Koha because it doesn't work with Zebra, despite the fact that it works with ES? Perhaps a compromise would be to keep shelving location as a drop-down option in the staff client advanced search only? If there's too much backing to remove it altogether, I won't stand in the way. I've said my piece. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Myka, doesn't feel heated to me, but interesting :) My concern is that the majority might be confused by the search as it requires the location authorised value code to be entered and not the name of the location. The reason it was removed from OPAC were reports of it 'not working' - well, not working as expected :) Maybe the fix is to name it 'location code' on staff side? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not ready for QA yet, switching status to "In Discussion". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140867&action=edit Bug 24127: Add 'code' and title to shelving location search This patch attempts to clarify the 'Shelving location' option in the staff side dropdown, as it requires searching the shelving location code, not the values. i.e. 'FIC' not 'Fiction' This patch adds (code) to the option and adds a title, visible on hover -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140867|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 140966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140966&action=edit Bug 24127: Add 'code' and title to shelving location search This patch attempts to clarify the 'Shelving location' option in the staff side dropdown, as it requires searching the shelving location code, not the values. i.e. 'FIC' not 'Fiction' This patch adds (code) to the option and adds a title, visible on hover Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #15 from David Nind <david@davidnind.com> --- I've tested the 2 patches separately, and they both work. I have signed off on Nick's patch as it clarifies what is required, instead of removing the option. Happy to sign off Katrin's patch if that is the preferred option. One will need to be obsoleted! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove dropdown option of |Improve wording on location |shelving location from |drop-down in advanced |advanced search in staff |search in the staff | |interface Text to go in the| |This amends the "Shelving release notes| |location" option in the | |search option drop-down on | |the advanced search page in | |the staff interface to read | |"Shelving location (code)" | |to make it more obvious | |that the LOC authorised | |value code needs to be used | |for searching. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140966|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141015&action=edit Bug 24127: Add 'code' and title to shelving location search This patch attempts to clarify the 'Shelving location' option in the staff side dropdown, as it requires searching the shelving location code, not the values. i.e. 'FIC' not 'Fiction' This patch adds (code) to the option and adds a title, visible on hover Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am happy to rephrese it. 2 notes from testing: Maybe this would read a little nicer: Enter location code value for search => Enter location authorised value code for search Can we safely assume that the field will always be used with an AV? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org