https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 127217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127217&action=edit Bug 29392: Add plugin hooks before merging biblios or authorities Hooks are called 'before_biblio_action' and 'before_authority_action' and they both take an 'action' parameter whose value is 'merge'. Other parameters include the record id (biblionumber or authid), the object itself (Koha::Biblio or Koha::Authority), the MARC::Record about to be saved (so plugins can modify it), and the list of record ids that will be deleted after the merge. Test plan: 1. Create a plugin with these two methods. For instance: sub before_biblio_action { my ($self, $args) = @_; my $action = $args->{action}; return unless $action eq 'merge'; my $record = $args->{record}; my $merged_biblio_ids = $args->{merged_biblio_ids}; if ($record && $merged_biblio_ids) { my @fields = map { MARC::Field->new('035', ' ', ' ', 'z' => $_) } @$merged_biblio_ids; $record->insert_fields_ordered(@fields); } } sub before_authority_action { my ($self, $args) = @_; my $action = $args->{action}; return unless $action eq 'merge'; my $record = $args->{record}; my $merged_authority_ids = $args->{merged_authority_ids}; if ($record && $merged_authority_ids) { my @fields = map { MARC::Field->new('035', ' ', ' ', 'z' => $_) } @$merged_authority_ids; $record->insert_fields_ordered(@fields); } } This will copy the identifier of deleted records inside 035$z of the final record. (035$z is for "Canceled/invalid system control number") 2. Add the plugin path to your $KOHA_CONF 3. Run misc/devel/install_plugins.pl. It should say: Installed <YOUR_PLUGIN_NAME> version <YOUR_PLUGIN_VERSION> 4. Apply patch and restart starman 5. Create two or more biblios with the same title. Make sure they are indexed in your search engine. 6. Search for them. In the results check their corresponding boxes and click on "Edit -> Merge records" 7. Merge them and verify that your plugin code was called. If you used the example above, verify that it added a 035$z for each deleted record. 8. Do the same for authorities -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Maybe create a KPZ to ease testing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28173 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I just noticed this one, after submitting bug 34943. The chosen name for the hook is not specific enough, given the fact it is only called on merging records. Regarding testing it, I would say the best is to write tests for it :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Actually.. I think this is more in keeping with the existing 'after_biblio_action' found in C4::Biblio Tomas.. we should probably rename yours and pass an 'action' to be consistent. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127217|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163329&action=edit Bug 29392: Add plugin hooks before merging biblios or authorities Hooks are called 'before_biblio_action' and 'before_authority_action' and they both take an 'action' parameter whose value is 'merge'. Other parameters include the record id (biblionumber or authid), the object itself (Koha::Biblio or Koha::Authority), the MARC::Record about to be saved (so plugins can modify it), and the list of record ids that will be deleted after the merge. Test plan: 1. Create a plugin with these two methods. For instance: sub before_biblio_action { my ($self, $args) = @_; my $action = $args->{action}; return unless $action eq 'merge'; my $record = $args->{record}; my $merged_biblio_ids = $args->{merged_biblio_ids}; if ($record && $merged_biblio_ids) { my @fields = map { MARC::Field->new('035', ' ', ' ', 'z' => $_) } @$merged_biblio_ids; $record->insert_fields_ordered(@fields); } } sub before_authority_action { my ($self, $args) = @_; my $action = $args->{action}; return unless $action eq 'merge'; my $record = $args->{record}; my $merged_authority_ids = $args->{merged_authority_ids}; if ($record && $merged_authority_ids) { my @fields = map { MARC::Field->new('035', ' ', ' ', 'z' => $_) } @$merged_authority_ids; $record->insert_fields_ordered(@fields); } } This will copy the identifier of deleted records inside 035$z of the final record. (035$z is for "Canceled/invalid system control number") 2. Add the plugin path to your $KOHA_CONF 3. Run misc/devel/install_plugins.pl. It should say: Installed <YOUR_PLUGIN_NAME> version <YOUR_PLUGIN_VERSION> 4. Apply patch and restart starman 5. Create two or more biblios with the same title. Make sure they are indexed in your search engine. 6. Search for them. In the results check their corresponding boxes and click on "Edit -> Merge records" 7. Merge them and verify that your plugin code was called. If you used the example above, verify that it added a 035$z for each deleted record. 8. Do the same for authorities Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and added a consistency follow-up... we aught to have unit tests, but as we're at the controller level that's not quite as trivial as our other hook unit tests. I'm opting to PQA for now but hope in the future the logic of these merge op's will make it's way into the Model level. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- With bug 33036 having just been pushed, I think we need to move the before_biblio hooks here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Julian, do you have these hooks in use already? I'm wondering about the use cases and whether a mix of hooks for 'save' and 'merge' might make sense? Tomas's bug 34943 allows for hooking on the biblio metadata change action, whilst a hook added to the merge_with method introduced by bug 33036 would allow for hooking on the biblio and item level data combination during merge. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Bug 29392 depends on bug 33036, which changed state. Bug 33036 Summary: Add route to merge bibliographic records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33036 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.