[Bug 17610] New: Allow the number of plack workers and max connections to be set in koha-conf.xml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Bug ID: 17610 Summary: Allow the number of plack workers and max connections to be set in koha-conf.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57437&action=edit Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57437|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57438&action=edit Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57438|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57439&action=edit Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57439|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 57490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57490&action=edit Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can we better put that info on a specific file? Maybe /etc/koha/sites/<instance>/plack.conf -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Larry Baerveldt <larry@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larry@bywatersolutions.com --- Comment #6 from Larry Baerveldt <larry@bywatersolutions.com> --- I'm curious, but why add a separate config file for what amounts to a couple of lines? Why not just put them on koha-conf.xml? We desperately need this patch. We're running dozens of sites on our clusters, and need to be able to set different numbers of plack workers for different sites. Plus there are the larger sites on stand-alone servers, that need more than 2 workers, but when we change them in koha-plack, it gets overwritten with every upgrade. This is, in my opinion, a very needed patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #5)
Can we better put that info on a specific file? Maybe /etc/koha/sites/<instance>/plack.conf
Is that the only reason for Failed QA? I agree with Larry that they could be in koha-conf, just like similar stuff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I think we could use this for now, and removed it later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #8)
I think we could use this for now, and removed it later.
Back to NSO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57490|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 59377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59377&action=edit Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Rebased against master and added a description for the new configuration entries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59377|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59680&action=edit Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: <plack_max_requests>75</plack_max_requests> <plack_workers>4</plack_workers> 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Rebased against master and added a description for the new configuration entries Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Pongtawat <pongtawat@punsarn.asia> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pongtawat@punsarn.asia --- Comment #14 from Pongtawat <pongtawat@punsarn.asia> --- I would love to see this backported to 16.11 as it would help many installations that still use 16.11 (such as ours). Although this feature is an enhancement, it doesn't conflict with any existing functionality. Also, I see that sometimes Koha get enhancement in its point release. For example, 16.11.08 has a new dev_install. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Pongtawat from comment #14)
I would love to see this backported to 16.11 as it would help many installations that still use 16.11 (such as ours). Although this feature is an enhancement, it doesn't conflict with any existing functionality.
Also, I see that sometimes Koha get enhancement in its point release. For example, 16.11.08 has a new dev_install.
You should PM Katrin, or contact her on IRC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just checked, this patch doesn't apply on 16.11.x and I am not confident in fixing the conflicts myself. I am not against backporting this, but need a patch for 16.11.x that is well tested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #17 from Pongtawat <pongtawat@punsarn.asia> --- Created attachment 64699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64699&action=edit 16.11 - Allow the number of plack workers and max connections to be set in koha-conf.xml Backport to 16.11.x using current code in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #18 from Pongtawat <pongtawat@punsarn.asia> --- Here is my take to backport this patch to 16.11. The code is a bit different than in the previous patch, as it was based on the code currently in 17.05.x branch. I think it need sign-off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED Summary|Allow the number of plack |[16.11.x] Allow the number |workers and max connections |of plack workers and max |to be set in koha-conf.xml |connections to be set in | |koha-conf.xml --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Pongtawat. A sign-off would be great, I am changing the title and status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59680|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- No string changes, so this could still go into 16.11.10 if signed off on time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still willing to push this - can we get a sign-off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64699|0 |1 is obsolete| | --- Comment #22 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 68814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68814&action=edit Bug 17610 - (16.11.x) Allow the number of plack workers and max connections to be set in koha-conf.xml Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #23 from Pongtawat <pongtawat@punsarn.asia> --- Thank you for signing off. Now I see hope that this might get pushed into the next 16.11 update :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving this one out of the SO queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #26 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.19 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org