[Bug 7517] New: Patron category types not appearing as an <optgroup> when editing or creating a patron.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Bug #: 7517 Summary: Patron category types not appearing as an <optgroup> when editing or creating a patron. Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: gcollum@gmail.com QAContact: koha.sekjal@gmail.com At one time the drop-down for borrower categories in the new patron would appear as an <optgroup>. For example, you would have 'Child' and then your child category types, 'Adult' and then adult types, etc. These are no longer displaying. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Garry Collum <gcollum@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|oleonard@myacpl.org |gcollum@gmail.com --- Comment #1 from Garry Collum <gcollum@gmail.com> 2012-02-09 21:34:47 UTC --- Created attachment 7544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7544 Proposed patch To test. Before applying the patch, see if the groups appear in the category list when editing a patron. Check again after application. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 --- Comment #2 from Garry Collum <gcollum@gmail.com> 2012-02-09 21:35:20 UTC --- Created attachment 7545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7545 Drop-down prior to patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 --- Comment #3 from Garry Collum <gcollum@gmail.com> 2012-02-09 21:36:11 UTC --- Created attachment 7546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7546 Drop-down after patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Garry Collum <gcollum@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7544|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> 2012-02-10 08:09:06 UTC --- Created attachment 7557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7557 Signed-off patch I confirm the WUI regression and the solution with this patch. Looking at the code, one can see this patch fixes also 2 typos. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> 2012-02-16 16:09:29 UTC --- Template only change, most XHTML clean up and TT scope shift. Marking a Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 10:45:29 UTC --- QA comment This patch also does 2 un-announced changes: -<input type="text" name="datedebarred" id="debarred" class="debarred" value="[% datedebarred %]" /> +<input type="text" name="datedebarred" id="datedebarred" class="debarred" value="[% datedebarred %]" /> and -<textarea id="debarredcomment" name="debarredcomment" cols="55" rows="3" ">[% debarredcomment %]</textarea> +<textarea id="debarredcomment" name="debarredcomment" cols="55" rows="3">[% debarredcomment %]</textarea> While the 2nd one fixes a HTML mistake (trailing single " at the end of <textarea> I don't understand what the 1st is made for, and I think it should not be here. and if it should, a few line below, we should also have -<input type="text" name="datedebarred" id="debarred" class="debarred" value="[% datedebarred %]" onclick="this.value=''" /> +<input type="text" name="datedebarred" id="datedebarred" class="debarred" value="[% datedebarred %]" onclick="this.value=''" /> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 --- Comment #7 from Garry Collum <gcollum@gmail.com> 2012-02-25 20:23:32 UTC --- Created attachment 7871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7871 Revised patch Revised patch adds more of a description of the fixes and fixes the missed XHTML error - debarredcomment id field. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Garry Collum <gcollum@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7557|0 |1 is obsolete| | Attachment #7871|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 7990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7990&action=edit Signed off revised patch The new patch still fix the initial problem and fix what has been pointed by Paul. Signed-off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Ian Walls <koha.sekjal@gmail.com> --- Template only change, easy to read, marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7517 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Patch complexity|--- |Small patch Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org