[Bug 41895] New: Introduce Koha::Context::UserEnv to reduce circ deps problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Bug ID: 41895 Summary: Introduce Koha::Context::UserEnv to reduce circ deps problem Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 41890 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41890 [Bug 41890] [OMNIBUS] Remove circular dependencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41897 [Bug 41897] Remove C4::Context from Koha::Objects::Limit::Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 193511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193511&action=edit Bug 41895: Introduce Koha::Context::UserEnv Introduce Koha::Context::UserEnv to reduce circ deps problem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 193516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193516&action=edit Bug 41895: Fix if no user defined Patch from commit 375fa71 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193516|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 193519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193519&action=edit Bug 41895: Fix if no userenv defined Patch from commit 241b789 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I certainly like things moving into their own separate modules for sure. I'm curious about this line though in the middleware: local $Koha::Context::UserEnv::REQUEST_ENV = $env; What's the purpose of that? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #4)
I certainly like things moving into their own separate modules for sure.
I'm curious about this line though in the middleware:
local $Koha::Context::UserEnv::REQUEST_ENV = $env;
What's the purpose of that?
It's a leftover from a previous implementation, should be removed. Good catch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41890 Depends on|41890 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41890 [Bug 41890] [OMNIBUS] Remove circular dependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41890 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41890 [Bug 41890] [OMNIBUS] Remove circular dependencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41972 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41972 [Bug 41972] Move C4::Context->interface to Koha::Context::Interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 [Bug 41891] Move C4::Context->preferences to a separate package -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|41891 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41891 [Bug 41891] Move C4::Context->preferences to a separate package -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193511|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196465&action=edit Bug 41895: Introduce Koha::Context::UserEnv Introduce Koha::Context::UserEnv to reduce circ deps problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196466&action=edit Bug 41895: Fix if no userenv defined Patch from commit ee955a9 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41895 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199370&action=edit Bug 41895: Use memory cache instead of package variable Patch from commit 0c76c13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org