[Bug 26129] New: Add a new 'configurations' table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Bug ID: 26129 Summary: Add a new 'configurations' table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org This table should be designed from the beginning to allow global and per-library configuration entries. It would replicate the circulation_rules schema, but adapted to be a(n eventual) replacement for system preferences. This came up on my development for an SMTP configuration page, in which I originally added an smtp_servers page, that could really be generalized like this for other uses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107718&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107719&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 107720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107720&action=edit Bug 26129: DBIx::Class schema updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io, | |kyle@bywatersolutions.com, | |liz@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I'd like to see a more real-world example for Configurations.t. At the moment, you're storing a hostname as the value, but on Bug 22343 there is actually quite a few different values (e.g. hostname, port, ssl, etc) that need to be stored. How would this be stored here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've been playing with rewriting Koha::SMTP::Server(s) in terms of this, so we require and set configurations without fetching each value where need. But I found a rock on the road when it comes to using this on the API, so still thinking about this. I like the idea, but I'm not sure how to group things: separate class wrapping the grouped values, or maybe a separate table for grouping things. Either of them makes it hard to use with objects->search of we want to allow filtering by column. Storing JSON has the same limitation with current MariaDB/MySql versions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just reading diagonally, sounds like yet another configuration to manage? Moving all preferences into it would be a dramatic refactoring that we probably do not finish? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The idea is that we have many places in which we define global configurations (sysprefs) and then override it somewhere, locally (e.g. min password length on category config). In that case, if we wanted to have a screen for managing this with a tree like structure, maybe handling all password-related configs globally or per-library or per-category, a-la circulation rules, we would benefit from this simple design and it would set a clear path forward. On bug 19889 we clearly added many configurations, in different places, and while it has the flexibility that is required, and we can give pointers to the end-user, it is clear that having a single page to manage all related things, was pointed out by the requestor as something valuable. And this generic approach on the DB might be the best way to store this. Even if we don't migrate all sysprefs into this. That said, I moved forward with an smtp_servers table and won't be back to this unless there's some interest. It felt like the right thing to do, though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19889 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #7)
It felt like the right thing to do, though.
I like the idea in theory but I'm not 100% sure how I feel about this implementation. That being said, I can't point to anything technical I don't like about it except for the large number of nulls. And the large number of nulls do make sense for a simple design. I don't think I've done much work that requires anything more granular than global-config, so I don't think that I'm best placed to comment on this meaningfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Cook from comment #8)
(In reply to Tomás Cohen Arazi from comment #7)
It felt like the right thing to do, though.
I like the idea in theory but I'm not 100% sure how I feel about this implementation.
That being said, I can't point to anything technical I don't like about it except for the large number of nulls. And the large number of nulls do make sense for a simple design.
I don't think I've done much work that requires anything more granular than global-config, so I don't think that I'm best placed to comment on this meaningfully.
This is really for multi branch sites that need more granularity. Minor things like the default MARC organization code are defined globally and then overridden with a new column in 'branches'. This pattern can be problematic in my opinion, handling it on a per-case basis. And adding columns everywhere we want to make a syspref overridden per-branch looks worse than NULL values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #9)
This is really for multi branch sites that need more granularity. Minor things like the default MARC organization code are defined globally and then overridden with a new column in 'branches'. This pattern can be problematic in my opinion, handling it on a per-case basis.
And adding columns everywhere we want to make a syspref overridden per-branch looks worse than NULL values.
Those are good points. I've wondered a bit about branch_configurations, item_configurations, and patron_configurations, but then there are times when you need combinations of all 3, so having just one configurations table as you've done does make sense. Something about the configurations table *feels* wrong though. That said, maybe it's just my mind trying to prematurely optimize. I suppose even if you had 1000 library branches, so long as you indexed by branch, patron category, and item type... you could do a lookup pretty easily. So scale shouldn't be an issue. And having 1 big table versus smaller tables or configuration files makes it easier to add new configuration options (although possibly with a downtime cost at upgrade time for adding columns to all existing rows if you have a large configurations table but I doubt the configurations table would ever grow that large, and if it did then we could split it out more at that point). I suppose I can't think of any good reason not to do a "configurations" table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27945 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, I'm resurrecting this one. I saw bug 27945, which proposes to add a new attribute to categories, and it will end-up being the same old pattern: - A syspref for a global/default value - A per-category value I will suggest adding a special page for handling article requests configurations (because there will be more, probably) and have a way to set this rate limit the circ-rules way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #12 from David Nind <david@davidnind.com> --- Patches no longer apply 8-(.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107718|0 |1 is obsolete| | Attachment #107719|0 |1 is obsolete| | Attachment #107720|0 |1 is obsolete| | --- Comment #13 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 118970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118970&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #14 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 118971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118971&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #15 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 118972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118972&action=edit Bug 26129: DBIx::Class schema updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #16 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to David Nind from comment #12)
Patches no longer apply 8-(..
Hi David, just rebased patches.. could you try again? Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118970|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 118982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118982&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118971|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 118983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118983&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118972|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 118984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118984&action=edit Bug 26129: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is there a new example bug where this is getting used? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Small QA failures: OK Koha/Schema/Result/Itemtype.pm FAIL installer/data/mysql/kohastructure.sql FAIL boolean_vs_tinyint The new column (type) for table configurations is using BOOLEAN as type, must be TINYINT(1) instead, see the SQL12 coding guideline FAIL t/db_dependent/Koha/Configurations.t FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118984|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118982|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128892&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128893&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128894&action=edit Bug 26129: DBIx::Class schema updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Rebased. (In reply to Nick Clemens from comment #21)
Small QA failures: OK Koha/Schema/Result/Itemtype.pm FAIL installer/data/mysql/kohastructure.sql FAIL boolean_vs_tinyint The new column (type) for table configurations is using BOOLEAN as type, must be TINYINT(1) instead, see the SQL12 coding guideline
This is a false positive. The DB structure defines an ENUM, that can take the string 'boolean' as a possible value, and the QA checks don't notice it is an ENUM type.
FAIL t/db_dependent/Koha/Configurations.t FAIL file permissions File must have the exec flag
Fixed, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #20)
Is there a new example bug where this is getting used?
My plan was to do it for bug 22457. Because it felt like changing the model for each single configuration specific to a category sounds like bad design. And 'circulation_rules' doesn't sound like the use case. (In reply to Marcel de Rooy from comment #6)
Just reading diagonally, sounds like yet another configuration to manage? Moving all preferences into it would be a dramatic refactoring that we probably do not finish?
I agree. I will probably abandon this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nick Clemens from comment #21)
Small QA failures: OK Koha/Schema/Result/Itemtype.pm FAIL installer/data/mysql/kohastructure.sql FAIL boolean_vs_tinyint The new column (type) for table configurations is using BOOLEAN as type, must be TINYINT(1) instead, see the SQL12 coding guideline
https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/42 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128892|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128893|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128894|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128904&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128905&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128906&action=edit Bug 26129: DBIx::Class schema updates [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128904|0 |1 is obsolete| | --- Comment #31 from David Nind <david@davidnind.com> --- Created attachment 130189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130189&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128905|0 |1 is obsolete| | --- Comment #32 from David Nind <david@davidnind.com> --- Created attachment 130190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130190&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128906|0 |1 is obsolete| | --- Comment #33 from David Nind <david@davidnind.com> --- Created attachment 130191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130191&action=edit Bug 26129: DBIx::Class schema updates [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #26)
(In reply to Marcel de Rooy from comment #6)
Just reading diagonally, sounds like yet another configuration to manage? Moving all preferences into it would be a dramatic refactoring that we probably do not finish?
I agree. I will probably abandon this bug.
Hum... What's next here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #34)
(In reply to Tomás Cohen Arazi from comment #26)
(In reply to Marcel de Rooy from comment #6)
Just reading diagonally, sounds like yet another configuration to manage? Moving all preferences into it would be a dramatic refactoring that we probably do not finish?
I agree. I will probably abandon this bug.
Hum... What's next here?
I see this pattern will become useful, I thought we would assign SMTP servers to libraries in a circ rules-like fashion, but I couldn't have that dev depend on this one so it moved forward in another direction. But it is not a priority until devs find it useful. As of the question, to make it useful: - It should consider library groups from the beginning - We need some UI for dealing with this, that can be reused to make configuration pages for modules/tools relying on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Should we then move it out of the NQA queue and revive it when we will need it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |LATER -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Bug 29924 could be done with this... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|LATER |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Adding bug 18203 to the pile that would benefit from this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #39 from David Cook <dcook@prosentient.com.au> --- I just noted that koha-testing-docker has 883 system preferences in it. Besides global/per-library entries, I imagine it would be useful to group configuration in logical ways too? That said, "logical" is subjective, and perhaps some things blur boundaries. Koha is a big system... but surely there has to be a better way of managing its configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #40 from David Cook <dcook@prosentient.com.au> --- Would it be useful to add "module"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #41 from David Cook <dcook@prosentient.com.au> --- Another thing I was thinking about... How do we share these configurations/system preferences with the front-end? Koha/REST/V1/ERM.pm and Koha/REST/V1/Preservation.pm have "config" methods which share some system preference values. But not all configuration/preferences should be viewed by end users, and we have to be careful not to allow business logic decisions to be made by the front-end, since end users can change things there (although things like ES modules have stricter scopes which can make this harder). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #42 from David Cook <dcook@prosentient.com.au> --- Since we seem to be gradually shifting to API-driven Vue.js powered UIs, I think whatever design we choose should make it easy (yet secure) to share config as necessary. Do we break things into config for controllers vs views? Where config for views affect the presentation, but don't affect the actions taken by controllers? Anyway, food for thought. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #43 from David Cook <dcook@prosentient.com.au> --- One last thought... On bug 39798 we're talking about the ability to turn off whole modules (like we already do for ERM and Preservation), but I think someone has said that permissions already fills that need. And that has got me thinking... how many system preferences should actually be permissions? -- For instance, "ExportCircHistory". Should the option to export patron checkouts be a system preference or a permission? Should that be a system preference or should it be a module specific "configuration"? In koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt, we use Template::Toolkit to write a value into Javascript: var exports_enabled = [% Koha.Preference('ExportCircHistory') ? 1 : 0 | html %]; In theory, shouldn't there be a Javascript object with a method like "logged_in_user.can_export_circ_history()" or something? In koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc we use the system preference to toggle display of some HTML. I suppose that too could instead be "logged_in_user.can_export_circ_history()" although it would need to be a Perl object not a Javascript object. I suppose the more cross-platform way to do that would be to use a Perl hash and turn it into a JSON object. In any case, ExportCircHistory ends up just being a presentation syspref as it isn't enforced in tools/export.pl. That actually makes you wonder if "ExportCircHistory" is an accurate name at all, or if it should be something like "can_see_circ_history_export". -- I think we'd be wise to start thinking about things more in terms of "actions" and "permissions". Is Subject A allowed to do Action B on Object C with Condition D? With the SMTP servers, surely there'd be permissions to create, read/view, update, and delete. (Of course, there are actions beyond simple CRUD as well. Maybe you want to send a test email via a SMTP server for instance.) Anyway, yet more food for thought... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #44 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Bug 37054 looks like more grist to the mill of this. (In reply to Tomás Cohen Arazi (tcohen) from comment #11)
add a new attribute to categories, and it will end-up being the same old pattern:
- A syspref for a global/default value - A per-category value
So we have (among implemented or proposed features) per patron category: - like the above quote with Bug 27945 - Limit the number of active article requests per patron category - Bug 22457 - OpacHiddenItemsExceptions should be moved to a category attribute - Bug 29924 - Introduce password expiration to patron categories - Bug 18203 - Add per borrower category restrictions on placing ILL requests in OPAC Per library: - like for the earlier iteration of SMTP example - Bug 22343 - Add configuration options for SMTP servers - Bug 37054 - Allow for custom library colors in the staff interface And combination of these two or three (with item type) for things like - Bug 19889 - LocalHoldsPriority needs exclusions - various things in the circulation rules page That should be the known pile of example bugs relevant for here. +1 for storing new occurrences in the proposed configurations table. To avoid making wider other DB tables. To not set in stone that a config is dependent only on just library or patron category. If something needs more granularity, it will be easy to change on the storage side. To not multiply the associative tables for each config related to 2 or 3 of the usual core entities. To not mix presentation with business data. To make it easier when something linked to only to one of itype/cat/lib will need more granularity and thus to be linked to a pair. **Would a start that is not too big to chew be to implement the storage backend and use it for data associated with only one of the usual 3 core entities?** And have the UI still be in the page of the entity. So for what would have ended up an additional column of categories or libraries. It could be any of the proposed patches in the list above that could inaugurate using the configurations table. Without much dev overhead given the patches proposed here. For these cases the core entity config page might be the best place to have the UI anyway so it's only about the backend, separating the data and preparing the work for more complex cases. And making it easier for other simple cases. Like bug 37054 would have less trouble with already a good place to store the data. And then for something that needs a pair or triad of itype/cat/lib then a dedicated page/ui component is needed anyway. So that will be the moment to make the generic page/reusable component to manage these configs and facilitate implementing the subsequent cases of data associated with a pair/triad of the 3 usual core entities. But until then the data structure will be done and already providing benefits. And secondary data linked only to one of itype/cat/lib doesn't have anymore to require adding a column and having to mix with core business logic just because making the generic config page is too much work. Especially when these cases don't even benefit that much from it since it's only linked to one entity. Do Comment 5 has early implications for the storage backend or is not a worry for the 1st step? (and is not something that would tilt the scale against the whole concept) There is no need yet to settle on global configs also being there, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #45 from Lisette Scheer <lisette@bywatersolutions.com> --- Bug 30795 could also potentially benefit from this table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30795 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #46 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 196758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196758&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #47 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 196759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196759&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #48 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 196760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196760&action=edit Bug 26129: DBIC schema [DO NOT PUSH] Patch from commit 6cfce17 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #49 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 196761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196761&action=edit Bug 26129: Add an API route for handling configurations Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #50 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 196762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196762&action=edit Bug 26129: DBIC schema [DO NOT PUSH] Patch from commit d292375 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196758|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #51 from David Nind <david@davidnind.com> --- Created attachment 196884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196884&action=edit Bug 26129: Add new 'configurations' table This patch introduces a new table to kohastructure.sql and an atomic update script to add the table on update. It also includes the corresponding schema file. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #52 from David Nind <david@davidnind.com> --- Created attachment 196885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196885&action=edit Bug 26129: Add Koha::Configuration(s) classes This patch adds the Koha::Configuration(s) classes and tests. It is similar to the Koha::CirculationRules(s) classes, but with simpler use cases for now. There's no special handling for '*' as it is expected to be passed undef instead. It allows to set arbitrary configuration entries either globally or for specific library_id, category_id or item_type. Attribute names match the ones agreed for the API. To test: 1. Apply this patches 2. Run: $ updatedatabase => SUCCESS: The atomic update is applied correctly 3. Run: $ reset_all => SUCCESS: kohastructure.sql is loaded without issues 4. Run: $ kshell k$ prove t/db_dependent/Koha/Configurations.t => SUCCESS: Tests pass! 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #53 from David Nind <david@davidnind.com> --- Created attachment 196886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196886&action=edit Bug 26129: Add an API route for handling configurations Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 --- Comment #54 from David Nind <david@davidnind.com> --- Created attachment 196887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196887&action=edit Bug 26129: DBIC schema [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org