https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Depends on| |29697 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- We could have (but didn't) handled the returned 404 Not found from https://git.koha-community.org/Koha-community/Koha/src/commit/ccd4738e26ef3c... before bug 29697 accidentally turned that into dead code. Now svc/bib calls Koha::Biblios->find( $biblionumber ) which returns undef if the biblio doesn't exist, but rather than returning 404 if we can't find the biblio, we forge ahead, calling $biblio->metadata->record() on undef and getting a 500 thrown instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 166683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166683&action=edit Bug 24424: Advanced editor - interface hangs as "Loading" when given an invalid bib number The Advanced Editor hangs with "Loading, please wait" message when given an invalid bib number, e.g. /cgi-bin/koha/cataloguing/editor.pl#catalog/55555 This is because in the bug 16424, when changes had been made to koha-tmpl/intranet-tmpl/lib/koha/cateditor/koha-backend.js (Bug 16424: Add framework support to advanced MARC editor), the .fail callback method of the outer .get (in the KohaBackend.GetRecord function called from cateditor-ui.inc) had been (perhaps by mistake?) removed. So, in case of failure, the situation is not handled properly. The proposal is to restore the outer .fail. As a result, the openRecord( 'new/', editor, finishCb ); will be called (a standard way of resolving failed openRecord action (cf. the bottom of cateditor-ui.inc). Test plan: ========== 0. Be sure your browser does not cache JavaScript for this test. 1. Enable EnableAdvancedCatalogingEditor in the system preferences. 2. Try to open in the advanced editor an unexisting record, e.g. http://your_ktd:8081/cgi-bin/koha/cataloguing/editor.pl#catalog/55555 Koha should hang with a message "Loading, please wait". 3. Apply the patch, restart_all. 4. In a new browser window, repeat p. 2 (remember not to cache JS). 5. The editor should open with a new empty record. Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- It would be nice if we had a warning about not finding the bib, but I think opening instead of hanging is a great improvement. Trvial, passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- First step toward a warning is bug 36891. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 --- Comment #8 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to Katrin Fischer from comment #6)

(In reply to Phil Ringnalda from comment #5)

...

First step toward a warning is bug 36891.

Is that one enough or should we file another bug here for a proper user message?

I'll file one more, once I know I can land that one. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to Katrin Fischer from comment #9)

Can you explain what you mean? I am not sure about that phrase.

Sorry. Once bug 36891 reaches Passed QA and I know that it will be possible to have the advanced editor report a invalid bib number to the user, I'll file another bug to have the advanced editor make use of the 404 return created by bug 36891. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 --- Comment #13 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to Phil Ringnalda from comment #10)

Sorry. Once bug 36891 reaches Passed QA and I know that it will be possible to have the advanced editor report a invalid bib number to the user, I'll file another bug to have the advanced editor make use of the 404 return created by bug 36891.

Bug 37212 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 --- Comment #15 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to Wainui Witika-Park from comment #14)

Does this need to be backported to 23.05.x?

Yes, please. Back to 22.11 should be affected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,22.11.28 released in| | --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Applied to 22.11 for 22.11.28 -- You are receiving this mail because: You are watching all bug changes.