[Bug 19878] New: Move template JavaScript to the footer: UNIMARC editor plugins, part 7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Bug ID: 19878 Summary: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 17858 Most UNIMARC plugin templates already have JavaScript at the bottom of the template instead of the top, but they should still be modified to be consistent with other templates which have been updated as part of Bug 17858. This patch modifies the last of the UNIMARC editor plugins. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70229&action=edit Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19952 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952 [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Olivier <olivier.roure@enssib.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olivier.roure@enssib.fr --- Comment #2 from Olivier <olivier.roure@enssib.fr> --- There is a problem with 4XX fields On the pop-up window the link choose do nothing on click. The others fields are ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |victor.grousset@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70229|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72870&action=edit Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 --- Comment #4 from Olivier <olivier.roure@enssib.fr> --- Ok for 4XX Ok for 210c_bis, ok for 225a_bis but KO for 210c and 225a (drop down menu is empty) all others fields works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 abernaud <anne-claire.bernaudin@univ-rennes1.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-claire.bernaudin@univ- | |rennes1.fr --- Comment #5 from abernaud <anne-claire.bernaudin@univ-rennes1.fr> --- KO for 210c : search retrieves no result -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Olivier from comment #4)
but KO for 210c and 225a
I think this may be due to insufficient authorities data? Does it work any differently in master? Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- According to Olivier: It does the same on master. He will sign it off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Failed QA |Signed Off --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 --- Comment #9 from abernaud <anne-claire.bernaudin@univ-rennes1.fr> --- Not due to insufficient authorities data. The problem is the same on Master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72870|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72946&action=edit Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72946|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73254&action=edit Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part 7 This patch updates the last of the UNIMARC plugin templates so that JavaScript is included in the footer following the same pattern as other templates which have been modified to fix Bug 17858. To test you do not need a UNIMARC system. Apply the patch and for each plugin, configure a MARC subfield (e.g. 100$a) to use that plugin.
From the MARC edit page, trigger the plugin and confirm that changes made in the popup window are saved to the corresponding field in the editor.
- unimarc_field_210c.tt - unimarc_field_210c_bis.tt - unimarc_field_225a.tt - unimarc_field_225a_bis.tt - unimarc_field_4XX.tt - unimarc_field_700-4.tt - unimarc_leader.tt Signed-off-by: Anne-Claire Bernaudin <anne-claire.bernaudin@univ-rennes1.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19877 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19877 [Bug 19877] Move template JavaScript to the footer: UNIMARC editor plugins, part 6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Bug 19878 depends on bug 19877, which changed state. Bug 19877 Summary: Move template JavaScript to the footer: UNIMARC editor plugins, part 6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19877 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, enhancement, not backported for stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org