[Bug 8662] New: Remove unused famfamfam icons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Priority: P5 - low Change sponsored?: --- Bug ID: 8662 Assignee: oleonard@myacpl.org Summary: Remove unused famfamfam icons Severity: enhancement Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha We distribute 1,156 image files in the OPAC in the famfamfam collection, many many more than are used by Koha. I propose that we eliminate all but those which are in use. I've gotten one request for an exemption: http://search.myacpl.org/opac-tmpl/prog/famfamfam/silk/keyboard.png (referenced here: http://wiki.koha-community.org/wiki/How_to_add_an_OPAC_screen_keyboard) If others agree that this is a worthwhile change, are there other exemptions you'd like to see? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8624 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- NORMARC XSLT has been using some famfamfam icons from the big collection, but if the patch on bug 8793 gets pushed it will only use icons from koha-tmpl/opac-tmpl/lib/famfamfam/ and koha-tmpl/intranet-tmpl/prog/img/famfamfam/ (not from the silk/ dirs below these dirs). So no objections from the Norwegian jury! ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8793 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Bug 8662 depends on bug 8793, which changed state. Bug 8793 Summary: Fix materialTypeCode/typeOf008 icons for NORMARC XSLT http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13036&action=edit Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13036|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13940&action=edit Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com Patch complexity|--- |Trivial patch --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm seeing no ill effects from the patch. I'm one of those people who'd rather keep all the images around just in case, but I do realize that we will never use 90% of these. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- How to be sure that nobody use these files for a specific theme (for example)? Perhaps asking through a topic on koha and koha-devel would be good idea don't you think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we get one or two more opinions on this one? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Not many opinions were forthcoming: http://lists.katipo.co.nz/public/koha/2013-April/035944.html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should move this forward as there was no negative response to the idea. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Bug 8662 depends on bug 8624, which changed state. Bug 8624 Summary: famfamfam should be outside theme directory http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, could you resubmit a rebased patch please? Applying: Bug 8662 - Remove unused famfamfam icons Using index info to reconstruct a base tree... error: patch failed: koha-tmpl/opac-tmpl/lib/famfamfam/mini/readme.txt:1 error: koha-tmpl/opac-tmpl/lib/famfamfam/mini/readme.txt: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13940|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18530&action=edit [SIGNED-OFF] Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, I'm still getting the same error applying the last patch :-/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- I got another error using --ignore-whitespace: # git am -3 --ignore-whitespace /tmp/BZ8662.patch Applying: Bug 8662 - Remove unused famfamfam icons error: corrupt binary patch at line 7593: z^9B<YSk|5uEYsxu!9bPB+;6=<UKb0;G`E{jgY|m- Using index info to reconstruct a base tree... error: corrupt binary patch at line 7593: z^9B<YSk|5uEYsxu!9bPB+;6=<UKb0;G`E{jgY|m- error: removal patch leaves file contents error: koha-tmpl/opac-tmpl/lib/famfamfam/silk/calculator.png: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18530|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18548&action=edit [SIGNED-OFF] Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Sorry Owen but I always get the same error, tested on several instance :-/ Could someone else try to apply it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18548|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18917&action=edit Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #16 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org