https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76652&action=edit Bug 21033: Remove few warns in acqui/basket.pl Resolve (line numbers based on 16.11.x): Use of uninitialized value in hash element at acqui/basket.pl line 337. Use of uninitialized value in hash element at acqui/basket.pl line 338. Use of uninitialized value in hash element at acqui/basket.pl line 340. Use of uninitialized value in hash element at acqui/basket.pl line 342. Use of uninitialized value in hash element at acqui/basket.pl line 344. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 486. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 591. Test plan: Open a basket that contains no prices. Compare warnings before and after this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, I've tried testing this, but can't reproduce the errors. What exactly do you mean by: Open a basket that contains no prices. ? I've tried closing and reopening a basket with one order line where I left all entries empty, but that didn't do it. Closing an empty basket is not possible, so I am a little lost here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76652|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76778&action=edit Bug 21033: Remove few warns in acqui/basket.pl Resolve (line numbers based on 16.11.x): Use of uninitialized value in hash element at acqui/basket.pl line 337. Use of uninitialized value in hash element at acqui/basket.pl line 338. Use of uninitialized value in hash element at acqui/basket.pl line 340. Use of uninitialized value in hash element at acqui/basket.pl line 342. Use of uninitialized value in hash element at acqui/basket.pl line 344. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 486. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 591. Test plan: If you have older acq data, you may have records in aqorders with field tax_rate_on_ordering is NULL. These orders will trigger the above warns. If you do not have, you could simulate by setting this field to NULL. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76778|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77418&action=edit Bug 21033: Remove few warns in acqui/basket.pl Resolve (line numbers based on 16.11.x): Use of uninitialized value in hash element at acqui/basket.pl line 337. Use of uninitialized value in hash element at acqui/basket.pl line 338. Use of uninitialized value in hash element at acqui/basket.pl line 340. Use of uninitialized value in hash element at acqui/basket.pl line 342. Use of uninitialized value in hash element at acqui/basket.pl line 344. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 486. Argument "" isn't numeric in multiplication (*) at koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt line 591. Test plan: If you have older acq data, you may have records in aqorders with field tax_rate_on_ordering is NULL. These orders will trigger the above warns. If you do not have, you could simulate by setting this field to NULL. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21033 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.