[Bug 20399] New: Remove "did you mean" for the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Bug ID: 20399 Summary: Remove "did you mean" for the staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: gaetan.boisson@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We should remove the part about the staff interface until it actually is implemented. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Elaine Bradtke <eb@efdss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb@efdss.org --- Comment #1 from Elaine Bradtke <eb@efdss.org> --- Agreed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101208&action=edit Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101208|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 101336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101336&action=edit Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think there is a problem here with this minimalistic approach: - Go to the did you mean admin page - Make changes to sequence and check/uncheck something - Save - Check system preference / local use / INTRAdidyoumean, it will contain only ] - Access the did you mean page again - BOOM malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "]") at /usr/share/perl5/JSON.pm line 171 I had a follow-up ready to remove the note form the intro text as well - it appears unnecessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
I think there is a problem here with this minimalistic approach:
- Go to the did you mean admin page - Make changes to sequence and check/uncheck something - Save - Check system preference / local use / INTRAdidyoumean, it will contain only ] - Access the did you mean page again - BOOM
malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "]") at /usr/share/perl5/JSON.pm line 171
I had a follow-up ready to remove the note form the intro text as well - it appears unnecessary.
Do we remove INTRAdidyoumean syspref and related code ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin SOMERS from comment #5)
(In reply to Katrin Fischer from comment #4)
I think there is a problem here with this minimalistic approach:
- Go to the did you mean admin page - Make changes to sequence and check/uncheck something - Save - Check system preference / local use / INTRAdidyoumean, it will contain only ] - Access the did you mean page again - BOOM
malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "]") at /usr/share/perl5/JSON.pm line 171
I had a follow-up ready to remove the note form the intro text as well - it appears unnecessary.
Do we remove INTRAdidyoumean syspref and related code ?
I guess we could - it's not been implemented in years and I suppose you can still easily add it back if you intend to develop it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #6)
(In reply to Fridolin SOMERS from comment #5)
Do we remove INTRAdidyoumean syspref and related code ?
I guess we could - it's not been implemented in years and I suppose you can still easily add it back if you intend to develop it?
Indeed, by looking at code for OPAC I'd say -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101336|0 |1 is obsolete| | --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 101562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101562&action=edit Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block 4) Change some checkboxes 5) Save configuration 6) Check that configuration is saved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101562|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 101662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101662&action=edit Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block 4) Change some checkboxes 5) Save configuration 6) Check that configuration is saved Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Save works, syspref removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101662|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101768&action=edit Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block 4) Change some checkboxes 5) Save configuration 6) Check that configuration is saved Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Save works, syspref removed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101769&action=edit Bug 20399: (QA follow-up) Remove mention of INTRAdidyoumean from text and delete commented code Removes some last "remains" of INTRAdidyoumean. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #13 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |System Administration -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org