[Bug 22669] New: Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Bug ID: 22669 Summary: Cannot edit received item in acquisitions with acqcreateitem set to "when placing an order" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- To replicate: Make sure acqcreateitem is set to "when placing an order" Create a basket with some orders close the basket Go to your vendor and receive an order On the receive page, try to edit your item, the pop up page will open and then close, not allowing the item to be edited. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Acquisitions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |21206 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The log says: The method Koha::Item->collection is not covered by tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The explosion has highlighted an older problem. Since commit bb1e9c500c810402c64436c53bcc00ffb9a0b857 Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib the "Collection code" is not filled correctly (items.collection vs items.ccode). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Scratch the last 3 comments, they are for another bug report. It has been introduced by commit 1253975389975a8ff11a9bb2ef84582aeb6bd08b Bug 21091: Move add item template JavaScript to a separate file And the one to blame is JavaScript (remember, "0" is evaluated to true) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 88586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88586&action=edit Bug 22669: Fix item editing on receiving an order Since commit 1253975389975a8ff11a9bb2ef84582aeb6bd08b Bug 21091: Move add item template JavaScript to a separate file items cannot longer be edited when receiving an order. When moving the code to the JS file, the JS variable "opisadd" was always set to "true": var opisadd = '[% opisadd | html %]'; Even if the TT variable is 0, opisadd will be "0", which is evaluated to true in Javascript To clean the situation it is easier to remove this variable and use "op" instead. Test plan: - Make sure acqcreateitem is set to "when placing an order" - Create a basket with some orders - Close the basket - Go to your vendor and receive an order - On the receive page, try to edit your item => Without the patch, the pop up page will open and then close, not allowing the item to be edited. => With this patch applied you will see the item edit form. Save and confirm that the parent window is updated with the new value (actually it's refreshed) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21206 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22762 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comments 1 to 3 addressed on bug 22762. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Hi Jonathan, It all seems alright until we save the item - the window/tab doesn't close and the receive window doesn't seem to update. Have another look? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Liz, thanks for testing. The window closes correctly here, make sure you refreshed the cache. However the data are not updated, because of the "method not covered by tests" error, with the patch from bug 22762 it looks ok. Could you retest with both patches applied? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22762 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22762 [Bug 22762] Collection codes not displayed on receiving -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88586|0 |1 is obsolete| | --- Comment #10 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 88746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88746&action=edit Bug 22669: Fix item editing on receiving an order Since commit 1253975389975a8ff11a9bb2ef84582aeb6bd08b Bug 21091: Move add item template JavaScript to a separate file items cannot longer be edited when receiving an order. When moving the code to the JS file, the JS variable "opisadd" was always set to "true": var opisadd = '[% opisadd | html %]'; Even if the TT variable is 0, opisadd will be "0", which is evaluated to true in Javascript To clean the situation it is easier to remove this variable and use "op" instead. Test plan: - Make sure acqcreateitem is set to "when placing an order" - Create a basket with some orders - Close the basket - Go to your vendor and receive an order - On the receive page, try to edit your item => Without the patch, the pop up page will open and then close, not allowing the item to be edited. => With this patch applied you will see the item edit form. Save and confirm that the parent window is updated with the new value (actually it's refreshed) Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88746|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88756&action=edit Bug 22669: Fix item editing on receiving an order Since commit 1253975389975a8ff11a9bb2ef84582aeb6bd08b Bug 21091: Move add item template JavaScript to a separate file items cannot longer be edited when receiving an order. When moving the code to the JS file, the JS variable "opisadd" was always set to "true": var opisadd = '[% opisadd | html %]'; Even if the TT variable is 0, opisadd will be "0", which is evaluated to true in Javascript To clean the situation it is easier to remove this variable and use "op" instead. Test plan: - Make sure acqcreateitem is set to "when placing an order" - Create a basket with some orders - Close the basket - Go to your vendor and receive an order - On the receive page, try to edit your item => Without the patch, the pop up page will open and then close, not allowing the item to be edited. => With this patch applied you will see the item edit form. Save and confirm that the parent window is updated with the new value (actually it's refreshed) Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22669 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug not in 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org