[Bug 30037] New: Set Default Profile when staging MARC notices on import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Bug ID: 30037 Summary: Set Default Profile when staging MARC notices on import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: florian.bontemps@biblibre.com QA Contact: testopia@bugs.koha-community.org When staging MARC notices on import, the default profile will always be "Do not use profile", even if you have multiple profiles already set up. It would be more intuitive to have a way for the users to set up their own default profile so it shows up on page load. That way, it would also reduce the chances of accidently making a duplicate profile. On our side, we have a fix with a function that makes the profile input search and automatically pick any profile labeled 'default', but this isn't ideal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 --- Comment #1 from Florian <florian.bontemps@biblibre.com> --- Created attachment 131329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131329&action=edit Bug 30037: Select profile when staging notices This is a first draft for making the profile selection process easier. Currently, if you have multiple profiles set up when staging Notices on import, the defaut selection will always be "Do not use profile". With this patch, if at least one profile is already set up, the first one in the list (which should be the oldest) will be selected by default. To test: 1) You will need a Marc notice to stage. 2) If you don't have any, create multiple profiles for staging Marc recos for import (in the Tools section); two should be enough, they should have different settings. 3) See that "Do not use profile" is always preselected. 4) Apply patch. 5) Reload the page : Now, the first profile of your list should be preselected. 6) Confirm that manually picking a different profile still loads different settings 7) Sign off. Thanks-to: Didier Gautheron <didier.gautheron@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set Default Profile when |Set default profile when |staging MARC notices on |staging MARC records on |import |import --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just a note, I have seen notices used a lot by French devs when they mean 'records', so it might be a false friend in French maybe? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is this ready for testing/review yet? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Florian <florian.bontemps@biblibre.com> --- This is a first draft for making the profile selection process easier. Currently, if you have multiple profiles set up when staging Records on import, the defaut selection will always be "Do not use profile". With this patch, if at least one profile is already set up, the first one in the list (which should be the oldest) will be selected by default. To test: 1) You will need a Marc record to stage. 2) If you don't have any, create multiple profiles for staging Marc records for import (in the Tools section); two should be enough, they should have different settings. 3) See that "Do not use profile" is always preselected. 4) Apply patch. 5) Reload the page : Now, the first profile of your list should be preselected. 6) Confirm that manually picking a different profile still loads different settings 7) Sign off. Thanks-to: Didier Gautheron <didier.gautheron@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 --- Comment #5 from Florian <florian.bontemps@biblibre.com> --- (In reply to Katrin Fischer from comment #2)
Just a note, I have seen notices used a lot by French devs when they mean 'records', so it might be a false friend in French maybe?
You're absolutely right, thank you for the correction And also yes, this is ready for testing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis@dataly.gr Component|Notices |MARC Bibliographic record | |staging/import -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |florian.bontemps@biblibre.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131329|0 |1 is obsolete| | --- Comment #6 from Florian <florian.bontemps@biblibre.com> --- Created attachment 134280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134280&action=edit [PATCH] Bug 30037: Select profile when staging records This is a second draft for making the profile selection process easier. Currently, if you have multiple profiles set up when staging Records on import, the defaut selection will always be "Do not use profile". With this patch, if at least one profile is already set up, the first one in the list (in alphabetical order) will be selected by default. To test: 1) You will need a Marc record to stage. 2) If you don't have any, create multiple profiles for staging Marc records for import (in the Tools section); two should be enough, they should have different settings. 3) See that "Do not use profile" is always preselected. 4) Apply patch. 5) Reload the page : Now, the first profile of your list should be preselected. 6) Confirm that manually picking a different profile still loads different settings 7) Sign off. Now rebased. Thanks-to: Didier Gautheron <didier.gautheron@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I think this change goes against the way we generally do things. In fact, we've been patching similar fields elsewhere because it was too easy for the user to accept a possibly incorrect default. I think if we want to define a default profile we should have it be an additional setting in the profile. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #7)
I think this change goes against the way we generally do things. In fact, we've been patching similar fields elsewhere because it was too easy for the user to accept a possibly incorrect default.
I think if we want to define a default profile we should have it be an additional setting in the profile.
+1 I agree with Owen here, this was making me feel uneasy and I think the suggested solution would be a much better fit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 --- Comment #9 from Florian <florian.bontemps@biblibre.com> --- Oh I fully agree, my proposition was just a first step toward making this form more user-friendly. Owen, do you have exemples of these similar fields? Just to check the proper format we've been aiming for. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi Florian, I'm not sure exactly which one Owen was referring to, but there is something similar that is done for Z39.50 servers. You can check a box when adding/editing a server in Administration to say that you want it selected by default. Of course, in the case of import profiles, you can only have one selected by default. So there would have to be some sort of warning if you try to make two default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30037 Noémie Labine <noemie.labine@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine@collecto.ca --- Comment #11 from Noémie Labine <noemie.labine@collecto.ca> --- +1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org