[Bug 13371] New: Add filters to the supplier list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Bug ID: 13371 Summary: Add filters to the supplier list view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org The supplier list view does not permit to filter on opened/closed baskets, creator name, basketgroup name or dates. That can be added easily using the DataTables filters. This new enhancement will allow a librarian to filter the supplier/basket list view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |13369, 13370 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34057&action=edit Bug 13371: Add filters on the supplier list view This patch adds the ability to filter the basket list depending on its creator name, basketgroup name, dates (creation, close), etc. Test plan: Go on the supplier list view (acqui/booksellers.pl) and confirm that the view is more ergonomic and the filters permit to the librarians to find a basket more easily than before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34058&action=edit Bug 13371: Reintroduce the action buttons Confirm the the "New basket" and "Receive shipment" buttons work as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note that this enhancement can be tested without patches from bug 13369 and bug 13370. They are only 2 small ergonomic improvements. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34059&action=edit Bug 13371: Add a filter for opened baskets This patch adds a new link to filter on opened baskets only. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- About the baskets filters: If I click on "Show active baskets only" then on "Show opened baskets only" I end up with two "Show all baskets" links one after the other. This is confusing. Imho, it should work this way: Show active baskets only -> click -> Show active and inactive baskets Show opened baskets only -> click -> Show opened and closed baskets This way the user knows exactly what is filtered. About the datatable filters: 'Item count' and 'Biblio count' didn't work for me: "No matching records found" (some records should have matched my search). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34167&action=edit Bug 13371: change the filters wording -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Matthias Meusburger from comment #5)
About the baskets filters:
If I click on "Show active baskets only" then on "Show opened baskets only" I end up with two "Show all baskets" links one after the other.
This is confusing.
Imho, it should work this way:
Show active baskets only -> click -> Show active and inactive baskets Show opened baskets only -> click -> Show opened and closed baskets
It makes sense, thanks for the suggestion!
About the datatable filters:
'Item count' and 'Biblio count' didn't work for me: "No matching records found" (some records should have matched my search).
I don't encounter this issue. But I marked these fields as integer. It means that if a cell contains "2 (1 canceled)", it will only appear if you search for '2'. This is a feature but can be removed if considered as a bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34170&action=edit New screen/table for booksellers.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #9 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patches [13369,13370,13371] against 3.19.00.000 'Item count' and 'Biblio count' didn't yet work: "No matching records found" (even if some records matched my search). So I pass the patch to "Failed QA" status. NB1. A patron "Xa" of the library "Yb" had created the basket. In the "Created by" column of that basket I saw: XaYb (without spaces). I think that the value "Xa Yb" would be preferred; otherwise filtering "aY" would find that row (ERROR). NB2. On koha/acqui/acqui-home.pl I wrote nothing in vendor's field. Koha answered the default list of the vendor/baskets. It was: You searched on vendor , 10 results found Show active and inactive baskets | Show opened baskets only Showing 1 to 6 of 6 Was the result 10 or 6? It's not so clear at once that the 4 missing baskets are the inactive ones. [I myself went early in confusion while I was testing, see below NB4.] Remember that on master the default is the complete list of vendors: if a vendor has only one inactive basket, the vendor is not listed at all! So the deault filter chosen in this bug: Show active and inactive baskets | Show opened baskets only didn't correspond to the current default of master. NB3. Same search as NB2, on the empty-vendor list's answer. One vendor of mine was "inactive". But I saw it in the list of vendors. So an "inactive" basket is not the basket of an "inactive" vendor. So, I'm in doubt: what is an "inactive"/"active" basket? Some of the listed baskets had still expected items > 0: they're active, aren't they? But an open basket had 0 biblio, 0 items, 0 expected items: it was listed as active. Is it right? NB4. On ACQ home, I saw for the table of funds: Hide inactive budgets | Show inactive budgets Imho the use of the same kind of filters might perhaps be clearer: Show inactive baskets | Hide inactive baskets | Show closed baskets | Hide closed baskets NB5. In a closed basket, 1 item was ordered, 1 item was partial and 1 item was completely received. When I selected only the active baskets, the item count is 2. When both the active and inactive baskets were selected, the item count is 3. I'm in doubt: is it right? NB6. "Expected items" might be preferred to "Items expected". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #9)
I've applied the patches [13369,13370,13371] against 3.19.00.000
'Item count' and 'Biblio count' didn't yet work: "No matching records found" (even if some records matched my search).
Weird, I don't have this problem. What is the version of your browser? Could you make a screenshot/screencast?
NB1. A patron "Xa" of the library "Yb" had created the basket. In the "Created by" column of that basket I saw: XaYb (without spaces). I think that the value "Xa Yb" would be preferred; otherwise filtering "aY" would find that row (ERROR).
Hum, the "created by" column should only contain firstname + surname.
NB2. On koha/acqui/acqui-home.pl I wrote nothing in vendor's field. Koha answered the default list of the vendor/baskets. It was:
You searched on vendor , 10 results found Show active and inactive baskets | Show opened baskets only Showing 1 to 6 of 6
Was the result 10 or 6?
Actually it's 10 vendors and 6 baskets.
It's not so clear at once that the 4 missing baskets are the inactive ones. [I myself went early in confusion while I was testing, see below NB4.] Remember that on master the default is the complete list of vendors: if a vendor has only one inactive basket, the vendor is not listed at all! So the deault filter chosen in this bug: Show active and inactive baskets | Show opened baskets only didn't correspond to the current default of master.
Does my previous answer correct the confusion?
NB3. Same search as NB2, on the empty-vendor list's answer. One vendor of mine was "inactive". But I saw it in the list of vendors. So an "inactive" basket is not the basket of an "inactive" vendor. So, I'm in doubt: what is an "inactive"/"active" basket? Some of the listed baskets had still expected items > 0: they're active, aren't they? But an open basket had 0 biblio, 0 items, 0 expected items: it was listed as active. Is it right?
A basket is considered as inactive if it is closed and no item is expected (should not be different as before this patch set). Before this patch, a "Show all baskets" existed. I have just renamed it, but the behavior should be the same.
NB4. On ACQ home, I saw for the table of funds: Hide inactive budgets | Show inactive budgets
Imho the use of the same kind of filters might perhaps be clearer: Show inactive baskets | Hide inactive baskets | Show closed baskets | Hide closed baskets
I am not sure. IMO it is more confusing. But we could ask Owen what he thinks about it.
NB5. In a closed basket, 1 item was ordered, 1 item was partial and 1 item was completely received. When I selected only the active baskets, the item count is 2. When both the active and inactive baskets were selected, the item count is 3. I'm in doubt: is it right?
It looks like a bug and it's certainly in master too. Could you open a new bug report, describe the problem and assign it to me please?
NB6. "Expected items" might be preferred to "Items expected".
It does not come from this patch, it's the same string as before. It could be fix on the QA step if needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34275&action=edit Bug 13371: just a test for the biblio|item count filters -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #9)
I've applied the patches [13369,13370,13371] against 3.19.00.000
'Item count' and 'Biblio count' didn't yet work: "No matching records found" (even if some records matched my search).
Could you please test with the last patch I submitted? Since I don't reproduce the issue, it's not easy to fix it :-/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #13 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #10)
(In reply to Paola Rossi from comment #9) [...]
NB1. A patron "Xa" of the library "Yb" had created the basket. In the "Created by" column of that basket I saw: XaYb (without spaces). I think that the value "Xa Yb" would be preferred; otherwise filtering "aY" would find that row (ERROR).
Hum, the "created by" column should only contain firstname + surname.
NB1. was my fault! I beg your pardon, I'm sorry.
Before this patch, a "Show all baskets" existed. I have just renamed it, but the behavior should be the same.
I thought there was a difference on master and after fixing. I don't know if it's meaningful or not, so I try to describe this difference with plainness. Before this patch, on master, the function was a selection about vendors, not about baskets. All the vendors were shown. And then their baskets were shown if they were of the right kind. Before this patch, the "Show all baskets" didn't change [didn't increase] the listed vendors, but only increased the shown baskets. At first, some vendors could be listed with no basket at all. After this patch koha doesn't show a vendor when no basket of his is of the right kind. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #13)
Before this patch, on master, the function was a selection about vendors, not about baskets. All the vendors were shown. And then their baskets were shown if they were of the right kind. Before this patch, the "Show all baskets" didn't change [didn't increase] the listed vendors, but only increased the shown baskets. At first, some vendors could be listed with no basket at all.
After this patch koha doesn't show a vendor when no basket of his is of the right kind.
Yes, you are right to raise this difference, I should have done it! Actually I was thinking about changing the name of this script, especially because it's more a basket search than a bookseller search. Do you think we should display all suppliers even if they don't have a basket listed? I am not sure it will be easier to display them in the table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Do you think we should display all suppliers even if they don't have a basket listed? I am not sure it will be easier to display them in the table.
I think we need to list those without baskets, because otherwise I think you won't be able to start a new order for a newly added vendo While we always displayed the baskets, I am a bit worried that the display will get confusing for the 'create new order' step with it being a table. When you create a new order, the first thing you do is to look up your vendor in Koha - you are not interested in most of the displayed information then, apart from the 'new basket' link - so it is in fact a vendor search too. Maybe there should be a short and a long form of the result list? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34057|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34295&action=edit Bug 13371: Add filters on the supplier list view This patch adds the ability to filter the basket list depending on its creator name, basketgroup name, dates (creation, close), etc. Test plan: Go on the supplier list view (acqui/booksellers.pl) and confirm that the view is more ergonomic and the filters permit to the librarians to find a basket more easily than before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34058|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34296&action=edit Bug 13371: Reintroduce the action buttons Confirm the the "New basket" and "Receive shipment" buttons work as before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34059|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34297&action=edit Bug 13371: Add a filter for opened baskets This patch adds a new link to filter on opened baskets only. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34167|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34298&action=edit Bug 13371: change the filters wording -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34275|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34299&action=edit Bug 13371: just a test for the biblio|item count filters -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34306&action=edit Bug 13371: List suppliers even if they don't have basket. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #21)
Created attachment 34306 [details] [review] Bug 13371: List suppliers even if they don't have basket.
This patch proposes a solution for suppliers without basket. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #23 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #10)
(In reply to Paola Rossi from comment #9) [...]
Thanks, Jonathan. NB1), NB2) and NB3) of comment #9 and #10 are allright. NB4) and NB6) have already been taken in care and are being to study at present. About NB5) I'll make some tests on master asap, thanks again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #12)
'Item count' and 'Biblio count' didn't yet work: "No matching records found" (even if some records matched my search).
Could you please test with the last patch I submitted? Since I don't reproduce the issue, it's not easy to fix it :-/
I've applied the today's version of the patch against master 3.19.00.000 . The error still occurred, either with or without the 5-th patch "just a test..". It happened using: FF 34.0.5, IE 11, GCh Version 39.0.2171.95 m [The error occurred even yesterday [applying the previuos version of the patches] even applying the 5-th patch "just a test ..." , sorry for my delay.] Applying the patches is ok at my tests. The first 13771 patch required an auto-merging: Applying: Bug 13371: Add filters on the supplier list view Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/datatables.css I've made some tests but I unfortunately have not yet got anything helping imo. 2) About searching vendors: I searched vendors without baskets [using "Vendor search"]: If 1 vendor had no baskets in DB, koha answered nothing about results found, showing no vendor and "No data available in table"; but also showing "+New" [basket/contract/vendor] "Edit vendor" "Receive shipments" (all useful and about that vendor) on top of the table [it's partially right: it's wrong because the name is not seen]. If 2 vendor had no baskets in DB, koha answered with "2 results found", showing no vendor "No data available in table", and nothing else. I pass this patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Paola Rossi <paola.rossi@cineca.it> --- Sorry, my comment 24 didn't take in care the Jonathan's comment 22. I pass the patch back to "Needs Signoff" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #26 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patches [13369,13370,13371 6] against master 3.19.00.000 . Now vendors with no basket have been listed, as desired. At first, by default options [=Show active and inactive baskets | Show opened baskets only] : at a vendor without active basket 1 row has been attached: "No active basket" at a vendor without basket at all 1 row has been attached: "No active basket" by these options : Show active baskets only| Show opened baskets only : at a vendor without active basket 1 row has been attached: "No active basket" at a vendor without basket at all 1 row has been attached: "No basket" In "Showing 1 to X of X", X counted the rows [not only the real baskets, but even the "No basket" rows]. 1) 'Item count' and 'Biblio count' didn't yet work: "No matching records found" (even if some records matched my search). It happened using: FF 34.0.5, IE 11, GCh Version 39.0.2171.95 m [The installed version of : jquery.dataTables.columnFilter.js * Version: 1.5.0.] 2) > [...] the "created by" column should contain firstname + surname. So I've filtered by "firstname surname" values: ERROR: No matching records found Consequently, on certain names [i.e. surnames such as "de Roy", or firstnames such as "Maria Luisa"], filtering had the same error as above: ERROR. On the contrary, filtering by only a firstname, or filtering by only a surname, is OK. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34299|0 |1 is obsolete| | Attachment #34306|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34423&action=edit Bug 13371: List suppliers even if they don't have basket. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34424&action=edit Bug 13371: Fix filtering on numbers This patch fixes a weird bug on some instances. Since the sort is disabled on this table, we don't care on the type of the data. It should allow to filter on all columns of the table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34425&action=edit Bug 13371: Move firstname and surname closer On this way, they can be searched together ("my_firstname my_surname"). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #26)
1) 'Item count' and 'Biblio count' didn't yet work: "No matching records found" (even if some records matched my search). It happened using: FF 34.0.5, IE 11, GCh Version 39.0.2171.95 m
I finally reproduced the problem on a sandbox (so same browser and same code, only data have changed). Fix submitted (Bug 13371: Fix filtering on numbers).
2) > [...] the "created by" column should contain firstname + surname. So I've filtered by "firstname surname" values: ERROR: No matching records found
Fixed too (Bug 13371: Move firstname and surname closer). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34295|0 |1 is obsolete| | --- Comment #31 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34433&action=edit Bug 13371: Add filters on the supplier list view Today I've applied the patches [13369,13370,13371 7] against master 3.19.00.000 Thanks, Jonathan: everything is ok! So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34296|0 |1 is obsolete| | --- Comment #32 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34434&action=edit Bug 13371: Reintroduce the action buttons -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34297|0 |1 is obsolete| | --- Comment #33 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34435&action=edit Bug 13371: Add a filter for opened baskets -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34298|0 |1 is obsolete| | --- Comment #34 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34436&action=edit Bug 13371: change the filters wording -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34423|0 |1 is obsolete| | --- Comment #35 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34437&action=edit Bug 13371: List suppliers even if they don't have basket. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34424|0 |1 is obsolete| | --- Comment #36 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34438&action=edit Bug 13371: Fix filtering on numbers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34425|0 |1 is obsolete| | --- Comment #37 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34439&action=edit Bug 13371: Move firstname and surname closer -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- I'm looking at this now for the first time, so my comments may come to late. But I think this isn't an improvement from a usability point of view. Combining each of the separate vendor tables into one makes the page much more difficult to scan. Are we trying to do too much on this page? Should we be focusing instead on adding filtering or advanced searching options to the order search page? I think it would be good to talk about what the expected workflow is here. I don't use acquisitions in production so I don't work with real data when I'm testing. I probably make incorrect assumptions about how people do things. The page seems to offer several end points: 1. Finding a vendor so you can view the details of that vendor 2. Showing a list of open baskets so that you can view one 3. Showing a list of open baskets so that you can add to one 4. Showing a list of basket groups so that you can view one If that's correct, then adding filtering should improve the ease of reaching one of those goals: 1. Finding a vendor -- I assume this isn't really a priority because we reach this page *from* a vendor search. 2. & 3. Finding a basket. Do we need to filter by basket information because we know the basket information but not the vendor? If we assume that we know the vendor and want to find a basket then we should keep the view which keeps each vendor in a separate table. If we assume that we're searching by basket information but *don't* know the vendor then we need to filter across all baskets. 4. Finding a basket group -- same questions as with 2. & 3. Can we assume that the vendor is known, or is it the case that sometimes only the basket group information is known? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could get some librarians to take a look here? My worry is that the new table will make the process of finding the vendor to start an order for slower, because it's harder to scan the table than to scan through individual entries in a list. Could we have a simple and an advanced view for this page? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #40 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #39)
Could we have a simple and an advanced view for this page?
How do you imagine the simple view? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #41 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36759&action=edit Bug 13371: Add a simple view This patch adds the ability to switch to a simple view if the complete view to too complex. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |m.de.rooy@rijksmuseum.nl --- Comment #42 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Switching this back to Needs Signoff, looking at the discussion in the last comments and the addition of the last patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11215 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr Status|Needs Signoff |Patch doesn't apply --- Comment #43 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Tried on a sandbox : Some problems occurred applying patches from bug 13371: <h1>Something went wrong !</h1>Applying: Bug 13371: Add filters on the supplier list view fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/css/datatables.css). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |claire.hernandez@biblibre.c |ommunity.org |om -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org