[Bug 6129] New: ISSN url param for serialssolutions.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Bug #: 6129 Summary: ISSN url param for serialssolutions.com Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: srdjan@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org To direct patrons to 360Link page, You either need to make a different URL for all their holdings pages, something like: http://zz8kv2kj8h.search.serialssolutions.com/?sid=&ISSN=<insert journal ISSN here>" We will detect serialssolutions url, and if ISSN url arg is missing, we will add it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|oleonard@myacpl.org |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-04-08 03:39:15 UTC --- Created attachment 3819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3819 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> 2011-09-01 07:00:47 UTC --- Created attachment 5245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5245 Bug 6129 - [master] this adds an ISSN to serialssolutions URLs If a URL is a serialssolutions URLs that doesn't already have an ISSN parameter, this adds one on the OPAC. Author: Srdjan Jankovic <srdjan@catalyst.net.nz> Author: Robin Sheat <robin@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> 2011-09-01 07:01:24 UTC --- Created attachment 5246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5246 Bug 6129 - [3.4.x] this adds an ISSN to serialssolutions URLs If a URL is a serialssolutions URLs that doesn't already have an ISSN parameter, this adds one on the OPAC. Author: Srdjan Jankovic <srdjan@catalyst.net.nz> Author: Robin Sheat <robin@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3819|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |robin@catalyst.net.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-09-02 19:35:14 UTC --- Comment on attachment 5246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5246 Bug 6129 - [3.4.x] this adds an ISSN to serialssolutions URLs This patch does not apply cleanly to 3.4.x. Please rebase and resubmit. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> 2011-09-05 00:21:36 UTC --- Created attachment 5304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5304 Bug 6129 - [3.4.x] this adds an ISSN to serialssolutions URLs If a URL is a serialssolutions URLs that doesn't already have an ISSN parameter, this adds one on the OPAC. Author: Srdjan Jankovic <srdjan@catalyst.net.nz> Author: Robin Sheat <robin@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5246|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> 2011-09-05 00:24:15 UTC --- This patch fixes the 3.4.x conflict. Thought I'd fixed that the first time, apparently not. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |Rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:16 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:51 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 --- Comment #9 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 18:02:22 UTC --- The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 --- Comment #10 from Robin Sheat <robin@catalyst.net.nz> 2011-10-26 21:50:15 UTC --- Chris N, Paul: this has been put into 3.4.5 and is lined up for 3.8 ... this means that it'll skip 3.6, is that a good thing to do? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Does not apply --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-21 06:13:06 UTC --- Patch for master does not apply: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6129 - [master] this adds an ISSN to serialssolutions URLs Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Biblio.pm Auto-merging catalogue/detail.pl CONFLICT (content): Merge conflict in catalogue/detail.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl Auto-merging opac/opac-detail.pl CONFLICT (content): Merge conflict in opac/opac-detail.pl Failed to merge in the changes. Patch failed at 0001 Bug 6129 - [master] this adds an ISSN to serialssolutions URLs When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". I am not sure if we should build in solutions for single vendors like this. Could there be a way to make this more flexible? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-21 17:13:23 UTC --- (In reply to comment #11)
Patch for master does not apply:
I am not sure if we should build in solutions for single vendors like this. Could there be a way to make this more flexible?
There could be, but that should definitely not stop this going in, this only adds the issn parameter to a serialsolutions url if one exists in the data already (and doesn't have the issn parameter set). Also it is in 3.4.x ... so not putting it in 3.6.x and master means we are conciously causing a regression. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-21 17:43:45 UTC --- That makes sense to me. I was wondering about it because I was trying to use a web service for serials last week that requires to have an url with the issn. We don't have the issn available in the SearchForTitleIn system preference and it's a bit hard to get it with jQuery. But this can all go on a separate enhancement request :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5245|0 |1 is obsolete| | Attachment #5304|0 |1 is obsolete| | --- Comment #14 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-12-22 01:37:19 UTC --- Created attachment 6916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6916 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |koha.sekjal@gmail.com --- Comment #15 from Ian Walls <koha.sekjal@gmail.com> 2012-02-03 13:06:12 UTC --- Hardcoding for one specific service (Serials Solutions) strikes me as a very hacky and unsustainable way of fixing this problem. This kind of processing should be put into a plugin file or some other kind of external means, rather than into C4/Biblio.pm directly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-10 19:37:53 UTC --- Wouldn't it be better to add ISSN for SearchForTitleIn? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-10 19:38:57 UTC --- Actually, never mind. This is because serialssolutions apparently provides records with URLs that are missing the ISSN, not for adding serialssolutions URLs to records that don't have that 856 yet. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Jared Camins-Esakov from comment #17)
Actually, never mind. This is because serialssolutions apparently provides records with URLs that are missing the ISSN, not for adding serialssolutions URLs to records that don't have that 856 yet.
Question for the audience ... is Serials Solutions still distributing records with (apparently) incomplete URLs? If so, I think a better implementation of the fixup nowadays would be as a TT plugin. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org