https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- All works great, few concerns: 1. Code in C4::Auth must be simplify and merged with existing one (you c/p 25 lines) 2. Only the AutoSelfCheckID should be able to connect to sci-main.pl, we should apply the same behaviour as self-checkout (no?) 3. Description (and name) of the permission self_checkout must be adapted 4. I do not know how SCOMainUserBlock is used, but it may be wrong to display it for SCI (?) 5. "Data corruption detected" => Are we sure we want to display that at the OPAC? 6. If error code is not known, we should display it instead of ignore it (BLOCK error_message) -- You are receiving this mail because: You are watching all bug changes.