[Bug 8826] New: Initialization of hash triggers error log entries.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Priority: P5 - low Change sponsored?: --- Bug ID: 8826 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Initialization of hash triggers error log entries. Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset@hotmail.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha Bug 7851 initialized a hash incorrectly. our %renew_failed = {}; This attempts to create a hash of a single anonymous hash reference which generates the error: circulation.pl: Reference found where even-sized list expected at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 97. As I do not know how my proposed change of: our %renew_failed = (); will work in a plack context, I would need someone to assist in testing that. I was thinking of reverting to no initialization, but based on my reading of bug 7851, that isn't an option. In the worst case scenario: our %renew_failed = ( "dummyplaceholderkey" => "dummyplaceholdervalue" ); should work. This only applies to 3.8.x and master, as 3.6.x still has an uninitialized value (which should not be problematic as far as I can tell). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 12543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12543&action=edit Changed {} to () in initialization of variable. This is the master version of the patch. 3.8.x needs a different patch. Test ----- 1) Login in to staff client 2) Click 'Circulation' (doesn't matter which one) 3) Click the 'Check Out' link below the Circulation title, and above the 'Check In' link. 4) Check the intranet error log. There should be an error like: [Thu Sep 27 14:51:06 2012] [error] [client 192.168.100.2] [Thu Sep 27 14:51:06 2012] circulation.pl: Reference found where even-sized list expected at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 97. 5) Apply patch 6) repeat steps 1-3, and recheck for an error. There shouldn't be one. FURTHER TEST ------------- Do this on a plakified setup. I have not tested this case, but it is likely important as bug 7851 changed this single line in the first place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 12544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12544&action=edit Changed {} to () in initialization of variable. (3.8.x) Changes between 3.8.x and master require a separate patch to apply cleanly. The test plan should be the same as master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12543|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12581&action=edit Bug 8826 - Initialization of hash triggers error log entries. Changed: our %renew_failed = {}; To: our %renew_failed = (); This prevents an error log about Reference found where even-sized list expected. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12581|Bug 8826 - Initialization |[SIGNED-OFF] Bug 8826 - description|of hash triggers error log |Initialization of hash |entries. |triggers error log entries. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12582&action=edit Bug 8826 - Initialization of hash triggers error log entries - Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Thanks for catching the follow up, Kyle. I was just about to add that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #5)
Thanks for catching the follow up, Kyle. I was just about to add that.
No problem! Can you give it a test and a sign-off? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12582|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13165&action=edit Bug 8826 - Initialization of hash triggers error log entries - Followup Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny (2 lines) patch, passes QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master QA Contact| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- 3.8.x patch pushed, will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |liz@catalyst.net.nz Resolution|--- |FIXED --- Comment #12 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Bug 8880 includes the changes here in 8826. So if 8880 has been been applied to 3.6.x then that explains why this can't be applied. I haven't looked further yet. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org