[Bug 39169] New: Acq column configurations are lacking (parent ticket 11578)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Bug ID: 39169 Summary: Acq column configurations are lacking (parent ticket 11578) Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: tgoatley@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 178369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178369&action=edit Budget screen shot with columns at issue HI Koha Dev's! The Acquisitions home page is displaying two columns that should be hidden by default (see screenshot) The first column is 'Active' and the second is 'Budget period description.' I don't think they were displayed previous to 24.11. Plus the the info is distracting, clutters up the display and is not useful. I checked the column settings to see if I could hide them but the 'Is hidden by default' setting is greyed out but not checked. The 'Cannot be toggled' setting is both greyed out and checked. (Submitted on behalf of Barbara at Bedford Public Library in Bedford Texas) Cheers! Todd -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acq column configurations |Acq column configurations |are lacking (parent ticket |are lacking |11578) | CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36640 CC| |oleonard@myacpl.org Summary|Acq column configurations |Acquisitions homepage no |are lacking |longer automatically hides | |"active" and "budget | |period" columns --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Prior to 24.11, the funds table on the acq homepage automatically hid its first two columns. The code to do so is still present, but is no longer working: https://github.com/Koha-Community/Koha/blob/cc0aa072dd5c1c0cb664ce6ffde43abe... Since these columns are meant to be hardcoded as hidden, they're disabled in Table Settings. That means that now they're showing and cannot be toggled to not-show. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 [Bug 36640] Upgrade DataTables from 1.13.6 to 2.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|24.11 |Main Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178411&action=edit Bug 39169: Automatically hide "active" and "budget period" columns on Acquisitions home page This patch adds column configuration to the table settings for the "Available funds" table on the Acquisitions home page. If a table has column configration, hidden columns should be hidden in the configuration rather than in the in-page table options. To test, apply the patch and restart all services. - Go to the Acquisitions home page - In the "All available funds" section, you should not see "active" and "budget period" columns. - NOTE: You may have to clear you browser's Local Storage in order for the change to show. - If you go to Administration -> Table settings -> Acquisition -> acq_acqui-home you should see that the first two columns are hidden by default and cannot be toggled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178411|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178412&action=edit Bug 39169: Automatically hide "active" and "budget period" columns on Acquisitions home page This patch adds column configuration to the table settings for the "Available funds" table on the Acquisitions home page. If a table has column configration, hidden columns should be hidden in the configuration rather than in the in-page table options. To test, apply the patch and restart all services. - Go to the Acquisitions home page - In the "All available funds" section, you should not see "active" and "budget period" columns. - NOTE: You may have to clear you browser's Local Storage in order for the change to show. - If you go to Administration -> Table settings -> Acquisition -> acq_acqui-home you should see that the first two columns are hidden by default and cannot be toggled. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178412|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178452&action=edit Bug 39169: Automatically hide "active" and "budget period" columns on Acquisitions home page This patch adds column configuration to the table settings for the "Available funds" table on the Acquisitions home page. If a table has column configration, hidden columns should be hidden in the configuration rather than in the in-page table options. To test, apply the patch and restart all services. - Go to the Acquisitions home page - In the "All available funds" section, you should not see "active" and "budget period" columns. - NOTE: You may have to clear you browser's Local Storage in order for the change to show. - If you go to Administration -> Table settings -> Acquisition -> acq_acqui-home you should see that the first two columns are hidden by default and cannot be toggled. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Bug 39169 depends on bug 36640, which changed state. Bug 36640 Summary: Upgrade DataTables from 1.13.6 to 2.x https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36640 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- This fixes the file, and works if the settings have never been saved, however, if the installation has settings in the DB then thye will need to update the settings to hide the columns, unfortunately, they may be marked as "cannot be toggled" and can't be corrected in the interface Should we have a DB update? UPDATE columns_settings SET is_hidden=1 WHERE module='acqui' AND page='acq_acqui-home' AND columnname IN ('active','budget_period_descriptions'); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39169 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org