[Bug 26805] New: Remove remaining instances of jquery.checkbox plugin from the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Bug ID: 26805 Summary: Remove remaining instances of jquery.checkbox plugin from the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 26006 Four remaining templates in the OPAC can be updated to enable the removal of the jquery.checkboxes plugin: opac-results.tt opac-search-history.tt opac-shelves.tt opac-suggestions.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove remaining instances |Remove remaining instances |of jquery.checkbox plugin |of jquery.checkboxes plugin |from the OPAC |from the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112297&action=edit Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112297|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112308&action=edit Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lisetteslatah@gmail.com --- Comment #3 from Lisette Scheer <lisetteslatah@gmail.com> --- The checkboxes and select all/unselect boxes all seem to work properly. On the catalog and list pages it doesn't seem to have any effect on the dropdown menu or link. On Purchase Suggestions the Select Suggestions to : Delete link never becomes clickable. Search History worked properly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112308|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112348&action=edit Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112348|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112349&action=edit Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- For me, all the Select all and Clear all actions work as expected. For the OPAC search everything works as expected, and am able to add to cart and lists and place holds. In the your account section: - All places with Select all and Clear all actions work as expected - Your purchase suggestions: . Select suggestions to: Delete? - doesn' work . Search box doesn't seem to work - Lists: . Styling for new list button: deosn't display correctly* . Remove from list in header doesn't seem to work (the button at the bottom of the page does); the place hold action does work - Search history: . Styling in header: doesn't display correctly* - Your summary: . Holds styling: suspend button in column doesn't display correctly* * I'm assuming these are separate bugs and that maybe some of the other items are separate bugs as well (where required). If so, I am happy to sign off. (Tested using Firefox developer edition 83.0b3 (64-bit) on Ubuntu 18.04.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> ---
- Your purchase suggestions: . Select suggestions to: Delete? - doesn' work
In what way? I'm able to check one or more boxes, click "Delete," and it triggers a modal confirmation. The confirmation works for me.
. Search box doesn't seem to work
I see this too, but it's not related to this patch.
- Lists: . Styling for new list button: deosn't display correctly*
This is fixed by Bug 26706
. Remove from list in header doesn't seem to work (the button at the bottom of the page does);
Confirmed.
- Search history: . Styling in header: doesn't display correctly* - Your summary: . Holds styling: suspend button in column doesn't display correctly*
Both should be fixed by Bug 26706 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26824 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26824 [Bug 26824] Use confirmation modal when removing titles from a list in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26830 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26830 [Bug 26830] Set focus for cursor to name input box when creating a new list in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #7)
- Your purchase suggestions: . Select suggestions to: Delete? - doesn' work
In what way? I'm able to check one or more boxes, click "Delete," and it triggers a modal confirmation. The confirmation works for me.
I retested, this is now working as expected!
. Remove from list in header doesn't seem to work (the button at the bottom of the page does);
Confirmed.
I retested, pop-up box says "No item selected" (with all items or just one item selected) . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112349|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112568&action=edit Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112568|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 112594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112594&action=edit Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112594|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112799&action=edit Bug 26805: Remove remaining instances of jquery.checkboxes plugin from the OPAC This patch removes the use of the jquery.checkboxes plugin from the 5 templates in the OPAC which still use it. The plugin itself is removed. To test, apply the patch and test the "Select all" and "Clear all" links work to select and deselect checkboxes on the following pages: - The catalog search results page: The controls should also enable and disable the "Select titles to..." menu. - The list contents page: The controls should also enable and disable the "Select titles to..." links. - The suggestions page: The controls should also enable and disable the "Select suggestions to..." link. - The search history page: The controls should affect only the corresponding table ("Current" or "Previous") and should enable and disable the "Select searches to..." link. This patch also modifies the template for grouped search results, as enabled by the OpacGroupResults system preference, but I don't know how to test it. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26805 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org