[Bug 29998] New: Replace the use of jQueryUI tabs on item types administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Bug ID: 29998 Summary: Replace the use of jQueryUI tabs on item types administration page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 29277 Blocks: 29226 As part of Bug 29226, "OMNIBUS: Replace the use of jQueryUI tabs," we should replace the use of the jQueryUI tabs component on the item types administration page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Bug 29998 depends on bug 29277, which changed state. Bug 29277 Summary: Replace the use of jQueryUI tabs on item circulation alerts page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 [Bug 29999] Replace the use of jQueryUI tabs on authorized values administration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131895&action=edit Bug 29998: Replace the use of jQueryUI tabs on item types administration page This patch updates the item type edit interface so that it uses Bootstrap tabs instead of jQueryUI tabs for displaying icon sets. Unrelated: The patch removes an invalid "type" attribute from a <select> element. - Go to Administration -> Item types in the staff interface. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g. https://via.placeholder.com/50/FF0000/FFFFFF.png ) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131895|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131981&action=edit Bug 29998: Replace the use of jQueryUI tabs on item types administration page This patch updates the item type edit interface so that it uses Bootstrap tabs instead of jQueryUI tabs for displaying icon sets. Unrelated: The patch removes an invalid "type" attribute from a <select> element. - Go to Administration -> Item types in the staff interface. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g. https://via.placeholder.com/50/FF0000/FFFFFF.png ) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tested and QAed with bug 29999. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Bug 29998 depends on bug 29999, which changed state. Bug 29999 Summary: Replace the use of jQueryUI tabs on authorized values administration page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29999 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29998 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org