[Bug 41330] New: Brace are not escaped in serials number management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Bug ID: 41330 Summary: Brace are not escaped in serials number management Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org Steps to reproduce: 1 - Create a new subscription, go to "Serial collection" -> Edit serials 2 - Update the number to {1} 3 - Save -> You get an error 500. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190202&action=edit Bug 41330: Unit tests Do not apply patches before 1 - Create a new subscription to a serial 2 - Go to 'Serial Collection' panel and click on edit serials button 3 - Try and edit the serial number to "{1}" -> error 500 4 - Apply only unit tests patch and run `prove t/Serials/ModSerialStatus.t` -> Tests will not pass 5 - Apply patch and proceed again to 2&3 -> you will get no error 6 - run `prove t/Serials/ModSerialStatus.t` -> tests will pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 190203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190203&action=edit Bug 41330: Escape braces in serials number management Do not apply patches before 1 - Create a new subscription to a serial 2 - Go to 'Serial Collection' panel and click on edit serials button 3 - Try and edit the serial number to "{1}" -> error 500 4 - Apply only unit tests patch and run `prove t/Serials/ModSerialStatus.t` -> Tests will not pass 5 - Apply patch and proceed again to 2&3 -> you will get no error 6 - run `prove t/Serials/ModSerialStatus.t` -> tests will pass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190202|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190212&action=edit Bug 41330: Unit tests Do not apply patches before 1 - Create a new subscription to a serial 2 - Go to 'Serial Collection' panel and click on edit serials button 3 - Try and edit the serial number to "{1}" -> error 500 4 - Apply only unit tests patch and run `prove t/Serials/ModSerialStatus.t` -> Tests will not pass 5 - Apply patch and proceed again to 2&3 -> you will get no error 6 - run `prove t/Serials/ModSerialStatus.t` -> tests will pass Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190203|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 190213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190213&action=edit Bug 41330: Escape braces in serials number management Do not apply patches before 1 - Create a new subscription to a serial 2 - Go to 'Serial Collection' panel and click on edit serials button 3 - Try and edit the serial number to "{1}" -> error 500 4 - Apply only unit tests patch and run `prove t/Serials/ModSerialStatus.t` -> Tests will not pass 5 - Apply patch and proceed again to 2&3 -> you will get no error 6 - run `prove t/Serials/ModSerialStatus.t` -> tests will pass Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190212|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190213|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 193585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193585&action=edit Bug 41330: Unit tests Do not apply patches before 1 - Create a new subscription to a serial 2 - Go to 'Serial Collection' panel and click on edit serials button 3 - Try and edit the serial number to "{1}" -> error 500 4 - Apply only unit tests patch and run `prove t/Serials/ModSerialStatus.t` -> Tests will not pass 5 - Apply patch and proceed again to 2&3 -> you will get no error 6 - run `prove t/Serials/ModSerialStatus.t` -> tests will pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 193586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193586&action=edit Bug 41330: Escape braces in serials number management Do not apply patches before 1 - Create a new subscription to a serial 2 - Go to 'Serial Collection' panel and click on edit serials button 3 - Try and edit the serial number to "{1}" -> error 500 4 - Apply only unit tests patch and run `prove t/Serials/ModSerialStatus.t` -> Tests will not pass 5 - Apply patch and proceed again to 2&3 -> you will get no error 6 - run `prove t/Serials/ModSerialStatus.t` -> tests will pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Brace in numbering patterns release notes| |in serials are not breaking | |anymore the reception of | |serials -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com Keywords|release-notes-needed | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41330 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Enhancement - not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org