https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39286 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179093&action=edit Bug 39286: Use mock_config instead of env vars Bug 35655 needed to mock the config, but instead introduced new env variables. Test plan: prove t/db_dependent/Koha/BackgroundJob.t should still return green Bonus 1: no more warning t/db_dependent/Koha/BackgroundJob.t .. 1/6 Cannot connect to broker Failed to connect: Error connecting to not_localhost:99999: Invalid argument at /usr/share/perl5/Net/Stomp.pm line 27.; giving up at /usr/share/perl5/Net/Stomp.pm line 27. Bonus 2: tests are passing even if you have 'message_broker' in the config To test this, add the following entry to $KOHA_CONf then prove again <message_broker> <hostname>localhost</hostname> <port>61613</port> <username>guest</username> <password>guest</password> <vhost></vhost> </message_broker> => Without this patch the tests fail because the config will overwrite the env vars. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39286 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179093|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 179148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179148&action=edit Bug 39286: Use mock_config instead of env vars Bug 35655 needed to mock the config, but instead introduced new env variables. Test plan: prove t/db_dependent/Koha/BackgroundJob.t should still return green Bonus 1: no more warning t/db_dependent/Koha/BackgroundJob.t .. 1/6 Cannot connect to broker Failed to connect: Error connecting to not_localhost:99999: Invalid argument at /usr/share/perl5/Net/Stomp.pm line 27.; giving up at /usr/share/perl5/Net/Stomp.pm line 27. Bonus 2: tests are passing even if you have 'message_broker' in the config To test this, add the following entry to $KOHA_CONf then prove again <message_broker> <hostname>localhost</hostname> <port>61613</port> <username>guest</username> <password>guest</password> <vhost></vhost> </message_broker> => Without this patch the tests fail because the config will overwrite the env vars. Signed-off-by: Magnus Enger <magnus@libriotech.no> Warning goes away and prove works even with the message_broker config. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39286 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39286 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179148|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 179161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179161&action=edit Bug 39286: Use mock_config instead of env vars Bug 35655 needed to mock the config, but instead introduced new env variables. Test plan: prove t/db_dependent/Koha/BackgroundJob.t should still return green Bonus 1: no more warning t/db_dependent/Koha/BackgroundJob.t .. 1/6 Cannot connect to broker Failed to connect: Error connecting to not_localhost:99999: Invalid argument at /usr/share/perl5/Net/Stomp.pm line 27.; giving up at /usr/share/perl5/Net/Stomp.pm line 27. Bonus 2: tests are passing even if you have 'message_broker' in the config To test this, add the following entry to $KOHA_CONf then prove again <message_broker> <hostname>localhost</hostname> <port>61613</port> <username>guest</username> <password>guest</password> <vhost></vhost> </message_broker> => Without this patch the tests fail because the config will overwrite the env vars. Signed-off-by: Magnus Enger <magnus@libriotech.no> Warning goes away and prove works even with the message_broker config. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39286 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39286 Bug 39286 depends on bug 35655, which changed state. Bug 35655 Summary: Make it possible to switch off RabbitMQ without any warns in logs/about page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35655 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39286 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |david@davidnind.com Status|Needs documenting |RESOLVED --- Comment #7 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.