[Bug 6855] New: bullet point showing in wrong place on error message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Bug #: 6855 Summary: bullet point showing in wrong place on error message Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All URL: cgi-bin/koha/reserve/request.pl?biblionumber=4091 OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 5345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5345 chrome error message See attached. When placing a hold in Chrome the bullet point shows to the far left bottom of the box instead of next to the text like it does in Firefox. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-09-08 00:04:53 UTC --- Created attachment 5346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5346 firefox error message bullet in right place -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-09-12 19:55:20 UTC --- Created attachment 5408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5408 Proposed fix Adding some more specific CSS to help Webkit browsers display the list bullets correctly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-09-20 05:36:07 UTC ---
Adding some more specific CSS to help Webkit browsers display the list bullets correctly.
Yes, but what will happen with a muli-lines error message? The text will be aligned to the bullet, no more indentation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-09-20 12:47:21 UTC --- Created attachment 5474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5474 Screenshot of multiline message (In reply to comment #3)
Yes, but what will happen with a muli-lines error message? The text will be aligned to the bullet, no more indentation.
This patch doesn't change the way error messages are displayed in general, it simply makes the display WebKit browsers match how it is displayed in Firefox. This attachment shows how it would look with a multi-line error message in Chrome, with the patch applied. It should match how it would look in Firefox with or without the patch applied. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-09-27 16:47:45 UTC --- Created attachment 5615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5615 still funny in chrome on mac after applying the patch it looks fine on firefox on mac, but not on chrome on mac. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Version|rel_3_6 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5408|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10060&action=edit Fix for Bug 6855 - List bullet showing in wrong place on error message Added some more specific CSS to help Webkit browsers display the lists bullets correctly. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Rebased 9 June 2012. Signing off as well, since the rebase and test were trivial. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10061&action=edit Error message on Chrome for Mac after patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny patch css only, passed QA Note that it seems that the patch also changes the dialog windows look without announcing the change: +div.dialog { + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< HERE + text-align : center; +} A small change, not worth complaining, just pointing that -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #8)
+div.dialog { + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< HERE + text-align : center; +}
This is a regression of Bug 6865 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #9)
(In reply to comment #8)
+div.dialog { + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< HERE + text-align : center; +}
This is a regression of Bug 6865
Owen, I'm not sure I get what you mean here = this div.dialog is a regression and should be discarded ? Should I revert the patch and ask for one that is dealing with .ialog li only ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #10)
+ background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<<
This is a regression of Bug 6865
Owen, I'm not sure I get what you mean here = this div.dialog is a regression and should be discarded ?
If the patch adds a call to "url(../../img/dialog-bg.gif)" in the CSS then it is a regression of Bug 6865 which removed all such calls to background gradient images. It's not a big deal, but it requires a follow-up to correct it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Waiting until the follow up is added, before I push this to 3.8.x -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #11)
If the patch adds a call to "url(../../img/dialog-bg.gif)" in the CSS then it is a regression of Bug 6865 which removed all such calls to background gradient images. It's not a big deal, but it requires a follow-up to correct it.
As you're the author of the patch, I suppose you plan to write the follow-up? Please confirm, (or I can revert this patch if you prefer) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8398 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed in conjunction with bug 8398 which undoes the regression this patch adds -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org