[Bug 38147] New: Edit button in bookings untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Bug ID: 38147 Summary: Edit button in bookings untranslatable Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com I can't find where to translate the "Edit" button in the bookings page. In Weblate, I tried looking through all the strings with the location "bookings", and I can't find it. https://translate.koha-community.org/search/koha/main/-/fr_CA/?q=+location%3Abookings+&sort_by=-priority%2Cposition&checksum= To get there: 1. In the staff interface, go to a biblio record 2. Click 'Items' in the left side menu 3. Choose Bookable: Yes and Update 4. Click 'Place booking' 5. Fill out the form and Submit 6. Click 'Bookings' in the left side menu --> Edit button in the table at the bottom 7. Install new language ./misc/translate/install fr-CA 8. Enable the new language in the StaffInterfaceLanguages system preference 9. Change the interface to the new language 10. View the bookings page --> Edit button is in English 11. Check the .po files for bookings locations --> No "Edit" string with "/bookings" location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172769&action=edit Bug 38147: Fix Edit and Cancel translatability in booking table No idea why they are not picked by the translator script, but this patch is fixing the problem. See comment 0 for a test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I can't figure out how to update the language files - I thought I had it worked out! This is what I did, but the "Edit" action is still "Edit": 1. Install a language: 1.1 koha-translate --install fr-CA --dev kohadev 1.2 restart_all 1.3 Enable the language: Administration > System preferences > I18N/L10N > StaffInterfaceLanguages > select the language you want to enable 1.4 Choose the language from the staff interface footer 2. Apply the patch. 3. Update the language with the string changes: 3.1 gulp po:update --lang fr-CA 3.2 koha-translate --update fr-CA --dev kohadev 3.3 restart_all I must be missing a step somewhere! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172769|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173013&action=edit Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38217 [Bug 38217] TT tags breaking translation script when used to build a JS string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 --- Comment #4 from David Nind <david@davidnind.com> --- After the patch, this is now working for the "Edit" action - it is now "Modifier". However, after the patch the "Cancel" action, which was previously "Annuler" is now "Cancel" when Français is set as the language. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173013|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176044&action=edit Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Sorry for the delay I totally lost track of this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #6)
Sorry for the delay I totally lost track of this one.
Very easy to do with the volume of bugzilla email! I'll leave testing until I can install a language again. I'm not sure whether it is just me, but if I try to install a language in KTD (I tried a couple of other languages as well), I get this error: koha-translate --install fr-CA --dev kohadev Can't use an undefined value as a HASH reference at /kohadevbox/koha/misc/ translator/tmpl_process3.pl line 134. You can change interface language, however, if you go to any record page in the staff interface: Template process failed: file error - parse error - cat-toolbar.inc line 132: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 134 This is on main with everything up to date (koha repository, koha-testing-docker repository, ktd pull). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176044|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 176057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176057&action=edit Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the 'Edit' and release notes| |'Cancel' actions for the | |bookings table for a record | |in the staff interface - | |these are now translatable. --- Comment #9 from David Nind <david@davidnind.com> --- Note: Jonathan and Katron fixed the issues with installing translations with a follow-up patch to bug 38684. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 --- Comment #10 from David Nind <david@davidnind.com> --- Katrin! (In reply to David Nind from comment #9)
Note: Jonathan and Katron fixed the issues with installing translations with a follow-up patch to bug 38684.
That should be Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176057|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176199&action=edit Bug 38147: Fix Edit and Cancel translatability in booking table It seems that "Edit" was not picked by the translator script because there was a TT tag on the same line. See comment 0 for a test plan. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for the fix here Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38147 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #16 from David Nind <david@davidnind.com> --- Translation related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org