[Bug 35335] New: Circulation history tab in patron information causes 500 error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Bug ID: 35335 Summary: Circulation history tab in patron information causes 500 error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: stalkernoid@gmail.com Reporter: stalkernoid@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To test: 1. Change syspref: RecordStaffUserOnCheckout to "record" 2. Choose a customer who has borrowed something before=has circulation history (e.g. customer 209 in koha-kktest https://koha-kktest.lib.helsinki.fi/cgi-bin/koha/mainpage.pl) and see that circulation history is can be seen. 3. Borrow something and see circulation history now -> got internal error (example customer id 232). 4. Change RecorsStaffUserOnCheckout to "don't record". 5. See the previous customer's circulation history now, should work as supposed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_23_11_candidate Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33948 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33948 [Bug 33948] Replace GetAllIssues with Koha::Checkouts - staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 159053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159053&action=edit Bug 35335: Fix 500 error on circulation history tab The 500 error was caused by this problem: Koha::Patron->issuer is not covered by tests! To reproduce: 1. Change syspref RecordStaffUserOnCheckout to "record" 2. Choose a customer who has borrowed something before (has circulation history) and go to that customers Circulation History tab to check if it can be seen. 3. Borrow something and go check that customer again, but this time you will see 500 error. 4. Apply the patch. 5. Check customer's Circulation History tab again, now it should work as intended. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Are you sure? IMO the correct fix is s/issuer.issuer_id/issuer.borrowernumber, next line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I have tested, and it removes the error: Template process failed: undef error - The method Koha::Patron->issuer_id is not covered by tests! However, I assume that RecordStaffUserOnCheckout is supposed to show the staff member who checked things out and show this in the 'Checked out by' column. This is empty for me for items checked out after the patch is applied. Testing notes (using koha-testing-docker): 1. Check out and check in a couple of items for a patron so that the patron has some entries in their circulation history tab, before starting the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159053|0 |1 is obsolete| | --- Comment #4 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 159138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159138&action=edit Bug 35335: Fix 500 error on circulation history tab The 500 error was caused by this problem: Koha::Patron->issuer is not covered by tests! To reproduce: 1. Change syspref RecordStaffUserOnCheckout to "record" 2. Choose a customer who has borrowed something before (has circulation history) and go to that customers Circulation History tab to check if it can be seen. 3. Borrow something and go check that customer again, but this time you will see 500 error. 4. Apply the patch. 5. Check customer's Circulation History tab again, now it should work as intended. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159138|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 --- Comment #5 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 159139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159139&action=edit Bug 35335: Fix 500 error on circulation history tab The 500 error was caused by this problem: Koha::Patron->issuer is not covered by tests! To reproduce: 1. Change syspref RecordStaffUserOnCheckout to "record" 2. Choose a customer who has borrowed something before (has circulation history) and go to that customers Circulation History tab to check if it can be seen. 3. Borrow something and go check that customer again, but this time you will see 500 error. 4. Apply the patch. 5. Check customer's Circulation History tab again, now it should work as intended. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159139|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159156&action=edit Bug 35335: Fix 500 on circulation history Koha::Patron->issuer is not covered by tests! Test plan: 1. Set RecordStaffUserOnCheckout to "record" 2. Check an item out and in to a patron 3. Go to their circulation history => Without the patch you get an error => With this patch applied the table displayed correct. The "checkout by" column contains the name and the link to the librarian -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Assignee|stalkernoid@gmail.com |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Peter, not sure why you don't want to apply the fix I am suggesting, it's working perfectly for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159156|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 159157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159157&action=edit Bug 35335: Fix 500 on circulation history Koha::Patron->issuer is not covered by tests! Test plan: 1. Set RecordStaffUserOnCheckout to "record" 2. Check an item out and in to a patron 3. Go to their circulation history => Without the patch you get an error => With this patch applied the table displayed correct. The "checkout by" column contains the name and the link to the librarian Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 --- Comment #9 from David Nind <david@davidnind.com> --- Thanks Jonathan! This fixed the error for me, and the 'Checked out by' column now shows who checked it out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159157|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159219&action=edit Bug 35335: Fix 500 on circulation history Koha::Patron->issuer is not covered by tests! Test plan: 1. Set RecordStaffUserOnCheckout to "record" 2. Check an item out and in to a patron 3. Go to their circulation history => Without the patch you get an error => With this patch applied the table displayed correct. The "checkout by" column contains the name and the link to the librarian Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
2. Check an item out and in to a patron
"and in" doesn't seem necessary. So we can circumvent Bug 35366, David had to do the same. Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35335 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org