http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Please use the function C4::Context->IsSuperLibrarian() instead. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27083|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 27098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27098&action=edit Bug 12048 - Doesn't display other libraries subscriptions when superlibrarian user This is a regression in master and 3.14. When a user has superlibrian permissions, a search on serials subscriptions must display other libraries subscriptions even when IndependentBranches syspref is enabled. To reproduce/test the bug/patch: 1. Enable IndependentBranches (i.e. 'Prevent' staff...) 2. Login as a user not having superlibrarian permission 3. Search for a serial subscription on: /cgi-bin/koha/serials/serials-search.pl 4. Search a title which has at least 2 subscriptions: one in the user branch, and one in another branch 5. On the result page, just 1 subscription is displayed: the one attached to the userbranch => this is normal 6. Login as a user having superlibrarian permission 7. Repeat step 3-5. 8. You get the same result as 5. You should have seen all subscriptions. That's what you get after applying this patch. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I tested a variation. My superlibrarian was a branch that was not the same as the non-superlibrarian. The serial was the same branch as the non-superlibrarian. Without the patch, the superlibrarian saw nothing, with the patch it saw the serial as expected. Also, remember the superserials permission can affect the results. I successfully changed the branch of the subscription, and then it ceased to show up with superserials not granted to the non-superlibrarian. I corrected the system preference name in the text here. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27098|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27105&action=edit [PASSED QA] Bug 12048 - Doesn't display other libraries subscriptions when superlibrarian user This is a regression in master and 3.14. When a user has superlibrian permissions, a search on serials subscriptions must display other libraries subscriptions even when IndependentBranches syspref is enabled. To reproduce/test the bug/patch: 1. Enable IndependentBranches (i.e. 'Prevent' staff...) 2. Login as a user not having superlibrarian permission 3. Search for a serial subscription on: /cgi-bin/koha/serials/serials-search.pl 4. Search a title which has at least 2 subscriptions: one in the user branch, and one in another branch 5. On the result page, just 1 subscription is displayed: the one attached to the userbranch => this is normal 6. Login as a user having superlibrarian permission 7. Repeat step 3-5. 8. You get the same result as 5. You should have seen all subscriptions. That's what you get after applying this patch. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I tested a variation. My superlibrarian was a branch that was not the same as the non-superlibrarian. The serial was the same branch as the non-superlibrarian. Without the patch, the superlibrarian saw nothing, with the patch it saw the serial as expected. Also, remember the superserials permission can affect the results. I successfully changed the branch of the subscription, and then it ceased to show up with superserials not granted to the non-superlibrarian. I corrected the system preference name in the text here. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Superlibrarian permission now allows to see all subscriptions independent from the branch. Passes all tests and QA script. But the superserials permission appears broken to me before and after this patch. If I have superserials - the search doesn't show all subscriptions. If I don't have superserials I can still edit any subscription accessing the subscription detail page through the serial collection page or accessing the detail page directly by manipulating the URL. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, I forgot to put a note here: bug 12080 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with regression tests I wrote. Thanks, Frédéric! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Fridolin SOMERS from comment #9)

After applying patch to 3.14.x, the unit test t/db_dependent/Bookseller.t fails :

git checkout -b checkout_12048 origin/3.14.x git grep -l IsSuperLibrarian There is part of your problem: IsSuperLibrarian is not defined in C4::Context, because bug 10277 in not in stable. Applying it first still doesn't help. :( -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- P.S. You need to fix Koha/Patron/List.pm (see the git grep -l IsSuperLibrarian in comment 10) in 3.14.x -- You are receiving this mail because: You are watching all bug changes.