[Bug 10191] New: 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Bug ID: 10191 Summary: 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: mathieu.saby@univ-rennes2.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 17946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17946&action=edit Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. To test : - in a UNIMARC Koha instance, edit a record - open the plugin for 115a subfield - check the "Form of release - visual projection, motion picture" option list is correct, especially the value "other film type" - ope the plugin for 116 field - check the "Technique (prints) 2" option list is correct, especially the value "lithography" M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17946|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18047&action=edit [SIGNED-OFF] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. To test : - in a UNIMARC Koha instance, edit a record - open the plugin for 115a subfield - check the "Form of release - visual projection, motion picture" option list is correct, especially the value "other film type" - ope the plugin for 116 field - check the "Technique (prints) 2" option list is correct, especially the value "lithography" Signed-off-by: Owen Leonard <oleonard@myacpl.org> I did not test this in Koha, but it's a simple change of one character which I'm comfortable with signing off on. I don't know if this counts as a string change or not, since the string was previously mixed with a malformed tag. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18047|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18087&action=edit [PASSED QA] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. To test : - in a UNIMARC Koha instance, edit a record - open the plugin for 115a subfield - check the "Form of release - visual projection, motion picture" option list is correct, especially the value "other film type" - open the plugin for 116 field - check the "Technique (prints) 2" option list is correct, especially the value "lithography" Signed-off-by: Owen Leonard <oleonard@myacpl.org> I did not test this in Koha, but it's a simple change of one character which I'm comfortable with signing off on. I don't know if this counts as a string change or not, since the string was previously mixed with a malformed tag. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and fixes an obvious problem in the HTML. I checked the po files - currently the strings appear as: "other film type/option> %s " So in theory it's possible to translate them correctly even if the standard templates now are not correct. Probably has to wait for 3.14. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |katrin.fischer@bsz-bw.de Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to 3.12.x. Will be in 3.12.1. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x. Will be in 3.10.7. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #7 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.14. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org