[Bug 33037] New: [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Bug ID: 33037 Summary: [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart+koha@gmail.com, katrin.fischer@bsz-bw.de, tomascohen@gmail.com Patch 32555 tries to resolve the issue caused by bug 31313. But the way it is fixed seems to be at least problematic. With patch 32555 we will never see the difference between `serial`.`serialseq` and `items`.`enumchron` which is still intended in opac-detail.tt (line ~ 1332) and [intranet] catalogue/detail.tt (line ~ 446). This is because ITEM_RESULT.serialitem (in opac-detail.tt) and item.itemserial.serial (in catalogue/detail.tt) refer to non-existing things. (and therefor the problem described in 32555 no longer emerge). The original problem is caused by mixing up serialitem with serial in [opac-]detail.pl and passing serialitem instead of serial to both templates. A patch will follow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | Status|NEW |Needs Signoff --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 147131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147131&action=edit [PATCH] Bug 33037: [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) Patch 32555 tries to resolve the issue caused by bug 31313. But the way it is fixed seems to be at least problematic. With patch 32555 we will never see the difference between `serial`.`serialseq` and `items`.`enumchron` which is still intended in opac-detail.tt (line ~ 1332) and [intranet] catalogue/detail.tt (line ~ 446). This is because ITEM_RESULT.serialitem (in opac-detail.tt) and item.itemserial.serial (in catalogue/detail.tt) refer to non-existing things. (and therefor the problem described in 32555 no longer emerge). The original problem is caused by mixing up serialitem with serial in [opac-]detail.pl and passing serialitem instead of serial to both templates. To test: 1. Create a serial subscription 1.1. Go to Serials 1.2. Click on New subscription 1.3. Fill out the first form - Vendor: leave empty - Record: enter a record number - Create an item record when receiving this serial - When there is an irregular issue: Keep issue number - Manual history: leave unchecked - Call number: leave empty - Library: Centerville - Public/nonpublic note: leave empty - Patron notification: None - Location: None - Collection: None - Item type: Continuing resources - Grace period: leave empty - Number of issues to display: leave both empty 1.4. Click Next (and confirm you are not using a vendor) 1.5. Fill out the second form - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 12 - Subscription start date: 2023-01-01 - Subscription end date: 2024-01-01 - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 1.6. Click Test prediction pattern 1.7. Click Save subscription 2. Click OPAC view: Open in new window. 3. Back in the staff interface tab, receive an issue 3.1. Click Receive 3.2. In Status, choose Arrived for No. 42 3.3. IN ITEM DETAILS BELOW CHANGE h - Serial enumeration / chronology from No. 42 to some different string 3.3. Click Save 4. Check the items in OPAC and Intranet – you will see only the value from the item $h subfield (enumchron) instead of desired "enumchron -- serialseq" in case of a difference between `serial`.`serialseq` and `items`.`enumchron`. 5. Apply this patch 6. Repeat 4 7. Check the items in OPAC and Intranet – you should now see the desired "enumchron -- serialseq" string. 8. Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149696&action=edit Bug 33037: Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) Patch 32555 tries to resolve the issue caused by bug 31313. But the way it is fixed seems to be at least problematic. With patch 32555 we will never see the difference between `serial`.`serialseq` and `items`.`enumchron` which is still intended in opac-detail.tt (line ~ 1332) and [intranet] catalogue/detail.tt (line ~ 446). This is because ITEM_RESULT.serialitem (in opac-detail.tt) and item.itemserial.serial (in catalogue/detail.tt) refer to non-existing things. (and therefor the problem described in 32555 no longer emerge). The original problem is caused by mixing up serialitem with serial in [opac-]detail.pl and passing serialitem instead of serial to both templates. To test: 1. Create a serial subscription 1.1. Go to Serials 1.2. Click on New subscription 1.3. Fill out the first form - Vendor: leave empty - Record: enter a record number - Create an item record when receiving this serial - When there is an irregular issue: Keep issue number - Manual history: leave unchecked - Call number: leave empty - Library: Centerville - Public/nonpublic note: leave empty - Patron notification: None - Location: None - Collection: None - Item type: Continuing resources - Grace period: leave empty - Number of issues to display: leave both empty 1.4. Click Next (and confirm you are not using a vendor) 1.5. Fill out the second form - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 12 - Subscription start date: 2023-01-01 - Subscription end date: 2024-01-01 - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 1.6. Click Test prediction pattern 1.7. Click Save subscription 2. Click OPAC view: Open in new window. 3. Back in the staff interface tab, receive an issue 3.1. Click Receive 3.2. In Status, choose Arrived for No. 42 3.3. IN ITEM DETAILS BELOW CHANGE h - Serial enumeration / chronology from No. 42 to some different string 3.3. Click Save 4. Check the items in OPAC and Intranet – you will see only the value from the item $h subfield (enumchron) instead of desired "enumchron -- serialseq" in case of a difference between `serial`.`serialseq` and `items`.`enumchron`. 5. Apply this patch 6. Repeat 4 7. Check the items in OPAC and Intranet – you should now see the desired "enumchron -- serialseq" string. 8. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Attachment #147131|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149696|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149697&action=edit Bug 33037: Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) Patch 32555 tries to resolve the issue caused by bug 31313. But the way it is fixed seems to be at least problematic. With patch 32555 we will never see the difference between `serial`.`serialseq` and `items`.`enumchron` which is still intended in opac-detail.tt (line ~ 1332) and [intranet] catalogue/detail.tt (line ~ 446). This is because ITEM_RESULT.serialitem (in opac-detail.tt) and item.itemserial.serial (in catalogue/detail.tt) refer to non-existing things. (and therefor the problem described in 32555 no longer emerge). The original problem is caused by mixing up serialitem with serial in [opac-]detail.pl and passing serialitem instead of serial to both templates. To test: 1. Create a serial subscription 1.1. Go to Serials 1.2. Click on New subscription 1.3. Fill out the first form - Vendor: leave empty - Record: enter a record number - Create an item record when receiving this serial - When there is an irregular issue: Keep issue number - Manual history: leave unchecked - Call number: leave empty - Library: Centerville - Public/nonpublic note: leave empty - Patron notification: None - Location: None - Collection: None - Item type: Continuing resources - Grace period: leave empty - Number of issues to display: leave both empty 1.4. Click Next (and confirm you are not using a vendor) 1.5. Fill out the second form - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 12 - Subscription start date: 2023-01-01 - Subscription end date: 2024-01-01 - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 1.6. Click Test prediction pattern 1.7. Click Save subscription 2. Click OPAC view: Open in new window. 3. Back in the staff interface tab, receive an issue 3.1. Click Receive 3.2. In Status, choose Arrived for No. 42 3.3. IN ITEM DETAILS BELOW CHANGE h - Serial enumeration / chronology from No. 42 to some different string 3.3. Click Save 4. Check the items in OPAC and Intranet – you will see only the value from the item $h subfield (enumchron) instead of desired "enumchron -- serialseq" in case of a difference between `serial`.`serialseq` and `items`.`enumchron`. 5. Apply this patch 6. Repeat 4 7. Check the items in OPAC and Intranet – you should now see the desired "enumchron -- serialseq" string. 8. Sign off Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- This works as described so I am signing off. I did amend the commit message to please the QA scripts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149697|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 149767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149767&action=edit Bug 33037: Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) Patch 32555 tries to resolve the issue caused by bug 31313. But the way it is fixed seems to be at least problematic. With patch 32555 we will never see the difference between `serial`.`serialseq` and `items`.`enumchron` which is still intended in opac-detail.tt (line ~ 1332) and [intranet] catalogue/detail.tt (line ~ 446). This is because ITEM_RESULT.serialitem (in opac-detail.tt) and item.itemserial.serial (in catalogue/detail.tt) refer to non-existing things. (and therefor the problem described in 32555 no longer emerge). The original problem is caused by mixing up serialitem with serial in [opac-]detail.pl and passing serialitem instead of serial to both templates. To test: 1. Create a serial subscription 1.1. Go to Serials 1.2. Click on New subscription 1.3. Fill out the first form - Vendor: leave empty - Record: enter a record number - Create an item record when receiving this serial - When there is an irregular issue: Keep issue number - Manual history: leave unchecked - Call number: leave empty - Library: Centerville - Public/nonpublic note: leave empty - Patron notification: None - Location: None - Collection: None - Item type: Continuing resources - Grace period: leave empty - Number of issues to display: leave both empty 1.4. Click Next (and confirm you are not using a vendor) 1.5. Fill out the second form - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 12 - Subscription start date: 2023-01-01 - Subscription end date: 2024-01-01 - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 1.6. Click Test prediction pattern 1.7. Click Save subscription 2. Click OPAC view: Open in new window. 3. Back in the staff interface tab, receive an issue 3.1. Click Receive 3.2. In Status, choose Arrived for No. 42 3.3. IN ITEM DETAILS BELOW CHANGE h - Serial enumeration / chronology from No. 42 to some different string 3.3. Click Save 4. Check the items in OPAC and Intranet – you will see only the value from the item $h subfield (enumchron) instead of desired "enumchron -- serialseq" in case of a difference between `serial`.`serialseq` and `items`.`enumchron`. 5. Apply this patch 6. Repeat 4 7. Check the items in OPAC and Intranet – you should now see the desired "enumchron -- serialseq" string. 8. Sign off Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31313 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32555 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #9 from David Cook <dcook@prosentient.com.au> --- This is an interesting one. I've had people thinking it's a bug since it's showing some duplicate information: For example: Vol. 47, No. 2 (Dec 2023) -- Vol. 47, No. 2 (01/12/2023) I could maybe understand wanting to do that on the staff interface but not the OPAC... it just looks bad on the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 --- Comment #10 from Janusz Kaczmarek <januszop@gmail.com> --- This feature has been there for quite a long time. I has disappeared only because of an obvious bug. Please, cf. bug 18388. I would not be against the idea of making it configurable by a syspref. If need you could file another bug since it seems to be a different issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org