[Bug 19678] New: Clicking Cancel when adding New Course shows message Invalid Course!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Bug ID: 19678 Summary: Clicking Cancel when adding New Course shows message Invalid Course! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: claire_gravely@hotmail.com QA Contact: testopia@bugs.koha-community.org Clicking on the cancel link when adding a new course to course reserves displays the message 'Invalid Course!'. It would be better if it redirected back to the main Course Reserves page. To reproduce: Go to Course Reserves Click '+ New Course' Cancel the process You are shown 'Invalid Course!' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clicking Cancel when adding |Clicking Cancel when adding |New Course shows message |New Course to course |Invalid Course! |reserves shows message | |Invalid Course! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |claire_gravely@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 --- Comment #1 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69277&action=edit Bug 19678: Clicking Cancel when adding New Course to course reserves shows message Invalid Course! Clicking on the cancel link when adding a new course to course reserves displays the message 'Invalid Course!'. It would be better if it redirected back to the main Course Reserves page. This patch redirects the user back to the main course reserves page. To Test: 1. Go to Course Reserves 2. Click '+ New Course' 3. Cancel the process 4. You are shown 'Invalid Course!' 5. Apply patch and repeat steps 1-3 6. You are redirected back to the main course reserves page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69277|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69278&action=edit Bug 19678: Clicking Cancel when adding New Course to course reserves shows message Invalid Course! Clicking on the cancel link when adding a new course to course reserves displays the message 'Invalid Course!'. It would be better if it redirected back to the main Course Reserves page. This patch redirects the user back to the main course reserves page. To Test: 1. Go to Course Reserves 2. Click '+ New Course' 3. Cancel the process 4. You are shown 'Invalid Course!' 5. Apply patch and repeat steps 1-3 6. You are redirected back to the main course reserves page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69278|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69280&action=edit Bug 19678: Clicking Cancel when adding New Course to course reserves shows message Invalid Course! Clicking on the cancel link when adding a new course to course reserves displays the message 'Invalid Course!'. It would be better if it redirected back to the main Course Reserves page. This patch redirects the user back to the main course reserves page. To Test: 1. Go to Course Reserves 2. Click '+ New Course' 3. Cancel the process 4. You are shown 'Invalid Course!' 5. Apply patch and repeat steps 1-3 6. You are redirected back to the main course reserves page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69280|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69281&action=edit Bug 19678: Clicking Cancel when adding New Course to course reserves shows message Invalid Course! Clicking on the cancel link when adding a new course to course reserves displays the message 'Invalid Course!'. It would be better if it redirected back to the main Course Reserves page. This patch redirects the user back to the main course reserves page. To Test: 1. Go to Course Reserves 2. Click '+ New Course' 3. Cancel the process 4. You are shown 'Invalid Course!' 5. Apply patch and repeat steps 1-3 6. You are redirected back to the main course reserves page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19229 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit f55af2fc078a7d6a05238232bc276e6924307179 Bug 19229: Return to course when cancelling out of edit form Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229 [Bug 19229] Clicking Cancel when editing course doesn't take you back to the course -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69281|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69916&action=edit Bug 19678: Clicking Cancel when adding New Course to course reserves shows message Invalid Course! Clicking on the cancel link when adding a new course to course reserves displays the message 'Invalid Course!'. It would be better if it redirected back to the main Course Reserves page. This patch redirects the user back to the main course reserves page. To Test: 1. Go to Course Reserves 2. Click '+ New Course' 3. Cancel the process 4. You are shown 'Invalid Course!' 5. Apply patch and repeat steps 1-3 6. You are redirected back to the main course reserves page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org