[Bug 5459] New: merging records loses holds from one
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Summary: merging records loses holds from one Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Tools AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 When you use the merge records tool, if both bibs have holds on them, when the merge is complete only the holds from the main record are kept and all others are lost. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #1 from Liz Rea <wizzyrea@gmail.com> 2011-02-21 20:56:01 UTC --- This bug makes the bib-merge feature unusable for us in all but the most limited cases. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-06-09 16:09:20 UTC --- Just a little nudge on this very critical issue - as Liz said, it makes the merge feature unusable. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Joe Atzberger <ohiocore@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ohiocore@gmail.com --- Comment #3 from Joe Atzberger <ohiocore@gmail.com> 2011-06-10 15:52:48 UTC --- Doing anything with reordering holds can introduce some complexity. As a baseline, we might expect to resort the combined holds by their original datestamps. Is that agreeable? But all kinds of policy/priority mess can be interjected as well, like taking into account the current locations of the items, the owning branches, etc. I want to ignore that. I also want to explicitly ignore any idea of sending notices to the patrons about their new hold priority. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-06-10 16:27:35 UTC --- While I am not in a library setting, this does sound agreeable to me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> 2011-06-11 02:54:48 UTC --- I believe that reordering by original date is a fine way to deal with it. Would it be possible to have some sort of display before the holds merge is completed "Here is how the holds queue is going to look after you click save: bib 1 date bib2 date Merged holds holda1 1/1 holdb1 1/2 holdA1 1/1 holda2 2/4 holdb2 1/15 holdB1 1/2 holda3 waiting holdb3 transit holdB2 1/15 holdA2 2/4\ holdB3 Transit holdA3 Waiting " Or somesuch? Or is that even necessary? My thinking is that it would let users say "oh gosh that won't work!" before it's completed and has to be manually undone. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #6 from Liz Rea <wizzyrea@gmail.com> 2011-06-11 02:55:20 UTC --- well that did not work at all. hrmph. I'll attach a screenshot. *mutter* -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #7 from Liz Rea <wizzyrea@gmail.com> 2011-06-11 02:56:54 UTC --- http://screencast.com/t/xhZbFKWF1 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-06-24 15:10:02 UTC --- Just an offer to help here - once the code is written to solve this problem I'll gladly add some text to the top explaining to those merging what will happen to holds. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-28 23:26:40 UTC --- So the spec for this, is, transfer all holds, and reorder on the date the holds were placed? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #10 from Liz Rea <wizzyrea@gmail.com> 2011-08-29 18:35:21 UTC --- Yep. When merging holds, they should be merged by date placed. All I'd ask is that the notes be preserved, so if you have a hold with a note saying "re-placed <some later date>" the librarian can then put it back in the queue where it belongs (like at the top, in the case of an accidental deletion). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-04 21:16:25 UTC --- Working on this now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-04 21:41:56 UTC --- As part of the work, I have discovered that yep the current procedure is just to delete the biblio, which due to the foreign key constraints, kills the holds on it too. So the holds will have to be shifted before the delete occurs. Working on a patch now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-04 23:04:13 UTC --- Created attachment 5302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5302 Bug 5459 - Holds not being shifted when merging biblios Holds are now shifted and reordered by date placed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #14 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 14:32:36 UTC --- Created attachment 5317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5317 2 waiting Alright this is almost ready. Before merging I had 2 items marked as waiting. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #15 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 14:33:09 UTC --- Created attachment 5318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5318 not waiting after merging the items are still waiting but the pull down has them listed as 1 and 2 and not waiting anymore. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA AssignedTo|gmcharlt@gmail.com |chris@bigballofwax.co.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5302|0 |1 is obsolete| | --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-19 22:57:06 UTC --- Created attachment 5467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5467 Bug 5459 - Holds not being shifted when merging biblios Holds are now shifted and reordered by date placed. Holds already marked waiting are not reordered. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5467|0 |1 is obsolete| | --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-19 23:05:46 UTC --- Created attachment 5468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5468 Bug 5459 - Holds not being shifted when merging biblios Holds are now shifted and reordered by date placed. Holds already marked waiting are not reordered. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5317|0 |1 is obsolete| | Attachment #5318|0 |1 is obsolete| | --- Comment #18 from Nicole C. Engard <nengard@gmail.com> 2011-09-27 16:39:07 UTC --- Created attachment 5611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5611 1st title holds before merge This is the list of holds on one title before the patch (note that 2 items are 'in transit') -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #19 from Nicole C. Engard <nengard@gmail.com> 2011-09-27 16:39:47 UTC --- Created attachment 5612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5612 2nd title holds before merge This is the second title before the merge. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #20 from Nicole C. Engard <nengard@gmail.com> 2011-09-27 16:40:35 UTC --- Created attachment 5613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5613 merged holds We're missing the hold from the second title on the merged bib and the 'in transit' status has gone away from the holds tab. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #21 from Nicole C. Engard <nengard@gmail.com> 2011-09-27 16:41:24 UTC --- Created attachment 5614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5614 merged holdings shows the two titles still in transit After the merge, the in transit status is still there in the holdings table, just missing from the holds tab. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #22 from Nicole C. Engard <nengard@gmail.com> 2011-09-27 16:41:53 UTC --- After applying this new patch the hold is not transferred from one title to the other - it's still lost. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5468|0 |1 is obsolete| | --- Comment #23 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-27 17:19:04 UTC --- Created attachment 5617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5617 Bug 5459 - Holds not being shifted when merging biblios Holds are now shifted and reordered by date placed. Holds already marked waiting, or in transit are not reordered. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5617|0 |1 is obsolete| | --- Comment #24 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-27 17:23:10 UTC --- Created attachment 5618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5618 Bug 5459 - Holds not being shifted when merging biblios Holds are now shifted and reordered by date placed. Holds already marked waiting, or in transit are not reordered. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-27 17:23:43 UTC --- My bad, in trying to avoid reordering items marked as waiting I caused them not to be merged at all. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5611|0 |1 is obsolete| | Attachment #5612|0 |1 is obsolete| | Attachment #5613|0 |1 is obsolete| | Attachment #5614|0 |1 is obsolete| | --- Comment #26 from Nicole C. Engard <nengard@gmail.com> 2011-09-28 15:16:09 UTC --- Created attachment 5629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5629 1 for priority We are so close!! Now it merges and keeps the transit status but shows 1 as the priority for all people. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5618|0 |1 is obsolete| | --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-06 03:26:44 UTC --- Created attachment 5726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5726 Bug 5459 - Holds not being shifted when merging biblios Holds are now shifted and reordered by date placed. Holds already marked waiting, or in transit are not reordered. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5726|0 |1 is obsolete| | --- Comment #28 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-06 03:28:27 UTC --- Created attachment 5727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5727 Bug 5459 - Holds not being shifted when merging biblios Holds are now shifted and reordered by date placed. Holds already marked waiting, or in transit are not reordered. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5727|0 |1 is obsolete| | --- Comment #29 from Nicole C. Engard <nengard@gmail.com> 2011-10-06 12:30:32 UTC --- Created attachment 5732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5732 [SIGNED-OFF] Bug 5459 - Holds not being shifted when merging biblios Holds are now shifted and reordered by date placed. Holds already marked waiting, or in transit are not reordered. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #30 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-06 13:22:37 UTC --- Minor issue: if a single borrower has both merging titles on hold, this patch does not reduce the two lines in reserves to one. This has some implications: a) the holds priority order can be adjusted safely, no issues there b) when the hold is marked 'waiting' for the patron, BOTH lines are changed to waiting; the rest of the priority list is okay c) but when the material is actually checked out to them, only one of the lines is marked "filled". The other is put back into first-place priority! This issue will come up any time a borrower has multiple holds on the same title, so this does extend beyond the scope of this particular issue. It is set to be addressed in the Holds Rewrite project. Once we have a primary key on reserves, this should no longer be an issue. In the meantime, is this a common enough problem to prevent this patch from being integrated? Adding this will make merge actually usable in most every case but this fringe, which is a vast improvement. But I don't want to set libraries up for failure, even in a rare case. Thoughts? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> 2011-10-06 13:33:00 UTC --- I think the fix is important enough to get approved despite the shortcoming. I think that case is probably not very common, and not a serious problem at that. It's just a minor inconvenience. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5732|0 |1 is obsolete| | --- Comment #32 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 09:57:37 UTC --- Created attachment 5848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5848 Bug 5459 - Holds not being shifted when merging biblios Holds are now shifted and reordered by date placed. Holds already marked waiting, or in transit are not reordered. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #33 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 10:00:41 UTC --- QA comment : no comment, good description, good code About Ian's comment, I agree with owen, and add that if a patron has placed 2 holds on 2 different biblios with the same title (if the biblios are merged, it means that's the same document, right ?) then there's a problem with the patron ;-) The case of merging 2 biblios both having hold is uncommon, the case to have 2 holds placed by the same patron will be more than rare, it may never happend ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 --- Comment #34 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-12 13:47:10 UTC --- If a patron is very interested in a title, they may very well have placed holds on every biblio they could find, in an effort to get the material as quickly as possible, so I don't think this scenario can be ignored. However, given that this patch fixes a profound problem with merge (one that made it unusable for many libraries), and that the breakage is not immediate, but rather on hold-fill of the duplicate listing, I think it's safe to mark this one as Passed QA. Many other changes to reserves are currently on my list for 3.6; I'd like to revisit this issue when those changes have been processed, to see if it changes the landscape. In the meantime, folks will need to be made aware of this possibility, and that a manual check of the holds priority list will be required to scan for any double entries. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #35 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-12 20:41:21 UTC --- Pushed, please test Needs a follow up to deal with a borrower having a hold on each biblio -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5459 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Blocks| |8149 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org