[Bug 26903] New: Imported authorities not added to ES indices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Bug ID: 26903 Summary: Imported authorities not added to ES indices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com Blocks: 26543 To recreate: - set your SearchEngine to Elastic - have an authority record - stage and import it - use link from completed import to see authority and confirm it exists in your system - search for authority, confirm you cannot find it Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113613&action=edit Bug 26903: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 113614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113614&action=edit Bug 26903: Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com, | |severine.queune@bulac.fr Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Imported authorities not |Authority records not being |added to ES indices |indexed in Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113613|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 113644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113644&action=edit Bug 26903: Unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113614|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 113645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113645&action=edit Bug 26903: Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113644|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113664&action=edit Bug 26903: Unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113645|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113665&action=edit Bug 26903: Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05, please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114299&action=edit Bug 26903: [20.05.x] Pass record ids and records through to update_index when passed to index_records When both a record and record_id are passed to index_records the data should be passed through to update_index. We missed copying over the record ids to the variable we use as a check. To test: 1 - Set searchEngine system preference to Elasticsearch 2 - Reindex your db 3 - Search authorities 4 - Edit a record and add 'testwaffle' to the main heading 5 - Search authorities for 'testwaffle' - no results 6 - Apply patch 7 - Edit the record again, change 'testwaffle' to 'testpancake' 8 - Search authorities for 'testpancake' - result! 9 - Confirm imported authorities and authorities added via Z39 are correctly indexed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 26903: Unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- index_records doesn't exist in 19.11 Missing dependencies for 19.11.x, can't backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org