[Bug 17818] New: Duplicating a subfield yields an empty subfield tag [ follow-up]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Bug ID: 17818 Summary: Duplicating a subfield yields an empty subfield tag [follow-up] Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: sophie.meynieux@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Bug 17152 made the subfield cloning function delete the contents of the cloned subfield. But it makes the subfield tag empty too, and this is causing troubles for people re-opening the records for edition. Bug 17477 fix this for textareas, but the problem is the same with dropdown box selection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 58470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58470&action=edit Bug 17817 - Duplicating a subfield yields an empty subfield tag [follow-up] The problem is the same as Bug 17477 but also for dropdown selection list Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to a field with repetable subfields and associated with authorised values - Select a value for the subfield 583$x) - Clone the subfield - select another value for the new subfield - Save the record - Edit the record to modify => the clone subfield has desappeared. If you look in DB in marcxml, the subfield is present but without code - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 --- Comment #2 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 58471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58471&action=edit Bug 17818 - Duplicating a subfield yields an empty subfield tag [follow-up] The problem is the same as Bug 17477 but also for dropdown selection list Steps to reproduce error: - On the cataloging screen (basic screen), create a new record - Go to a field with repetable subfields and associated with authorised values - Select a value for the subfield 583$x) - Clone the subfield - select another value for the new subfield - Save the record - Edit the record to modify => the clone subfield has desappeared. If you look in DB in marcxml, the subfield is present but without code - Apply patch - Clean cache browser and reload page - Repeat steps above - Verify that works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 --- Comment #3 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- wrong bug number in first commit message, sorry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17477 Assignee|gmcharlt@gmail.com |sophie.meynieux@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have tried testing this, but I had a lot of problems. My configuration: I created a new field and subfield 991$a, linked to CCODE for testing. The field and the subfield are marked as repeatable. Problem 0: - Try to repeat the field without filling in a value - It will not work, there is a JavaScript error message: TypeError: divs[i].getAttribute(...) is null cataloging.js:100:12 Problem 1: - Select a value for the subfield - Repeat the field - The value is copied form the original field into the repeated field (should be empty) Problem 2: - Try to clear the value in the repeated field using the X in the pull down. - It won't work. Problem 3: - Try to open the pull down in the repeated field - It won't work. I am not sure what's going on there, but something appears seriously wrong and makes it impossible to test this. I have restarted Plack, memcached and reloaded the page multiple times clearing the cache. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17863 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I filed a separate bug for the behaviour I saw - bug 17863. Would be nice if someone could retest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17725 CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- I can't reproduce it on current master... can someone confirm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Joseph, we fixed Bug 17817 - Repeat this Tag (cloning) not working after I tested this, it's possible that this fixed the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I cannot recreate either. Marked as duplicate of bug 17817. *** This bug has been marked as a duplicate of bug 17817 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Version|master |3.22 CC| |julian.maurice@biblibre.com Status|RESOLVED |REOPENED --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Reopened as it is still a bug on 3.22.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Pushed to Stable |In Discussion Version|3.22 |16.05 CC| |arouss1980@gmail.com --- Comment #11 from Andreas Roussos <arouss1980@gmail.com> --- This bug affects the latest 16.05 release (16.05.17) as well: when you clone a repeatable dropdown subfield the cloned subfield's tag is empty. If you then save the record and re-open it, the cloned subfield is not shown at all (even though it is present in the DB's marcxml column as Sophie pointed out). The next time you save the record, the subfield is gone for good :( If you try to reproduce this bug, please note that it's only the cloning of dropdown subfields that is broken in 16.05.17. Cloning of textarea subfields works fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |3.22 Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Andreas, please open a new bug report and link it to this one. This one has been marked as pushed and should not be reopened. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19503 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org