[Bug 17535] New: Regression: Search for reports by keyword
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Bug ID: 17535 Summary: Regression: Search for reports by keyword Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Reports Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 14435 Introduced by bug 14435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 [Bug 14435] Recover feature to store and access results of a report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: Search for |Regression: Search for |reports by keyword |reports by keywords -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57069&action=edit Bug 17535: Fix search for reports by keywords The commit cf9031711282f4be23e4a639797d0fd178940e1f Bug 14435: Add the ability to store result's report introduced a regression when searching for reports by keywords. It also breaks tests in t/db_dependent/Reports/Guided.t It's caused by the missing join on saved_reports. The error says DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' Test plan: Confirm that the tests are fixed and that you are able to search for reports using the "keyword" input -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57069|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57106&action=edit [SIGNED-OFF] Bug 17535: Fix search for reports by keywords The commit cf9031711282f4be23e4a639797d0fd178940e1f Bug 14435: Add the ability to store result's report introduced a regression when searching for reports by keywords. It also breaks tests in t/db_dependent/Reports/Guided.t It's caused by the missing join on saved_reports. The error says DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' Test plan: Confirm that the tests are fixed and that you are able to search for reports using the "keyword" input Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57106|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 57229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57229&action=edit [PASSED QA] Bug 17535: Fix search for reports by keywords The commit cf9031711282f4be23e4a639797d0fd178940e1f Bug 14435: Add the ability to store result's report introduced a regression when searching for reports by keywords. It also breaks tests in t/db_dependent/Reports/Guided.t It's caused by the missing join on saved_reports. The error says DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' Test plan: Confirm that the tests are fixed and that you are able to search for reports using the "keyword" input Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org