[Bug 10304] New: Filter notforloan items when searching for only available items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Bug ID: 10304 Summary: Filter notforloan items when searching for only available items Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: kyle.m.hall@gmail.com It does not make sense for the "available items only" search limit to include results for items that are not for loan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18280&action=edit Bug 10304 - Filter notforloan items when searching for only available items It does not make sense for the "available items only" search limit to include results for items that are not for loan. Test Plan: 1) Catalog 3 records with 1 or more items each, make the first two records' items available for loan, and the third record's items not for loan. 2) Do a search limiting only to available items 3) Note all 3 records are in the search results 4) Apply this patch 5) Refresh the search results 6) Note the third record ( with only not for loan items ) is no longer in the search results list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, sorry, but I disagree here. As I understand it available does not necessarily imply that you can check the item out, but that it's currently available (on the shelf) in the library. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18280|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18350&action=edit Bug 10304 - Add avanced search filter for "not for loan" items This patch adds a new search limit for not for loan items. This limit filters all items that have a notforloan value not equal to 0. This limit can be used in conjunction with the "available" limit so that a person may search for items that are available and can be checked out right away. Test Plan: 1) Apply this patch 2) Catalog 3 records with 1 item each. a) Mark item A as notforloan b) Mark item B as lost c) Do nothing to item C 3) Do a search limiting only to available items a) You should see item's A and C in your reults 4) Do a search limiting only to items that can be checked out a) You should see item's B and C 5) Do a seach using both limits a) You should see item C and not items A or B -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Filter notforloan items |Add avanced search filter |when searching for only |for "not for loan" items |available items | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> --- Ok, I've updated my patch to make it a new optional filter that may be used in conjunction with the existing availability filter. (In reply to comment #2)
Kyle, sorry, but I disagree here. As I understand it available does not necessarily imply that you can check the item out, but that it's currently available (on the shelf) in the library.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 18350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18350 Bug 10304 - Add avanced search filter for "not for loan" items "Only items that can be checked out" seems a bit dangerous for me as a lot of our libraries allow some patron categories to checkout several itemtypes while others are not allowe. So almost no items are marked 'reference'. It's not possible to create a filter that will take into account circulation rules and for some libraries this will work - also it has an id so it can be hidden. But I am still a little worried we will see bug reports about that not working like people expect it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Marie-Laure Meunier <marielaure.meunier@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marielaure.meunier@gmail.co | |m --- Comment #6 from Marie-Laure Meunier <marielaure.meunier@gmail.com> --- After testing the patch during the koha symposium in Limoges, the result is not positive when the filter is selected. There is no result even if the items are available for loan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- After reading the comments I am changing this to enhancement as it does not seem to be considered a bug fix anymore but a new option. Please change it back if that is incorrect. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- This patch appears to break the "only available" option, whether it is used on its own or in conjunction with the new "only for loan" option. I get no results for a search which should return available items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org