[Bug 33156] New: Batch patron modification tool is missing search bar and other attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Bug ID: 33156 Summary: Batch patron modification tool is missing search bar and other attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The table that loads on modborrowers.pl was a data table with a search bar and pager at the top. When choosing a patron attribute from the Patron attribute drop-down at the bottom of the page, if that attribute had an authorized value associated with it, a second drop-down list would appear to the right of the drop-down with the options for that attribute. Now all that appears is a basic input box and it appears whether or not you've chosen an attribute to edit or not. Error: Uncaught TypeError: table_settings.push is not a function <anonymous> https://staff.cin.bywatersolutions.com/cgi-bin/koha/tools/modborrowers.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Laura, I just tested this on master and it worked ok. Which version did you encounter the problem in? Does it still not work for you? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Interesting: I don't see an error on the search form, but I see it on the 'result list' after the changes have been made. Maybe there is 2 different bugs here, one on the form, not present in master, and one for the results? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #3 from George Williams (NEKLS) <george@nekls.org> --- Katrin, Laura filed this bug on behalf of NEKLS and CIN and both of our consortia are experiencing it on Koha 22.05 George -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi George, it took me a while and I cannot reproduce the error with selecting an attribute that is linked to an AV, the form itself seems ok in master, but I can see the JS error now. You have to update an extended attribute in order to see it: * Go to the patron modification tool * Add one or more cardnumbers, I used 42 * Select the "show barcode" extended patron attribute at the end of the form and update to yes or no On the results list, you'll see the error in the console: table_settings.push({ columname: "Attributes 1", cannot_be_modified: 0, cannot_be_toggled: 0, is_hidden: 0 }); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |oleonard@myacpl.org --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can also see the error on the form now - not sure why I didn't previously: Uncaught TypeError: table_settings.push is not a function -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 148406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148406&action=edit Bug 33156: Fix JS error on batch patron modification The error currently breaks some of the functionality for updating patron attributes linked to AV values. With the bug, the input field will not change to the AV list when selected from the pull down of patron attributes. It was probably bug 29648 that changed the data structure without adapting for the additional data that is pushed to the object for the patron attribute columns. To test: * Create several extended patron attributes * Make sure at least one is linked to an AV * Repeatable and unique patron attributes can't be updated in batch patron modification, so you need some that can be modified. * Go to tools > batch patron modification * Enter one or more cardnumbers to update * Verify the table is missing columns, export and configure * Verify when selecting the AV tied patron attribute, the input remains a text one * Apply patch * Both should work now as expected Note: I believe there are some more errors on this page, but they should better be handled separately. So with this patch we push configuration again for each column to table columns, but the very last column keeps missing from the columns settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Depends on| |29648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29648 [Bug 29648] Make KohaTable tables 'default length' and 'default sort' configurable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148406|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 149074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149074&action=edit Bug 33156: Fix JS error on batch patron modification The error currently breaks some of the functionality for updating patron attributes linked to AV values. With the bug, the input field will not change to the AV list when selected from the pull down of patron attributes. It was probably bug 29648 that changed the data structure without adapting for the additional data that is pushed to the object for the patron attribute columns. To test: * Create several extended patron attributes * Make sure at least one is linked to an AV * Repeatable and unique patron attributes can't be updated in batch patron modification, so you need some that can be modified. * Go to tools > batch patron modification * Enter one or more cardnumbers to update * Verify the table is missing columns, export and configure * Verify when selecting the AV tied patron attribute, the input remains a text one * Apply patch * Both should work now as expected Note: I believe there are some more errors on this page, but they should better be handled separately. So with this patch we push configuration again for each column to table columns, but the very last column keeps missing from the columns settings. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For me, the standard table heading (number of entries, search, Columns, Export, Configure, etc) was not appearing on the results page after pressing Save. 2. Another issue I noticed is that if you have multiple patron attributes: 2.1 Select one of the patron attributes (say a plain text one) 2.2 Enter a text value 2.3 Click New 2.4 Choose a patron attribute that has an authorized value 2.5 Note that the options for the first patron attribute (the plain text one) has now changed to a dropdown list with the same values as the second one (2.4) 2.6 Now if you add another new patron attribute (say another plain text one), it changes all the patron attributes listed so far to a plain text input box I hope this makes sense! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149074|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150193&action=edit Bug 33156: Fix JS error on batch patron modification The error currently breaks some of the functionality for updating patron attributes linked to AV values. With the bug, the input field will not change to the AV list when selected from the pull down of patron attributes. It was probably bug 29648 that changed the data structure without adapting for the additional data that is pushed to the object for the patron attribute columns. To test: * Create several extended patron attributes * Make sure at least one is linked to an AV * Repeatable and unique patron attributes can't be updated in batch patron modification, so you need some that can be modified. * Go to tools > batch patron modification * Enter one or more cardnumbers to update * Verify the table is missing columns, export and configure * Verify when selecting the AV tied patron attribute, the input remains a text one * Apply patch * Both should work now as expected Note: I believe there are some more errors on this page, but they should better be handled separately. So with this patch we push configuration again for each column to table columns, but the very last column keeps missing from the columns settings. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.13 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #13 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- conflicts on 21.11. won't backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org