[Bug 20819] New: GDPR: Add a consent field for processing personal data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Bug ID: 20819 Summary: GDPR: Add a consent field for processing personal data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com See 18081 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GDPR: Add a consent field |GDPR: Add a consent field |for processing personal |for processing personal |data |data in account menu and | |self-registration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75765&action=edit Bug 20819: Dbrev for new table patron_consent and sysprefs [1] We add table patron_consent. It allows for future extension. We could e.g. save consent for newsletter etc. [2] Add one field to borrower_modifications Datetime the patron who self-registered, gave consent. [3] Syspref PrivacyPolicyURL [4] Syspref GDPR_Policy: enforced, permissive or disabled. Test plan: [1] Run the dbrev or do a new install. [2] Look at the description of the new prefs in Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75766&action=edit Bug 20819: DBIx schema changes No test plan. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75767&action=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED Patch complexity|--- |Small patch --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- More patches forthcoming tomorrow or so. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75818&action=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75819&action=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75820&action=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75766|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76781&action=edit Bug 20819: DBIx schema changes No test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75767|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76782&action=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75818|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76783&action=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75819|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76784&action=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75820|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76785&action=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #14 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Do we need to keep a copy of the template in use during the consent in the database along with the borrower ID and date? The UK ICO page on consenting seems to say we do: https://ico.org.uk/for-organisations/guide-to-the-general-data-protection-re... (second example). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jon Knight from comment #14)
Do we need to keep a copy of the template in use during the consent in the database along with the borrower ID and date? The UK ICO page on consenting seems to say we do:
https://ico.org.uk/for-organisations/guide-to-the-general-data-protection- regulation-gdpr/consent/how-should-we-obtain-record-and-manage-consent/
(second example).
Thx for your interest in this patch. The link says: === If consent was given online, your records should include the data submitted as well as a timestamp to link it to the relevant version of the data capture form. You keep records that include an ID and the data submitted online together with a timestamp. You also keep a copy of the version of the data-capture form and any other relevant documents in use at that date. === This patch registers the borrower ID and the timestamp of consent given. What each library should keep somehow (not described), is: a version history of the template, esp. the exact text for the consent and a history of the referenced privacy page text. In that way you can 'prove' that the user gave consent for a specific version of template and privacy page. (Note: the privacy page is only specified in this patch by a preference called PrivacyPolicyURL. The library itself should create that local page.) I am no legal expert, but I can't imagine that we need to save these texts at an individual consent level. Hope this is clear enough? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #16 from Jon Knight <J.P.Knight@lboro.ac.uk> --- I was focusing on the example box with the tick (in other words the right, approved way the ICO expect this to be handled) that says: "You keep records that include an ID and the data submitted online together with a timestamp. You also keep a copy of the version of the data-capture form and any other relevant documents in use at that date." So to me that does imply the need to save these texts at an individual consent level, as they all form part of the consent package for that user. Indeed the "crossed" part (wrong) of that example says, "You keep the time and date of consent linked to an IP address, with a web link to your current data-capture form and privacy policy" so they seem to think that just knowing what the PrivacyPolicyURL was set to at the time of consent is not enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I was looking at the same text as you. But I concluded that we need to save the consent tekst somewhere in a version history not on consent level (that would be unneeded redundancy). But not implying that saving a URL would be enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Probably changes on Member.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75765|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 77264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77264&action=edit Bug 20819: Dbrev for new table patron_consent and sysprefs [1] We add table patron_consent. It allows for future extension. We could e.g. save consent for newsletter etc. [2] Add one field to borrower_modifications Datetime the patron who self-registered, gave consent. [3] Syspref PrivacyPolicyURL [4] Syspref GDPR_Policy: enforced, permissive or disabled. Test plan: [1] Run the dbrev or do a new install. [2] Look at the description of the new prefs in Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76781|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 77265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77265&action=edit Bug 20819: DBIx schema changes No test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76782|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 77266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77266&action=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76783|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 77267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77267&action=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76784|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 77268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77268&action=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76785|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 77269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77269&action=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased. Especially last patch had conflicts due to AddMember changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77264|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78369&action=edit Bug 20819: Dbrev for new table patron_consent and sysprefs [1] We add table patron_consent. It allows for future extension. We could e.g. save consent for newsletter etc. [2] Add one field to borrower_modifications Datetime the patron who self-registered, gave consent. [3] Syspref PrivacyPolicyURL [4] Syspref GDPR_Policy: enforced, permissive or disabled. Test plan: [1] Run the dbrev or do a new install. [2] Look at the description of the new prefs in Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77265|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78370&action=edit Bug 20819: DBIx schema changes No test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77266|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78371&action=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77267|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78372&action=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77268|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78373&action=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77269|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 78374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78374&action=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Needed a rebase for removed NorwegianDB prefs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 [Bug 21336] GDPR: Process unsubscribe requests automatically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #33 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78369|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78371|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78372|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78373|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78374|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #34 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 78779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78779&action=edit Bug 20819: Dbrev for new table patron_consent and sysprefs [1] We add table patron_consent. It allows for future extension. We could e.g. save consent for newsletter etc. [2] Add one field to borrower_modifications Datetime the patron who self-registered, gave consent. [3] Syspref PrivacyPolicyURL [4] Syspref GDPR_Policy: enforced, permissive or disabled. Test plan: [1] Run the dbrev or do a new install. [2] Look at the description of the new prefs in Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #35 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 78781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78781&action=edit Bug 20819: DBIx schema changes No test plan. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #36 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 78783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78783&action=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #37 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 78784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78784&action=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #38 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 78786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78786&action=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #39 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 78788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78788&action=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to sandboxes@biblibre.com from comment #39)
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Thanks Séverine! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21368 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21368 [Bug 21368] GDPR: Make a consent field visible at staff view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21369 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21369 [Bug 21369] GDPR: Send e-mail notification if user set that don't agree with consent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78786|0 |1 is obsolete| | --- Comment #41 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79059&action=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21374 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21374 [Bug 21374] Self registration e-mail verification does not work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78779|0 |1 is obsolete| | Attachment #78781|0 |1 is obsolete| | Attachment #78783|0 |1 is obsolete| | Attachment #78784|0 |1 is obsolete| | Attachment #78788|0 |1 is obsolete| | Attachment #79059|0 |1 is obsolete| | --- Comment #42 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79062&action=edit Bug 20819: Dbrev for new table patron_consent and sysprefs [1] We add table patron_consent. It allows for future extension. We could e.g. save consent for newsletter etc. [2] Add one field to borrower_modifications Datetime the patron who self-registered, gave consent. [3] Syspref PrivacyPolicyURL [4] Syspref GDPR_Policy: enforced, permissive or disabled. Test plan: [1] Run the dbrev or do a new install. [2] Look at the description of the new prefs in Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79063&action=edit Bug 20819: DBIx schema changes No test plan. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79064&action=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79065&action=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #46 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79066&action=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #47 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79067&action=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Josef Moravec from comment #47)
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Thanks Josef -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79062|0 |1 is obsolete| | --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 79129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79129&action=edit Bug 20819: Dbrev for new table patron_consent and sysprefs [1] We add table patron_consent. It allows for future extension. We could e.g. save consent for newsletter etc. [2] Add one field to borrower_modifications Datetime the patron who self-registered, gave consent. [3] Syspref PrivacyPolicyURL [4] Syspref GDPR_Policy: enforced, permissive or disabled. Test plan: [1] Run the dbrev or do a new install. [2] Look at the description of the new prefs in Administration. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79063|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 79130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79130&action=edit Bug 20819: DBIx schema changes No test plan. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79064|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 79131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79131&action=edit Bug 20819: Add Koha object classes for patron consents Introduces Koha::Patron::Consent[s] for new table. Adds basic CRUD test. Test plan: Run t/db_dependent/Koha/Patron/Consents.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79065|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 79132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79132&action=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79066|0 |1 is obsolete| | --- Comment #53 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 79133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79133&action=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79067|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 79134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79134&action=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Resolved a checksum problem in patch 2 and a git problem for patch 6. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79134|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 79135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79135&action=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #55)
Resolved a checksum problem in patch 2 and a git problem for patch 6.
Patch 6 had no problem; forgot to apply dependency on 21374 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79175&action=edit Bug 20819: (RM follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #59 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #60 from Nick Clemens <nick@bywatersolutions.com> --- I pushed this, the UI display for when a user has denied consent could be improved - it still seems to be waiting for approval, but doesn't make it clear that 'No' has been set - as others seemed fine with it I let it go but something to consider -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #61 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #58)
Created attachment 79175 [details] [review] Bug 20819: (RM follow-up) Add missing filters
Thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #62 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 79190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79190&action=edit Bug 20819: (Follow-up) Show more clearly that a user gave no consent See comment60 on Bugzilla. Although I intentionally did not want to show date and time of refusal, we can obviously add one line saying that we already have a no. Test plan: Login without consent and see no additional line. Agree and verify that you see the registered on xxx line. Disagree and verify that you now see "You indicated recently...". Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #63 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #60)
I pushed this, the UI display for when a user has denied consent could be improved - it still seems to be waiting for approval, but doesn't make it clear that 'No' has been set - as others seemed fine with it I let it go but something to consider
See attachment. Your consent please :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This report adds a new release notes| |table patron_consent in | |order to save user consent | |for processing personal | |data (GDPR), but allows for | |future extension. | |It adds | |two preferences: | |GDPR_Policy and | |PrivacyPolicyURL. The first | |pref allows you to enforce | |giving consent before using | |the OPAC as a specific | |user. In permissive mode, | |we only show a warning on | |the consent page. The | |second pref allows you to | |add a URL to a privacy | |policy page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This report adds a new |This report adds a new release notes|table patron_consent in |table patron_consent in |order to save user consent |order to save user consent |for processing personal |for processing personal |data (GDPR), but allows for |data (GDPR), but allows for |future extension. |future extension. |It adds |It adds |two preferences: |two preferences: |GDPR_Policy and |GDPR_Policy and |PrivacyPolicyURL. The first |PrivacyPolicyURL. The first |pref allows you to enforce |pref allows you to enforce |giving consent before using |giving consent before using |the OPAC as a specific |the OPAC as a specific |user. In permissive mode, |user. In permissive mode, |we only show a warning on |we only show a warning on |the consent page. The |the consent page. The |second pref allows you to |second pref allows you to |add a URL to a privacy |add a URL to a privacy |policy page. |policy page. | |On the self | |registration page we also | |add asking for consent if | |the pref is enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #64 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #62)
Created attachment 79190 [details] [review] Bug 20819: (Follow-up) Show more clearly that a user gave no consent
See comment60 on Bugzilla. Although I intentionally did not want to show date and time of refusal, we can obviously add one line saying that we already have a no.
Test plan: Login without consent and see no additional line. Agree and verify that you see the registered on xxx line. Disagree and verify that you now see "You indicated recently...".
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Followup pushed to master for 18.11, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Bug 20819 depends on bug 21374, which changed state. Bug 21374 Summary: Self registration e-mail verification does not work https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21374 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- + my $consent = Koha::Patron::Consents->search({ + borrowernumber => getborrowernumber($user), + type => 'GDPR_PROCESSING', + given_on => { '!=', undef }, + })->next; + if( !$consent ) { ->count could have been better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #67 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #66)
+ my $consent = Koha::Patron::Consents->search({ + borrowernumber => getborrowernumber($user), + type => 'GDPR_PROCESSING', + given_on => { '!=', undef }, + })->next; + if( !$consent ) {
->count could have been better.
I tested that assumption a bit. And it seems not to be true in terms of performance at least? In short: 1.3480 sec for 1000 counts and 0.0094 for 1000 next's (on 1000 records). It seems that DBIx goes to the db for each count but the repeated nexts are handled much more efficiently (cache, prefetch, ..)? Script fragment on next comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #68 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- my $set = Koha::Patron::Consents->search({ borrowernumber => $firstid }); #my $set = Koha::Patron::Consents->search; my $t1 = time; foreach(1..100) { my $i = $set->count; } my $t2 = time; is(1, 1, sprintf( "COUNT %6.4f\n", $t2 - $t1 ) ); $t1 = time; foreach(1..100) { my $i = $set->next; } #foreach(1..1000) { my $i = $set->next; #$set->_resultset->first unless $i; } $t2 = time; is(1, 1, sprintf( "NEXT %6.4f\n", $t2 - $t1 ) ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #69 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- use Modern::Perl; use Data::Dumper qw/Dumper/; use Test::More tests => 1; use Time::HiRes qw/time/; use t::lib::Mocks; use t::lib::TestBuilder; use Koha::Patron::Consents; my $schema = Koha::Database->new->schema; my $builder = t::lib::TestBuilder->new; $schema->storage->txn_begin; subtest 'myTest' => sub { plan tests => 2; # Add 1000 consents my $firstid; foreach(1..100) { my $consent = $builder->build_object({ class => 'Koha::Patron::Consents' }); $firstid = $consent->borrowernumber if !$firstid; } my $set = Koha::Patron::Consents->search({ borrowernumber => $firstid }); #my $set = Koha::Patron::Consents->search; my $t1 = time; foreach(1..100) { my $i = $set->count; } my $t2 = time; is(1, 1, sprintf( "COUNT %6.4f\n", $t2 - $t1 ) ); $t1 = time; foreach(1..100) { my $i = $set->next; } #foreach(1..1000) { my $i = $set->next; #$set->_resultset->first unless $i; } $t2 = time; is(1, 1, sprintf( "NEXT %6.4f\n", $t2 - $t1 ) ); }; $schema->storage->txn_rollback; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marcel, use DBIC_TRACE=1 to understand what's going on. You are comparing 100 queries vs 1 query: 100 "SELECT COUNT" vs 1 "SELECT *" The ->next will return something only on first pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Agreed, that test isn't testing what you think Marcel. The ->next is chained onto the resultset inside the loop in C4::Auth whereas the resultset is created outside of the loop in your test. I actually don't know which is faster, but I would imagine count is a bit faster and more memory efficient. Try moving the queries inside the loop and test again, I'd certainly be interested in the results. (a correlate subquery version might be interesting too) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ignore the subquery bit.. that doesn't apply here (though I'd still be interested in comparing that at some point) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #73 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #70)
Marcel, use DBIC_TRACE=1 to understand what's going on.
You are comparing 100 queries vs 1 query: 100 "SELECT COUNT" vs 1 "SELECT *"
The ->next will return something only on first pass.
Yeah I have been toggling a bit with comment chars. But I also tested the next on the set of 100 records. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #74 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- # Subtest: myTest 1..2 ok 1 - COUNT 0.1278 # ok 2 - NEXT 0.0106 # 18021068316832683368346835683668376838683968406841684268436844684568466847684868496850685168526853685468556856685768586859686068616862686368646865686668676868686968706871687268736874687568766877687868796880688168826883688468856886688768886889689068916892689368946895689668976898689969006901690269036904690569066907690869096910691169126913691469156916691769186919692069216922692369246925692669276928 with a slight variation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #75 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- use Modern::Perl; use Data::Dumper qw/Dumper/; use Test::More tests => 1; use Time::HiRes qw/time/; use t::lib::Mocks; use t::lib::TestBuilder; use Koha::Patron::Consents; my $schema = Koha::Database->new->schema; my $builder = t::lib::TestBuilder->new; $schema->storage->txn_begin; subtest 'myTest' => sub { plan tests => 2; # Add 1000 consents my $firstid; foreach(1..100) { my $consent = $builder->build_object({ class => 'Koha::Patron::Consents' }); $firstid = $consent->borrowernumber if !$firstid; } #my $set = Koha::Patron::Consents->search({ borrowernumber => $firstid }); my $set = Koha::Patron::Consents->search; my $t1 = time; foreach(1..100) { my $i = $set->count; } my $t2 = time; is(1, 1, sprintf( "COUNT %6.4f\n", $t2 - $t1 ) ); my $str = ''; $t1 = time; foreach(1..100) { my $i = $set->next; $str.= $i->id; } #foreach(1..1000) { my $i = $set->next; #$set->_resultset->first unless $i; } $t2 = time; is(1, 1, sprintf( "NEXT %6.4f\n", $t2 - $t1 ) ); print "$str\n"; }; $schema->storage->txn_rollback; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #76 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #71)
The ->next is chained onto the resultset inside the loop in C4::Auth whereas the resultset is created outside of the loop in your test. Yeah deliberately.
I actually don't know which is faster, but I would imagine count is a bit faster and more memory efficient. Thats the problem. I would expect something else.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #77 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- On 1000 records: ok 1 - COUNT 1.3365 ok 2 - NEXT 0.0950 The printed string shows all 1000 primary keys too. What am I missing here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #76)
(In reply to Martin Renvoize from comment #71)
The ->next is chained onto the resultset inside the loop in C4::Auth whereas the resultset is created outside of the loop in your test. Yeah deliberately.
OK, I'm confused then.. what are you trying to prove here then?
I actually don't know which is faster, but I would imagine count is a bit faster and more memory efficient. Thats the problem. I would expect something else.
When doing it inside the loop as per my suggestion what you're actually doing is SELECT COUNT(*) FROM whatever WHERE whatever; Cache this answer and print it 100 times vs SELECT * FROM whatever WHERE whatever; Do this 100 times, hitting the database for each call of 'Next' to get the next result given an offset from the database. (Unless you call prefetch which says 'get me all rows in one go and cache them to iterate in memory) -- You are receiving this mail because: You are watching all bug changes.
From IRC: See https://metacpan.org/source/RI[…]esultSet.pm#L1594 count is cached at the dbic level here which is why recursing count on the same resultset should be very very fast. https://metacpan.org/source/RI[…]esultSet.pm#L1229 next gets really clever ;)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #79 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- there's loads of optimizatino in there regarding caching rows see _construct_results It seems that count is not cached in my test (so recursing not fast) and next is cached. I am not triggered right now to replace the next in Auth.pm. And for one next we are talking about milliseconds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22646 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22646 [Bug 22646] Fix use of PrivacyPolicyURL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23150 --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why do we have the following line: opac/opac-memberentry.pl: push @fields, 'gdpr_proc_consent' if C4::Context->preference('GDPR_Policy'); It causes bug 23150. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 [Bug 23150] GDPR breaks patron self modification on OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #81 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #80)
Why do we have the following line:
opac/opac-memberentry.pl: push @fields, 'gdpr_proc_consent' if C4::Context->preference('GDPR_Policy');
It causes bug 23150.
See bug 23150. No bug, but design. The field should be handled as mandatory. If you do not want to give consent, you cannot register an account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #82 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #81)
(In reply to Jonathan Druart from comment #80)
Why do we have the following line:
opac/opac-memberentry.pl: push @fields, 'gdpr_proc_consent' if C4::Context->preference('GDPR_Policy');
It causes bug 23150.
See bug 23150. No bug, but design. The field should be handled as mandatory. If you do not want to give consent, you cannot register an account.
Not completely true: see 23150 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28934 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 [Bug 28934] Correct markup of GDPR consent in OPAC patron entry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31503 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31503 [Bug 31503] Allow several consent types on the consents tab of OPAC account page -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org