[Bug 40771] New: Wrong transfer breaking check in for holds when using library transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 Bug ID: 40771 Summary: Wrong transfer breaking check in for holds when using library transfer limits Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Bug 39750 fixed the case of a transfer with no hold - it seems the same problem can occur when the transfer is for a hold: Line 178 of returns.pl my $hold = Koha::Holds->find($reserve_id); if ($diffBranchSend) { my $tobranch = $hold->pickup_library(); # Add transfer, enqueue if one is already in the queue, and immediately set to in transit my $transfer = $item->request_transfer( { to => $tobranch, reason => 'Reserve', enqueue => 1 } ); $transfer->transit; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 [Bug 39750] Wrong transfer breaking check in when using library transfer limits -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190585&action=edit Bug 40771: Fix error in the case of AutoFill Similar to previous patches we need to ignore limits to return a reserve where it belongs To test: 1 - Set sysprefs: UseBranchTransferLimits/BranchTransferLimitsType: To Enforce based on collection HoldsAutoFill: Do 2 - Administration->Library Transfer limits click (Advanced editor) 3 - Uncheck Centerville->Fairfield for 'Fiction' 4 - Find or create a Fiction item at centerville 5 - Place a hold on the item for a patron to pickup at Centerville 6 - Check the item in at Centerville 7 - Switch branch to Fairfield 8 - Check in the item 9 - Boom! Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed' 10 - Apply patch, restart all 11 - Check in the item at Fairfield 12 - Correctly transferred to Centerville -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190586&action=edit Bug 40771: Fix transfer error when not auto filling hold This patch is another occurence where correcting a reserve transfer requires ignoring limits To test: 1 - Follow previous test plan 2 - Disable HoldsAutoFill 3 - Set library to Centerville 4 - Check the item in and confirm hold 5 - Set library to Fairfield 6 - Check the item in and confirm transfer 7 - Boom! Same error as before 8 - Apply this patch, restart all 9 - Check item in 10 - Correctly transferred to Centerville -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190585|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190587&action=edit Bug 40771: Fix error in the case of AutoFill Similar to previous patches we need to ignore limits to return a reserve where it belongs To test: 1 - Set sysprefs: UseBranchTransferLimits/BranchTransferLimitsType: To Enforce based on collection HoldsAutoFill: Do 2 - Administration->Library Transfer limits click (Advanced editor) 3 - Uncheck Centerville->Fairfield for 'Fiction' 4 - Find or create a Fiction item at centerville 5 - Place a hold on the item for a patron to pickup at Centerville 6 - Check the item in at Centerville 7 - Switch branch to Fairfield 8 - Check in the item 9 - Boom! Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed' 10 - Apply patch, restart all 11 - Check in the item at Fairfield 12 - Correctly transferred to Centerville Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190586|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 190588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190588&action=edit Bug 40771: Fix transfer error when not auto filling hold This patch is another occurence where correcting a reserve transfer requires ignoring limits To test: 1 - Follow previous test plan 2 - Disable HoldsAutoFill 3 - Set library to Centerville 4 - Check the item in and confirm hold 5 - Set library to Fairfield 6 - Check the item in and confirm transfer 7 - Boom! Same error as before 8 - Apply this patch, restart all 9 - Check item in 10 - Correctly transferred to Centerville Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Trivial, self SO -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 Bug 40771 depends on bug 39750, which changed state. Bug 39750 Summary: Wrong transfer breaking check in when using library transfer limits https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39750 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40771 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not sure if this fix allows other cases to bypass defined limits now. Shouldnt the use cases here somehow allow a staff override action or so instead of the current automatic approval? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org