[Bug 41690] New: Add MARC21 245$b (subtitle) to Cite option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Bug ID: 41690 Summary: Add MARC21 245$b (subtitle) to Cite option Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org The "Cite" option in the OPAC is missing the subtitle (245$b) in MARC21. To recreate: 1. Add a record or find a record with a subtitle (in KTD, biblionumber 58 has a 245$b http://localhost:8081/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=58 2. In the OPAC, go to the record http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=58 3. Click "Cite" --> The subtitle is not in any of the citations I consulted a customer in a university and he said the subtitle should be after the title and be preceded by a colon. e.g. 'More fruitful than the soil' : army, empire and the Scottish Highlands, 1715-1815 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 [Bug 14670] Add 'cite' option to detail page in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- My customer also mentioned other missing elements. I wonder if I should add them in the same bug or create separate bugs for each element? Here they are, let me know if I should create separate bugs for each of these. - In Chicago 18th edition, there is no publication place - Punctuation seems to be ommited in author names (they have "inc." in some of their author names and the period after inc is chopped off even if it's part of the company name) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40648 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Alexander Wagner <alexander.wagner@desy.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.wagner@desy.de --- Comment #2 from Alexander Wagner <alexander.wagner@desy.de> --- Please note that Kohas structured outputs (I checked BibTeX) have a similar shortcoming. For citation styles, it might be worthwhile to check if it wouldn't be sensible to come up with some conversion of the Marc data to Citation Style Language (cf. https://citationstyles.org/) and then use a library based on CSL to render the citation for the web, instead of the current static perl code that writes out fields in the relevant form for every citation style. (Cf. https://citationstyles.org/developers/#csl-processors) Reasoning: - CSL is supported by some well used reference management tools (I know quite a few people still you copy&paste.) - CSL can be used to return _whatever_ style out there, so the selection could offer more, if needs be. - CSL itself is quite flexible if it is necessary to adopt to specific styles - Quite a few publishers support CSL by providing suitable styles for their outlets - Filling in CSL _as best as we can_ would avoid a missing field - There might be some ready made tools for MarcXML -> CSL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #3 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 194475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194475&action=edit Bug 41690: Add MARC21 245 (subtitle) to Cite option The "Cite" option in the OPAC is missing the subtitle (245) in MARC21. To recreate: 1. Add a record or find a record with a subtitle (in KTD, biblionumber 58 has a 245 http://localhost:8081/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=58 2. In the OPAC, go to the record http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=58 3. Click "Cite" --> The subtitle is not in any of the citations 4. Apply the patch 5. Repeat step 2 and 3 --> The subtitle is now shown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |hammat.wele@inlibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Hammat is this ready for testing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #5 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 194908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194908&action=edit Bug 41690: (follow-up) Add test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to Owen Leonard from comment #4)
Hammat is this ready for testing?
Yes it is now ready for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194908|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 194931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194931&action=edit Bug 41690: Add MARC21 245 (subtitle) to Cite option The "Cite" option in the OPAC is missing the subtitle (245) in MARC21. To recreate: 1. Add a record or find a record with a subtitle (in KTD, biblionumber 58 has a 245 http://localhost:8081/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=58 2. In the OPAC, go to the record http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=58 3. Click "Cite" --> The subtitle is not in any of the citations 4. Apply the patch 5. Repeat step 2 and 3 --> The subtitle is now shown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 194932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194932&action=edit Bug 41690: (follow-up) Add test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|oleonard@myacpl.org |hammat.wele@inlibro.com Text to go in the| |This fixes citations release notes| |generated using the "Cite" | |option in the OPAC - | |subtitles are now included | |in the title where they | |exist for MARC21 (245$b). --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Alexander Wagner from comment #2)
Please note that Kohas structured outputs (I checked BibTeX) have a similar shortcoming.
For citation styles, it might be worthwhile to check if it wouldn't be sensible to come up with some conversion of the Marc data to Citation Style Language (cf. https://citationstyles.org/) and then use a library based on CSL to render the citation for the web, instead of the current static perl code that writes out fields in the relevant form for every citation style. (Cf. https://citationstyles.org/developers/#csl-processors)
Reasoning: - CSL is supported by some well used reference management tools (I know quite a few people still you copy&paste.) - CSL can be used to return _whatever_ style out there, so the selection could offer more, if needs be. - CSL itself is quite flexible if it is necessary to adopt to specific styles - Quite a few publishers support CSL by providing suitable styles for their outlets - Filling in CSL _as best as we can_ would avoid a missing field - There might be some ready made tools for MarcXML -> CSL
I do like this idea. Although I'm not familiar enough with citation styles and requirements to offer a considered opinion! I think doing something like this deserves its own bug. In the meantime, fixing it this way solves the immediate issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to David Nind from comment #9)
(In reply to Alexander Wagner from comment #2)
Please note that Kohas structured outputs (I checked BibTeX) have a similar shortcoming.
For citation styles, it might be worthwhile to check if it wouldn't be sensible to come up with some conversion of the Marc data to Citation Style Language (cf. https://citationstyles.org/) and then use a library based on CSL to render the citation for the web, instead of the current static perl code that writes out fields in the relevant form for every citation style. (Cf. https://citationstyles.org/developers/#csl-processors)
Reasoning: - CSL is supported by some well used reference management tools (I know quite a few people still you copy&paste.) - CSL can be used to return _whatever_ style out there, so the selection could offer more, if needs be. - CSL itself is quite flexible if it is necessary to adopt to specific styles - Quite a few publishers support CSL by providing suitable styles for their outlets - Filling in CSL _as best as we can_ would avoid a missing field - There might be some ready made tools for MarcXML -> CSL
I do like this idea. Although I'm not familiar enough with citation styles and requirements to offer a considered opinion!
I think doing something like this deserves its own bug.
In the meantime, fixing it this way solves the immediate issue.
Thanks for testing David! I also think redoing completely the way this is done should be in a separate bug. This one was just to add the subtitle in the citation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194932|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 198133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198133&action=edit Bug 41690: Add MARC21 245 (subtitle) to Cite option The "Cite" option in the OPAC is missing the subtitle (245) in MARC21. To recreate: 1. Add a record or find a record with a subtitle (in KTD, biblionumber 58 has a 245 http://localhost:8081/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=58 2. In the OPAC, go to the record http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=58 3. Click "Cite" --> The subtitle is not in any of the citations 4. Apply the patch 5. Repeat step 2 and 3 --> The subtitle is now shown Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 198134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198134&action=edit Bug 41690: (follow-up) Add test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate CC| |dcook@prosentient.com.au --- Comment #15 from David Cook <dcook@prosentient.com.au> --- Looks like the Cite option was added in 24.11.00 so still valid for 25.05... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.05 |26.05.00,25.11.05,25.05.13 released in| | --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Applying to 25.05.x for 25.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41690 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org