[Bug 9451] New: borrower_stats.pl gives off warnings and is not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Bug ID: 9451 Summary: borrower_stats.pl gives off warnings and is not Plack-compatible Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: jcamins@cpbibliography.com Reporter: jcamins@cpbibliography.com Variable "$period" is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/bo rrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/bo rrowers_stats.pl line 376. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 14763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14763&action=edit Bug 9451: Quiet warnings and Plackify borrower_stats.pl There are several warnings and one non-Plack-compatible variable in reports/borrower_stats.pl. To test: 1) Apply patch 2) Use the borrower report wizard to create a report that includes an extended patron attribute. 3) Check the logs, and make sure that you don't see any of the following messages: Variable "$period" is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14763|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15153&action=edit Bug 9451: Quiet warnings and Plackify borrower_stats.pl There are several warnings and one non-Plack-compatible variable in reports/borrower_stats.pl. To test: 1) Apply patch 2) Use the borrower report wizard to create a report that includes an extended patron attribute. 3) Check the logs, and make sure that you don't see any of the following messages: Variable "$period" is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Looks good. The patch removes some warning in the log file under Plack. No behavior changed under Apache. Note: some others warnings still exist (subroutine foo redefined). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15153|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15157&action=edit Bug 9451: Quiet warnings and Plackify borrower_stats.pl There are several warnings and one non-Plack-compatible variable in reports/borrower_stats.pl. To test: 1) Apply patch 2) Use the borrower report wizard to create a report that includes an extended patron attribute. 3) Check the logs, and make sure that you don't see any of the following messages: Variable "$period" is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Comment on attachment 15157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15157 Bug 9451: Quiet warnings and Plackify borrower_stats.pl Review of attachment 15157: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9451&attachment=15157) ----------------------------------------------------------------- ::: reports/borrowers_stats.pl @@ +56,4 @@
$filters[3]=format_date_in_iso($filters[3]); $filters[4]=format_date_in_iso($filters[4]); my $digits = $input->param("digits"); +our $period = $input->param("period");
Hmm, i still think our is kinda hacky, but it works -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org