[Bug 37143] New: Patron registration allows for saving required fields with a single space instead of information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Bug ID: 37143 Summary: Patron registration allows for saving required fields with a single space instead of information Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.scheer@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When creating a patron or self registration a single space (or series of spaces) can be saved instead of required information in fields. This can cause difficulties in finding patrons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- "difficulties" = 500 error searching for patrons where the erroneous patron is part of the result set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- This is true for staff interface patron reg as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- For example: 1. Do a patron search in the staff interface for all patrons. In k-t-d this works fine. 2. Self register a patron. For the required firstname and surname fields use an empty string like " ". 3. You can successfully register. 4. Go back to the staff client and do the same patron search, it never completes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167936&action=edit Bug 37143: Do not allow required fields with only whitespace to be submitted To test: 1. Make some fields for OPAC self registration required. 2. Create a new patron via self reg. 3. Fill out those required fields as an empty string like " ". 4. Submit the form, it succeeds. 5. APPLY PATCH, restart_all 6. Try again. Required fields with only whitespace are treated as if they were empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- The patch no longer applies. I did manage to fix the patch, but the QA tidy showed an issue with this line - the double commas: opac/opac-memberentry.pl 280 branchcode => $patron->branchcode,, I'm not sure if fixing this should be in another bug. The fixed patch does work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167936|0 |1 is obsolete| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 192161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192161&action=edit Bug 37143: Do not allow required fields with only whitespace to be submitted To test: 1. Make some fields for OPAC self registration required. 2. Create a new patron via self reg. 3. Fill out those required fields as an empty string like " ". 4. Submit the form, it succeeds. 5. APPLY PATCH, restart_all 6. Try again. Required fields with only whitespace are treated as if they were empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 192179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192179&action=edit Bug 37143: Do not allow required fields with only whitespace to be submitted To test: 1. Make some fields for OPAC self registration required. 2. Create a new patron via self reg. 3. Fill out those required fields as an empty string like " ". 4. Submit the form, it succeeds. 5. APPLY PATCH, restart_all 6. Try again. Required fields with only whitespace are treated as if they were empty. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Text to go in the| |This changes the OPAC release notes| |self-registration form | |validation so that required | |fields need actual | |information, and not just | |spaces. | | | |Before this, spaces could | |be entered into most | |required fields and the | |form would successfully | |submit. Now, when | |submitting, a warning is | |generated to fill in all | |missing fields for required | |fields with just spaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 [Bug 41735] Remove double comma in source code for OPAC self-registration page (QA error) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 192181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192181&action=edit Bug 37143: Do not allow required fields with only whitespace to be submitted To test: 1. Make some fields for OPAC self registration required. 2. Create a new patron via self reg. 3. Fill out those required fields as an empty string like " ". 4. Submit the form, it succeeds. 5. APPLY PATCH, restart_all 6. Try again. Required fields with only whitespace are treated as if they were empty. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|41735 | --- Comment #9 from David Nind <david@davidnind.com> --- Amended patch to fix qa tidy warning. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41735 [Bug 41735] Remove double comma in source code for OPAC self-registration page (QA error) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 192191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192191&action=edit Bug 37143: Do not allow required fields with only whitespace to be submitted To test: 1. Make some fields for OPAC self registration required. 2. Create a new patron via self reg. 3. Fill out those required fields as an empty string like " ". 4. Submit the form, it succeeds. 5. APPLY PATCH, restart_all 6. Try again. Required fields with only whitespace are treated as if they were empty. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hope that I can still type a single digit everywhere ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192191|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 195315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195315&action=edit Bug 37143: Do not allow required fields with only whitespace to be submitted To test: 1. Make some fields for OPAC self registration required. 2. Create a new patron via self reg. 3. Fill out those required fields as an empty string like " ". 4. Submit the form, it succeeds. 5. APPLY PATCH, restart_all 6. Try again. Required fields with only whitespace are treated as if they were empty. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 --- Comment #14 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.05 |26.05.00,25.11.05,25.05.12 released in| | --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Backported to 25.05.x for 25.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|26.05.00,25.11.05,25.05.12 |26.05.00,25.11.05,25.05.12, released in| |24.11.18 Status|Pushed to oldoldstable |Pushed to oldoldoldstable --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37143 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org