[Bug 35975] New: Download cart with BIBTEX contains hash value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Bug ID: 35975 Summary: Download cart with BIBTEX contains hash value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org @book{Koha::Biblio=HASH(0x560e89ade4b8), author = {Schwartz, Randal L. and Phoenix, Tom}, title = {Learning Perl /}, etc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36336 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can't really test, because it seems almost all export options now result in an error 500: Bug 36336 - Exporting records from detail page is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- I also noticed this. C4::Record::marc2bibtex($marc_record, $biblionumber) second parameter expects a biblionumber. opac-downloadcart.pl is passing it a Koha::Biblio. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 --- Comment #3 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 175698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175698&action=edit Bug 35975: Show biblionumber when download cart as BibTeX To test: 1. In OPAC, add a record to your cart 2. Go to your cart 3. Click Download -> BibTeX 4. Observe downloaded file in your favorite text editor 5. Observe Koha::Hash(xxx) within file contents 6. Apply patch 7. Repeat steps 3 and 4 8. Observe Koha::Hash has been replaced with biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175698|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175720&action=edit Bug 35975: Show biblionumber when download cart as BibTeX To test: 1. In OPAC, add a record to your cart 2. Go to your cart 3. Click Download -> BibTeX 4. Observe downloaded file in your favorite text editor 5. Observe Koha::Hash(xxx) within file contents 6. Apply patch 7. Repeat steps 3 and 4 8. Observe Koha::Hash has been replaced with biblionumber Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA by RM. Also checked the staff interface: the error didn't exist there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the contents of release notes| |the BibTeX file downloaded | |from an OPAC cart - it now | |correctly shows the record | |number, instead of | |Koha::Hash(xxx). | | | |Example | |of incorrect BibTeX file | |format: | |@book{Koha::Biblio=HASH(0x5 | |60e89ade4b8), <--- should | |have been 262 | | | |author = {Christiansen, | |Tom. and Foy, Brian D.}, | | | | title = {Programming | |Perl /}, | | publisher | |= {O'Reilly,}, | | year | |= {c2012.}, | | address | |= {Beijing ;}, | | | |edition = {4th ed.}, | | | | note = {Rev. ed. of: | |Programming Perl / Larry | |Wall, Tom Christiansen & | |Jon Orwant. 2000. 3rd ed.} | |} -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Download cart with BIBTEX |Downloaded cart with BibTeX |contains hash value |contains hash value instead | |of the record number -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x (or 23.XX) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35975 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #9 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org