[Bug 11982] New: Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Bug ID: 11982 Summary: Show local cover images in the biblio details page in the intranet. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: fcapovilla@live.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 26514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26514&action=edit Show local cover image in the intranet biblio details page. This patch adds local cover images to the biblio details page in the intranet. This patch also fixes a small problem when using Amazon and Local covers at the same time : If the image is found locally, but not on Amazon, the "No cover image" was shown under the local image in the virtual shelves on the OPAC. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 26515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26515&action=edit 2 images After applying the patch I uploaded a local cover image. It does show on the detail page, but it still shows the 'no image' icon from amazon as well. Normally, I'd be fine with that, but since you mentioned that this patch fixed that I thought I should point it out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26514|0 |1 is obsolete| | --- Comment #2 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30625&action=edit Show local cover image in the intranet biblio details page. Also, fix useless "No cover image" block when using Amazon and local cover images at the same time. Fixed merge conflicts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #3 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30626&action=edit Bug 11982 - Fixed the amazon no image icon. A no image icon will only be displayed if both the amazon and local images are missing. Added hyperlink to details on the local image in the search result page. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #4 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30627&action=edit Bug 11982 - Images now display properly in the details section. If the a cover image exists, it will be displayed on the details page. Nothing is displayed of there is no cover available. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu@inlibro.com Assignee|koha-bugs@lists.koha-commun |maxime.beaulieu@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hbraum@nekls.org --- Comment #5 from Heather Braum <hbraum@nekls.org> --- I tried testing this patch, and got the following message when applying the patch: Applying: Show local cover image in the intranet biblio details page. Also, fix useless "No cover image" block when using Amazon and local cover images at the same time. fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Show local cover image in the intranet biblio details page. Also, fix useless "No cover image" block when using Amazon and local cover images at the same time. It's my first time using git to test patches, so it may be me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Heather, patches apply for me after doing a git pull on master this morning - could you maybe try again? I think maybe your master was a little bit behind and Maxime had just rebased the patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #7 from Heather Braum <hbraum@nekls.org> --- Katrin, I tried again this morning, and the patches applied successfully (yay!); thanks for the encouragement. However, bear with the testing newbie, I have two questions: 1) Should I even sign off on this patch if it doesn't have a test plan? 2) The uploaded image is displaying on my test system in an odd place. Is that a problem within the scope of this patch (see linked screenshot: http://goo.gl/ZveVYw), my setup, or a separate issue? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Heather, thanks for trying again :) I think you are right - it doesn't look quite right at the moment. Maybe you could attach your screenshot here and ask Maxime to take a look? If you are unsure about how something is supposed to work, asking for a test plan is always ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #9 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30689&action=edit Details-Both_Images -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #10 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30690&action=edit Details-One_Image -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #11 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> ---
2) The uploaded image is displaying on my test system in an odd place. Is that a problem within the scope of this patch (see linked screenshot: http://goo.gl/ZveVYw), my setup, or a separate issue?
I would like to know more about your test browser. Images are displayed correctly for me in Firefox 29. (See attachements) Here is a test plan. 1) Enable both amazon and local cover images in sysprefs 2) Create 4 test records 1) Local image only 2) Amazon image only 3) Both images 4) No image 3) Display all records in a search result. 4) Check the tumbnails. The only record with "No cover image available" thumbnail should be item 4 5) Go to the details page for each item. The "No cover image available" thumbnail should not appear for any record, only the images that were set / found on amazon are displayed on this page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30625|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32636&action=edit [SIGNED-OFF] Bug 11982 - Show local cover image in the intranet biblio details page Also, fix useless "No cover image" block when using Amazon and local cover images at the same time. http://bugs.koha-community.org/show_bug.cgi?id=11982 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30626|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32637&action=edit [SIGNED-OFF] Bug 11982 - Fixed the amazon no image icon. A no image icon will only be displayed if both the amazon and local images are missing. Added hyperlink to details on the local image in the search result page. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30627|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32638&action=edit [SIGNED-OFF] Bug 11982 - Images now display properly in the details section. If the a cover image exists, it will be displayed on the details page. Nothing is displayed of there is no cover available. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on this! I noticed that the "IE Hack" was changed, could someone verify this displays ok in IE? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #15)
I noticed that the "IE Hack" was changed, could someone verify this displays ok in IE?
IE11 - Works as expected IE9 - Works as expected IE8 - JavaScript error on search results, but it's unrelated to this patch - Local covers don't display on search results, but it could be because script execution was interrupted by the above error - Local covers don't display on detail pages. "No cover available" box is seen alongside the Amazon cover image for the record which has both. The browser does not report a JS error. In my opinion the IE8 issues could be addressed in a follow-up--or ignored, as other IE8 JavaScript errors have been. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32746&action=edit [PASSED QA] Bug 11982 - Show local cover image in the intranet biblio details page Also, fix useless "No cover image" block when using Amazon and local cover images at the same time. http://bugs.koha-community.org/show_bug.cgi?id=11982 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32747&action=edit [PASSED QA] Bug 11982 - Fixed the amazon no image icon. A no image icon will only be displayed if both the amazon and local images are missing. Added hyperlink to details on the local image in the search result page. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32748&action=edit [PASSED QA] Bug 11982 - Images now display properly in the details section. If the a cover image exists, it will be displayed on the details page. Nothing is displayed of there is no cover available. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, passes tests and QA script. Checked Amazon covers and local covers display correctly in staff on results and detail pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32637|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, it seems some rebasing is needed. Will be watghing this one to push it ASAP. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #21 from simith.doliveira@inlibro.com --- Created attachment 34813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34813&action=edit Bug 11982 - Images now display properly in the details section. If the a cover image exists, it will be displayed on the details page. Nothing is displayed of there is no cover available. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, passes tests and QA script. Checked Amazon covers and local covers display correctly in staff on results and detail pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34813|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #22 from simith.doliveira@inlibro.com --- Created attachment 34815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34815&action=edit Bug 11982 - Show local cover image in the intranet biblio details page Also, fix useless "No cover image" block when using Amazon and local cover images at the same time. http://bugs.koha-community.org/show_bug.cgi?id=11982 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34815|0 |1 is obsolete| | --- Comment #23 from simith.doliveira@inlibro.com --- Created attachment 34816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34816&action=edit Bug 11982 - Show local cover image in the intranet biblio details page - conflit fixed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32748|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |nick@quecheelibrary.org --- Comment #24 from Nick Clemens <nick@quecheelibrary.org> --- I tried looking at this, I think that two patches were obsoleted that shouldn't have been. If I am right 32747 and 34813 should be un-obsoleted and the patch can be moved to passed-qa as I think a small rebase doesn't need a new signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tested with one patch visible on the bug report right now and found a small regression: Problem: Amazon cover exists, no local cover With patch: no cover is shown in detail page Without patch: Amazon cover shows Problem?: Amazon cover and local cover exist With patch: local cover is shown Without patch: Amazon cover is shown OK: Only local cover exists With patch: local cover is shown Without patch: no cover is shown Simith or Maxime, can you please take a look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34813|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34815|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34813|0 |1 is obsolete| | Attachment #34815|0 |1 is obsolete| | --- Comment #26 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 36626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36626&action=edit Bug 11982 - Fixed the amazon no image icon. A no image icon will only be displayed if both the amazon and local images are missing. Added hyperlink to details on the local image in the search result page. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #27 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 36627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36627&action=edit Some obsolete patches were needed and not rebased. I have rebased and reuploaded the patches. Bug 11982 - Images now display properly in the details section. If the a cover image exists, it will be displayed on the details page. Nothing is displayed of there is no cover available. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, passes tests and QA script. Checked Amazon covers and local covers display correctly in staff on results and detail pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36627|Some obsolete patches were |Bug 11982 - Images now description|needed and not rebased. |display properly in the | |details -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Plase take a look at comment 25 too! Thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #29 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- (In reply to Katrin Fischer from comment #28)
Plase take a look at comment 25 too! Thx!
The regression was caused by the missing patches. If you apply all three you should not see any problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Maxime Beaulieu from comment #29)
(In reply to Katrin Fischer from comment #28)
Plase take a look at comment 25 too! Thx!
The regression was caused by the missing patches. If you apply all three you should not see any problems.
With all three patches, I'm not seeing those problems! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34816|0 |1 is obsolete| | Attachment #36626|0 |1 is obsolete| | Attachment #36627|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36852&action=edit [PASSED QA] Bug 11982 - Show local cover image in the intranet biblio details page Also, fix useless "No cover image" block when using Amazon and local cover images at the same time. http://bugs.koha-community.org/show_bug.cgi?id=11982 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36853&action=edit [PASSED QA] Bug 11982 - Fixed the amazon no image icon. A no image icon will only be displayed if both the amazon and local images are missing. Added hyperlink to details on the local image in the search result page. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36854&action=edit [PASSED QA] Bug 11982 - Images now display properly in the details section. If the a cover image exists, it will be displayed on the details page. Nothing is displayed of there is no cover available. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, passes tests and QA script. Checked Amazon covers and local covers display correctly in staff on results and detail pages. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Frederick! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7187 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #35 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11358 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org