[Bug 27851] New: Add Koha::Old::Checkouts->filter_by_todays_checkins method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Bug ID: 27851 Summary: Add Koha::Old::Checkouts->filter_by_todays_checkins method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Bug 12224 is adding code in the controller to retrieve today's checkins. There is already kind of the same code in members/readingrec.pl (op=export_barcodes). We should provide a Koha::Old::Checkouts->filter_by_todays_checkins method, provide tests, and use it in both places. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 [Bug 12224] Allow easy printing of patron check-in slip -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117800&action=edit Bug 27851: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117801&action=edit Bug 27851: Add Koha::Old::Checkouts->filter_by_todays_checkins The logic for this code is handled at two different places (and in 2 different ways). Better to centralize and provide tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117802&action=edit Bug 27851: Use filter_by_todays_checkins in printslip.pl Test plan: No regression from bug 12224 test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 117803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117803&action=edit Bug 27851: Use filter_by_todays_checkins in members/readingrec.pl Test plan: Do some checkouts Checkin with different return dates (several today however) Check the circulation history and confirm that the checkout list is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117801|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117822&action=edit Bug 27851: Add Koha::Old::Checkouts->filter_by_todays_checkins The logic for this code is handled at two different places (and in 2 different ways). Better to centralize and provide tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117802|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117823&action=edit Bug 27851: Use filter_by_todays_checkins in printslip.pl Test plan: No regression from bug 12224 test plan Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117803|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117824&action=edit Bug 27851: Use filter_by_todays_checkins in members/readingrec.pl Test plan: Do some checkouts Checkin with different return dates (several today however) Check the circulation history and confirm that the checkout list is correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117800|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117825&action=edit Bug 27851: Add tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117822|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117826&action=edit Bug 27851: Add Koha::Old::Checkouts->filter_by_todays_checkins The logic for this code is handled at two different places (and in 2 different ways). Better to centralize and provide tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117823|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117827&action=edit Bug 27851: Use filter_by_todays_checkins in printslip.pl Test plan: No regression from bug 12224 test plan Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117824|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117828&action=edit Bug 27851: Use filter_by_todays_checkins in members/readingrec.pl Test plan: Do some checkouts Checkin with different return dates (several today however) Check the circulation history and confirm that the checkout list is correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tests pass, I checked the behaviour or the checkin slip, the reading history and also the behavior for the AnonymousPatron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117825|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117836&action=edit Bug 27851: Add tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117826|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117837&action=edit Bug 27851: Add Koha::Old::Checkouts->filter_by_todays_checkins The logic for this code is handled at two different places (and in 2 different ways). Better to centralize and provide tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117827|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117838&action=edit Bug 27851: Use filter_by_todays_checkins in printslip.pl Test plan: No regression from bug 12224 test plan Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117828|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117839&action=edit Bug 27851: Use filter_by_todays_checkins in members/readingrec.pl Test plan: Do some checkouts Checkin with different return dates (several today however) Check the circulation history and confirm that the checkout list is correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27851 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28896 [Bug 28896] Checkin Slip doesn't work for anonymized checkouts -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org