[Bug 18395] New: Wrong article request methods in Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Bug ID: 18395 Summary: Wrong article request methods in Koha::Patrons Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 [Bug 14610] Add ability to place article requests in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61939&action=edit Bug 18395: (bug 14601 followup) Remove article requests methods from Koha::Patrons There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong Test plan: prove t/db_dependent/ArticleRequests.t should still return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61939|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 61943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61943&action=edit Bug 18395: (bug 14601 followup) Remove article requests methods from Koha::Patrons There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong Test plan: prove t/db_dependent/ArticleRequests.t should still return green Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 61960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61960&action=edit Bug 18395: (bug 14610 followup) Remove article requests methods from Koha::Patrons There is something very wrong with the new subroutines, they have been added to both Koha::Patron and Koha::Patrons: % git grep 'sub article_request' Koha/Patron*.pm Koha/Patron.pm:sub article_requests { Koha/Patron.pm:sub article_requests_current { Koha/Patron.pm:sub article_requests_finished { Koha/Patrons.pm:sub article_requests { Koha/Patrons.pm:sub article_requests_current { Koha/Patrons.pm:sub article_requests_finished { The ones in Koha::Patrons are wrong Test plan: prove t/db_dependent/ArticleRequests.t should still return green Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Doesn't apply cleanly to 16.11.x - will skip this. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org