https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 97679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97679&action=edit Bug 24473: Add $raw filter for Syndetics content TEST PLAN: 1. have a Syndetics account set up and turn on the Syndetics system preferences. 2. Find title(s) with Syndetics content for 'Title Notes', 'About The Author', 'Excerpt' and 'Reviews'. 3. Notice that any HTML markup displays literally. 4. Apply patch and restart_all. 5. Notice that HTML should display correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin@ub.lu.se -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #4)

Can we imagine whitelist a list of html tags?

Can you explain this a bit? I am not sure what the Syndetics code looks like, but as it's a paid for service... I hope the risk of malicious code would be small here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #6)

Cait,

Syndetics sends HTML. So a description might look like this:

<p>Dementors and House-elves, merpeople and Chinese Fireball Dragons--these are just a few of the magical creatures and frightening monsters populating J. K. Rowling's wizarding world. Harry Potter: The Creature Vault is a fascinating look at how this menagerie was brought to life for the blockbuster Harry Potter film series. Detailed profiles of each creature include rare concept illustrations, behind-the-scenes photography, and filmmaking secrets from the Warner Bros. archive. A removable poster picturing each of the creatures and an interactive Eeylops Owl Emporium catalog complete this must-have package.</p>

Librarians would like this to $raw filter on the OPAC.

Hi Lucas, I understand, I was wondering about Jonathan's suggestion. Whitelisting might actually work if it's only <p> etc. but wondering if they send styling information etc. too. Leaning the way that $raw might be safer? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Wonder if there is any technical documentation on the Syndectics API we could check - maybe there is a way to receive data without HTML? Or there are hints on what can be included. Not sure we should block this tho - You pay for Syndetics services, so it seems reasonable to assume the data will be ok. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 jduffels@coh.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jduffels@coh.org --- Comment #11 from jduffels@coh.org --- We are having issues similar to Jeremy and Katrin. What I find odd is that often for the same record, the Syndetics info will look fine for one section, say the tile notes, but display the Syndetics tags in another, such as the excerpt. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I see that Stina had signed this off originally, setting back to "signed off". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98077|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106805&action=edit Bug 24473: Add $raw filter for Syndetics content Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Syndetics provides enhanced release notes| |content which is displayed | |in the OPAC under the tabs | |'Title Notes', 'Excerpt', | |'About the author', and | |'Editions'. They provide | |this information as HTML | |but Koha currently displays | |the content with the HTML | |tags. This fixes this so | |that the enhanced content | |displays correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.