https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67117&action=edit Bug 19299: Replace C4::Reserves::GetReservesForBranch with Koha::Holds->waiting GetReservesForBranch simply returns the waiting holds, for a specific branch of not. This can easily be replaced with a call to Koha::Holds->waiting To avoid any regressions, I reuse the exact conditions (priority = 0), but I do not think it is useful. Test plan: Make sure the holds information are correctly displayed on the waiting holds screen. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +# FIXME - Is priority => 0 useful? If yes it must be moved to waiting, otherwise we need to remove it from here. Since set_waiting sets priority to 0, we should not need to check priority again. But the test has been used more often in that way: return 'Waiting' if $found eq 'W' and $priority == 0; IF found is W or T, priority should be 0. Priority is no longer of importance when an item has been set to Waiting. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68815|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 68908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68908&action=edit Bug 19299: Replace C4::Reserves::GetReservesForBranch with Koha::Holds->waiting GetReservesForBranch simply returns the waiting holds, for a specific branch of not. This can easily be replaced with a call to Koha::Holds->waiting To avoid any regressions, I reuse the exact conditions (priority = 0), but I do not think it is useful. Test plan: Make sure the holds information are correctly displayed on the waiting holds screen. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Skipping for 17.11, enhancement. -- You are receiving this mail because: You are watching all bug changes.