[Bug 39371] New: Holds to Place Count should have a character limit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Bug ID: 39371 Summary: Holds to Place Count should have a character limit Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Currently the 'Holds to Place' count does not have a character limit. Which means that if a staff member accidentally scans a barcode into this field and saves, it could lead to thousands of reserves even if there is a hold limit of 100 or less. Adding a character limit could help prevent future issues with this field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 179482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179482&action=edit Bug 39371: Added character limit to Holds to place (count) To test: 1. Go to place a hold for a patron. Under 'Hold next available item' the 'Holds to place (count) defaults to 1. When you go to edit the input you do not have a limit. You can enter an endless number. 2. Apply the patch. 3. Repeat step 1. When you go to edit the input now there is a 3 character limit. This should prevent accidentally scanning of barcodes in this area. 4. Sign off and have an amazing day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179482|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 180408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180408&action=edit Bug 39371: Add a max character limit to "Holds to place" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- To test: 1. Go to place a hold for a patron. Under 'Hold next available item' the 'Holds to place (count) defaults to 1. When you go to edit the input you do not have a limit. You can enter an endless number. 2. Apply the patch. 3. Repeat step 1. When you go to edit the input now there is a 3 character limit. This should prevent accidentally scanning of barcodes in this area. 4. Sign off and have an amazing day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- I tried adding 10 holds for one patron, but only two got added. I assume this is because I have "Holds per record (count)" = 2 in the "Circulation and fine rules". Libraries could have a high number there and be annoyed if a high number of holds are added. But then they should have a high number there because they want to allow a high number of holds. Would it be possible to limit the field based on the "Holds per record (count)"? Would it make sense to also do this like the "Add multiple copies of this item" below the item cataloguing form? Where there is a limit on 3 characters, but there is also a JS confirmation, where you get asked "You are about to add 999 items. Continue?" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Katariina Pohto <katariina.pohto@ouka.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katariina.pohto@ouka.fi --- Comment #5 from Katariina Pohto <katariina.pohto@ouka.fi> --- I tested this on BibLibre sandbox and it worked as described. Though adding the confirmation window for any large number of reservations seems like a good idea. In connection to 'Holds per record' restriction in circulation rules, it would be really good to at least get a notice/warning that only X number of reservations can be / was made. If there's already plenty of resevations on the record, it can be quite hard to notice if all the new reservations were actually created. This could be another issue completely though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Sorry, I'll set this to "Failed QA" as at least two of us seem to agree it needs a little more work. It will be great to have the field not be completely free text, though! :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- ...and I forgot to change the status! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 183470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183470&action=edit Bug 39371: Limit "Holds to place" input based on holds_per_record rule and prompt for multiple holds To test: 1. Go to place a hold for a patron. Under "Hold next available item," the "Holds to place (count)" field should default to 1. Before applying t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180408|0 |1 is obsolete| | --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 183471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183471&action=edit Bug 39371: Limit "Holds to place" input based on holds_per_record rule and prompt for multiple holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Test plan: 1. Go to place a hold for a patron. Under "Hold next available item," the "Holds to place (count)" field should default to 1. Before applying the patch, this input: * Has no maximum limit * Allows entry of any number, even extremely high values * Does not show a confirmation prompt 2. Apply the patch. 3. Repeat step 1. Now: * The maximum number of holds allowed is based on the holds_per_record circulation rule * If holds_per_record is set (e.g., 2), you cannot enter more than that * If it's blank (meaning unlimited), no max is set * A note appears under the input: * “The maximum number of holds to place is 2.” (or whatever the rule is) * Or: “There is no set maximum for holds.” if blank * If you enter more than 1, you will see a confirmation prompt: * “Are you sure you want to place 3 hold(s)?” * If you enter 1 hold, it proceeds without prompting 4. Try entering 0 or leaving the field blank: * The minimum is enforced as 1 * The system defaults back to placing 1 hold 5. Confirm that the input box: * Allows up/down arrows if a numeric max is set * Behaves correctly with keyboard input * Respects the configured circulation rule 6. Sign off and have an amazing day! 🎉 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- One of our coding guidelines warns against using input type "number": https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC2:_Input_type_.22n... I think it would be better to add some JS validation to check the valid range. There are a lot of whitespace changes in this patch. What's that about? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39371 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|Laura.escamilla@bywatersolu |koha-bugs@lists.koha-commun |tions.com |ity.org Status|Failed QA |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org