[Bug 34106] New: Patron search in member-search-box.inc always defaults to 'Starts with' search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Bug ID: 34106 Summary: Patron search in member-search-box.inc always defaults to 'Starts with' search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. In the main search header switch to 'Search patrons'. Bring up the dropdown and look at 'Search type:'. 2. It defaults to 'Starts with'. 3. Go to '/cgi-bin/koha/members/members-home.pl' and look at the 'Search type:' on the left side. 4. It defaults to 'Contains' 5. Do a patron search from both these places, setting the 'Search type' to contains. 6. The search bar in the header always resets to 'Starts with' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- I think these should both default to 'contains'/ And if you do a search with 'contains' it should always retain that parameter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152604&action=edit Bug 34106: Retain searchtype parameter in member-search-box To test: 1. In the main search header switch to 'Search patrons'. Bring up the dropdown and look at 'Search type:'. 2. It defaults to 'Starts with'. 3. Go to '/cgi-bin/koha/members/members-home.pl' and look at the 'Search type:' on the left side. 4. It defaults to 'Contains' 5. Do a patron search from both these places, setting the 'Search type' to contains. 6. The search bar in the header always resets to 'Starts with' 7. Apply patch 8. Try everything again. By default both places should default to contain. 9. If you change the 'Search type' the search in the main header should always retain that value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Marked as major because this can severely effect library workflows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Ed Veal <eveal@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152604|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 152641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152641&action=edit Bug 34106: Retain searchtype parameter in member-search-box To test: 1. In the main search header switch to 'Search patrons'. Bring up the dropdown and look at 'Search type:'. 2. It defaults to 'Starts with'. 3. Go to '/cgi-bin/koha/members/members-home.pl' and look at the 'Search type:' on the left side. 4. It defaults to 'Contains' 5. Do a patron search from both these places, setting the 'Search type' to contains. 6. The search bar in the header always resets to 'Starts with' 7. Apply patch 8. Try everything again. By default both places should default to contain. 9. If you change the 'Search type' the search in the main header should always retain that value. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Please see also bug 34094 and bug 34092.. They both also resolve this issue I believe and attempt to ratify the code too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34092 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34094 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152641|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152743&action=edit Bug 34106: Retain searchtype parameter in member-search-box To test: 1. In the main search header switch to 'Search patrons'. Bring up the dropdown and look at 'Search type:'. 2. It defaults to 'Starts with'. 3. Go to '/cgi-bin/koha/members/members-home.pl' and look at the 'Search type:' on the left side. 4. It defaults to 'Contains' 5. Do a patron search from both these places, setting the 'Search type' to contains. 6. The search bar in the header always resets to 'Starts with' 7. Apply patch 8. Try everything again. By default both places should default to contain. 9. If you change the 'Search type' the search in the main header should always retain that value. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152748&action=edit Bug 34106: Update header search box searchtype when form is submitted We're updating the side menu searchtype when the search header is submitted, we should also update the searchtype in the search header when the form is submitted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- @Lucas For me it felt weird having it update one way but not the other. Can you test my patch and confirm it makes sense? Feel free to drop it if it doesn't! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Since this is fixed in Bug 34094 we can mark this as resolved. *** This bug has been marked as a duplicate of bug 34094 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34094 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34094 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Lucas, I don't think I was very clear here.. I rebased 34094 upon this removing the inline fixes there so we could keep the distinct parts of the fix clear and separate.. Pedro also added a follow-up to your patch here to improve the handling further. I've unmarked it as duplicate and restored the dependency chain.. just going to test and SO it myself here now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34094 [Bug 34094] Apply DefaultPatronSearchMethod to all patron search forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152743|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152785&action=edit Bug 34106: Retain searchtype parameter in member-search-box To test: 1. In the main search header switch to 'Search patrons'. Bring up the dropdown and look at 'Search type:'. 2. It defaults to 'Starts with'. 3. Go to '/cgi-bin/koha/members/members-home.pl' and look at the 'Search type:' on the left side. 4. It defaults to 'Contains' 5. Do a patron search from both these places, setting the 'Search type' to contains. 6. The search bar in the header always resets to 'Starts with' 7. Apply patch 8. Try everything again. By default both places should default to contain. 9. If you change the 'Search type' the search in the main header should always retain that value. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152748|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152786&action=edit Bug 34106: Update header search box searchtype when form is submitted We're updating the side menu searchtype when the search header is submitted, we should also update the searchtype in the search header when the form is submitted Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34092 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Sorry for the confusion here. Thanks Martin and Pedro, the follow-up makes perfect sense to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34106 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36339 [Bug 36339] Using patron search filters may clear "search type" settings in "More options" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org