[Bug 34865] New: Syspref OPACURLOpenInNewWindow not working for Library URLs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Bug ID: 34865 Summary: Syspref OPACURLOpenInNewWindow not working for Library URLs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: klas.blomberg@skovde.se QA Contact: testopia@bugs.koha-community.org The syspref OPACURLOpenInNewWindow is not working for URLs entered in Administration>Libraries>...>URL Links to the libraries homepages opens in same window, in spite of being external links. This bug affects both the library listing: https://bibliotekmellansjo.se/cgi-bin/koha/opac-library.pl and library names in catalogue records: https://bibliotekmellansjo.se/cgi-bin/koha/opac-detail.pl?biblionumber=44390... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156165&action=edit Bug 34865: Use OPACURLOpenInNewWindow for library URLs If a library has a URL defined it is shown in the OPAC under the libraries page. This patch updates the template so that the link respects the OPACURLOpenInNewWindow system preference. To test, apply the patch and go to Administration -> Libraries and edit a library if necessary so that it has a URL defined. In the OPAC, go to the Libraries page. Test that the library link respects whichever setting you have for OPACURLOpenInNewWindow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156165|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 156228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156228&action=edit Bug 34865: Use OPACURLOpenInNewWindow for library URLs If a library has a URL defined it is shown in the OPAC under the libraries page. This patch updates the template so that the link respects the OPACURLOpenInNewWindow system preference. To test, apply the patch and go to Administration -> Libraries and edit a library if necessary so that it has a URL defined. In the OPAC, go to the Libraries page. Test that the library link respects whichever setting you have for OPACURLOpenInNewWindow Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156228|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 156247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156247&action=edit Bug 34865: Use OPACURLOpenInNewWindow for library URLs If a library has a URL defined it is shown in the OPAC under the libraries page. This patch updates the template so that the link respects the OPACURLOpenInNewWindow system preference. To test, apply the patch and go to Administration -> Libraries and edit a library if necessary so that it has a URL defined. In the OPAC, go to the Libraries page. Test that the library link respects whichever setting you have for OPACURLOpenInNewWindow Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x In order to avoid behavior change in a stable version -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org