[Bug 11545] New: Increasing test coverage for C4::Languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Bug ID: 11545 Summary: Increasing test coverage for C4::Languages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: manuelimel@gmail.com QA Contact: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 --- Comment #1 from Merllissia Manueli <manuelimel@gmail.com> --- Created attachment 24254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24254&action=edit Proposed Patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Merllissia Manueli <manuelimel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 AlexHorsman <dhorsman@xtra.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24254|0 |1 is obsolete| | --- Comment #2 from AlexHorsman <dhorsman@xtra.co.nz> --- Created attachment 24260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24260&action=edit bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run Signed-off-by: alex_h <dhorsman@xtra.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24260|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 24298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24298&action=edit [SIGNED-OFF] bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run Signed-off-by: alex_h <dhorsman@xtra.co.nz> Signed-off-by: Magnus Enger <magnus@enger.priv.no> Adds another passing test. I took th liberty of moving the test plan from the subject to the commit message. :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24298|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24308&action=edit [PASSED QA] bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run Signed-off-by: alex_h <dhorsman@xtra.co.nz> Signed-off-by: Magnus Enger <magnus@enger.priv.no> Adds another passing test. I took th liberty of moving the test plan from the subject to the commit message. :-) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests pass :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11545 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that moves Languages.t to t/db_dependent. That signals that the test script requires that there be a Koha database to connect to, as is required in order to test getAllLanguages(). Congratulations on having your first patch accepted into Koha, Merllissia! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org